https://sonarly.com/issue/29397?type=bug When a user navigates away from a workflow page while the side panel is open to a workflow step editor (e.g. WorkflowTriggerSelectType), PageChangeEffect calls closeSidePanelMenu() which initiates a two-phase close: Phase 1 sets isSidePanelOpenedState=false and isSidePanelClosingState=true but does NOT clear sidePanelPageState or sidePanelPageInfoState. Phase 2 (the actual cleanup) is deferred to the CSS transitionend event on StyledSidePanelWrapper's width transition. During the close animation, the side panel content continues to render (shouldShowContent = isSidePanelOpened || shouldRenderContent — shouldRenderContent remains true until handleTransitionEnd fires). The SidePanelRouter contains a framer-motion motion.div that animates opacity. When this inner opacity transition completes, its transitionend event bubbles up to StyledSidePanelWrapper's onTransitionEnd handler. Because handleTransitionEnd does NOT filter by event.propertyName === 'width' or event.target === event.currentTarget, the handler runs prematurely on the bubbled opacity event. At this point, isSidePanelOpened is false and isSidePanelClosing is true, so handleTransitionEnd executes setShouldRenderContent(false) AND sidePanelCloseAnimationCompleteCleanup(). The cleanup resets sidePanelPageInfoState.instanceId to '' and sidePanelPageState to CommandMenuDisplay. However, between the cleanup's Jotai store.set calls, React may re-render the still-mounted SidePanelRouter. If sidePanelPageInfoState.instanceId is reset to '' while sidePanelPageState is still WorkflowTriggerSelectType during an intermediate render, SidePanelRouter renders SidePanelWorkflowSelectTriggerType with instanceId=''. This component calls useSidePanelWorkflowIdOrThrow() which reads sidePanelWorkflowIdComponentState scoped to instanceId='' — an atom instance that was never populated (the workflow ID was set for the original UUID-based instanceId). The atom returns undefined (its default), and the hook throws. Fix: Added event filtering to `handleTransitionEnd` in `SidePanelForDesktop.tsx` to only process `width` transitions on the wrapper element itself (`event.target !== event.currentTarget || event.propertyName !== 'width'`). This prevents bubbled `transitionend` events from child elements (specifically the framer-motion `<motion.div>` opacity animation inside `SidePanelRouter`) from triggering premature `sidePanelCloseAnimationCompleteCleanup()` during the close animation. Without this filter, the cleanup resets `sidePanelPageInfoState.instanceId` to `''` while workflow components are still mounted, causing them to read an unpopulated atom instance and throw. An identical fix already exists on unmerged branch `sonarly-19891-side-panel-crash-from-unguarded-ontransitionend` (commit `256dbd7fc2`) for the same root cause manifesting as a different symptom ("Record id is not defined" in SidePanelRecordPage). |
||
|---|---|---|
| .claude-pr | ||
| .cursor | ||
| .github | ||
| .vscode | ||
| .yarn | ||
| packages | ||
| .dockerignore | ||
| .gitattributes | ||
| .gitignore | ||
| .mcp.json | ||
| .nvmrc | ||
| .yarnrc.yml | ||
| CLAUDE.md | ||
| jest.preset.js | ||
| LICENSE | ||
| nx.json | ||
| package.json | ||
| README.md | ||
| tsconfig.base.json | ||
| yarn.config.cjs | ||
| yarn.lock | ||
The #1 Open-Source CRM
Website ·
Documentation ·
Roadmap ·
Discord ·
Figma
Why Twenty
Twenty gives technical teams the building blocks for a custom CRM that meets complex business needs and quickly adapts as the business evolves. Twenty is the CRM you build, ship, and version like the rest of your stack.
Learn more about why we built Twenty
Installation
Cloud
The fastest way to get started. Sign up at twenty.com and spin up a workspace in under a minute, with no infrastructure to manage and always up to date.
Build an app
Scaffold a new app with the Twenty CLI:
npx create-twenty-app my-app
Define objects, fields, and views as code:
import { defineObject, FieldType } from 'twenty-sdk/define';
export default defineObject({
nameSingular: 'deal',
namePlural: 'deals',
labelSingular: 'Deal',
labelPlural: 'Deals',
fields: [
{ name: 'name', label: 'Name', type: FieldType.TEXT },
{ name: 'amount', label: 'Amount', type: FieldType.CURRENCY },
{ name: 'closeDate', label: 'Close Date', type: FieldType.DATE_TIME },
],
});
Then ship it to your workspace:
npx twenty deploy
See the app development guide for objects, views, agents, and logic functions.
Self-hosting
Run Twenty on your own infrastructure with Docker Compose, or contribute locally via the local setup guide.
Everything you need
Twenty gives you the building blocks of a modern CRM (objects, views, workflows, and agents) and lets you extend them as code. Here's a tour of what's in the box.
Want to go deeper? Read the User Guide for product walkthroughs, or the
Documentation for developer reference.
|
|
|
|
|
|
Stack
TypeScript
Nx
NestJS, with BullMQ,
PostgreSQL,
Redis
React, with Jotai, Linaria and Lingui
Thanks
Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).
Join the Community
Star the repo ·
Discord ·
Feature requests ·
Releases ·
X ·
LinkedIn ·
Crowdin ·
Contribute