Elgato_dark/twenty
1
0
Fork 0
mirror of https://github.com/twentyhq/twenty synced 2026-04-21 13:37:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

fix: guard handleTransitionEnd against bubbled child transitions and harden workflow component during close

Browse source 
https://sonarly.com/issue/29397?type=bug

When a user navigates away from a workflow page while the side panel is open to a workflow step editor (e.g. WorkflowTriggerSelectType), PageChangeEffect calls closeSidePanelMenu() which initiates a two-phase close: Phase 1 sets isSidePanelOpenedState=false and isSidePanelClosingState=true but does NOT clear sidePanelPageState or sidePanelPageInfoState. Phase 2 (the actual cleanup) is deferred to the CSS transitionend event on StyledSidePanelWrapper's width transition.

During the close animation, the side panel content continues to render (shouldShowContent = isSidePanelOpened || shouldRenderContent — shouldRenderContent remains true until handleTransitionEnd fires). The SidePanelRouter contains a framer-motion motion.div that animates opacity. When this inner opacity transition completes, its transitionend event bubbles up to StyledSidePanelWrapper's onTransitionEnd handler. Because handleTransitionEnd does NOT filter by event.propertyName === 'width' or event.target === event.currentTarget, the handler runs prematurely on the bubbled opacity event.

At this point, isSidePanelOpened is false and isSidePanelClosing is true, so handleTransitionEnd executes setShouldRenderContent(false) AND sidePanelCloseAnimationCompleteCleanup(). The cleanup resets sidePanelPageInfoState.instanceId to '' and sidePanelPageState to CommandMenuDisplay. However, between the cleanup's Jotai store.set calls, React may re-render the still-mounted SidePanelRouter. If sidePanelPageInfoState.instanceId is reset to '' while sidePanelPageState is still WorkflowTriggerSelectType during an intermediate render, SidePanelRouter renders SidePanelWorkflowSelectTriggerType with instanceId=''. This component calls useSidePanelWorkflowIdOrThrow() which reads sidePanelWorkflowIdComponentState scoped to instanceId='' — an atom instance that was never populated (the workflow ID was set for the original UUID-based instanceId). The atom returns undefined (its default), and the hook throws.

Fix: Added event filtering to `handleTransitionEnd` in `SidePanelForDesktop.tsx` to only process `width` transitions on the wrapper element itself (`event.target !== event.currentTarget || event.propertyName !== 'width'`). This prevents bubbled `transitionend` events from child elements (specifically the framer-motion `<motion.div>` opacity animation inside `SidePanelRouter`) from triggering premature `sidePanelCloseAnimationCompleteCleanup()` during the close animation. Without this filter, the cleanup resets `sidePanelPageInfoState.instanceId` to `''` while workflow components are still mounted, causing them to read an unpopulated atom instance and throw.

An identical fix already exists on unmerged branch `sonarly-19891-side-panel-crash-from-unguarded-ontransitionend` (commit `256dbd7fc2`) for the same root cause manifesting as a different symptom ("Record id is not defined" in SidePanelRecordPage).
This commit is contained in:
Sonarly Claude Code 2026-04-21 11:17:35 +00:00
parent 8cdd2a3319
commit 3adee873d6
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/twenty-front/src/modules/side-panel/components/SidePanelForDesktop.tsx
View file

@ -18,7 +18,7 @@ import { useAtomState } from '@/ui/utilities/state/jotai/hooks/useAtomState';
import { useAtomStateValue } from '@/ui/utilities/state/jotai/hooks/useAtomStateValue';
import { useSetAtomState } from '@/ui/utilities/state/jotai/hooks/useSetAtomState';
import { styled } from '@linaria/react';
import { useCallback, useState } from 'react';
import { type TransitionEvent, useCallback, useState } from 'react';
import { themeCssVariables } from 'twenty-ui/theme-constants';
const StyledSidePanelWrapper = styled.div<{
@ -81,7 +81,16 @@ export const SidePanelForDesktop = () => {
const shouldShowContent = isSidePanelOpened || shouldRenderContent;
const handleTransitionEnd = () => {
const handleTransitionEnd = (
event: TransitionEvent<HTMLDivElement>,
) => {
if (
event.target !== event.currentTarget ||
event.propertyName !== 'width'
) {
return;
}
if (isSidePanelOpened) {
// Open animation completed - ensure content persists for close animation
setShouldRenderContent(true);