mirror of
https://github.com/LerianStudio/ring
synced 2026-04-21 21:47:49 +00:00
7fd01e41f7
The parallel code review process expands from 3 to 5 reviewers to enhance code quality. This introduces `ring:test-reviewer` and `ring:nil-safety-reviewer` to provide deeper analysis of test coverage and null safety patterns, improving overall reliability. The `dev-cycle` workflow is upgraded from a 6-gate to a 10-gate process, incorporating a sophisticated suite of automated testing gates: - Unit Testing (Gate 3) - Fuzz Testing (Gate 4) - Property-based Testing (Gate 5) - Integration Testing (Gate 6) - Chaos Testing (Gate 7) This change establishes a much higher standard for testing and ensures features are more resilient and production-ready. Finally, new agents and commands are added to the PMO and Product plugins to support delivery tracking, design validation, and reporting, further extending the system's capabilities across the development lifecycle. All documentation is updated to reflect these enhancements.
141 lines
4.9 KiB
Markdown
141 lines
4.9 KiB
Markdown
---
|
|
name: ring:execute-plan
|
|
description: Execute plan in batches with review checkpoints
|
|
argument-hint: "[plan-file-path]"
|
|
---
|
|
|
|
Execute an existing implementation plan with controlled checkpoints and code review between batches. Supports autonomous one-go execution or batch mode with human review at each checkpoint.
|
|
|
|
## Usage
|
|
|
|
```
|
|
/ring:execute-plan [plan-file-path]
|
|
```
|
|
|
|
## Arguments
|
|
|
|
| Argument | Required | Description |
|
|
|----------|----------|-------------|
|
|
| `plan-file-path` | Yes | Path to the plan file (e.g., `docs/plans/2024-01-15-auth-feature.md`) |
|
|
|
|
## Examples
|
|
|
|
### Execute a Feature Plan
|
|
```
|
|
/ring:execute-plan docs/plans/2024-01-15-oauth-integration.md
|
|
```
|
|
Loads and executes the OAuth integration plan with review checkpoints.
|
|
|
|
### Execute from Absolute Path
|
|
```
|
|
/ring:execute-plan /Users/dev/project/docs/plans/2024-01-15-api-refactor.md
|
|
```
|
|
Executes a plan using its full path.
|
|
|
|
### Execute Latest Plan
|
|
```
|
|
/ring:execute-plan docs/plans/2024-01-20-notification-system.md
|
|
```
|
|
Executes the most recent plan for the notification system feature.
|
|
|
|
## Process
|
|
|
|
### Step 1: Load and Review Plan
|
|
- Reads the plan file
|
|
- Critically reviews for any questions or concerns
|
|
- Raises issues with you before starting
|
|
- Creates TodoWrite to track progress
|
|
|
|
### Step 2: Choose Execution Mode (MANDATORY)
|
|
You will be asked to choose between:
|
|
|
|
| Mode | Behavior |
|
|
|------|----------|
|
|
| **One-go (autonomous)** | Executes all batches continuously with code review between each; no human review until completion |
|
|
| **Batch (with review)** | Executes one batch, pauses for human feedback after code review, then continues |
|
|
|
|
### Step 3: Execute Batch
|
|
- Default batch size: first 3 tasks
|
|
- Each task is marked in_progress, executed, then completed
|
|
- Dispatches to specialized agents when available:
|
|
- Backend Go: `ring:backend-engineer-golang`
|
|
- Backend TypeScript: `ring:backend-engineer-typescript`
|
|
- Frontend React/Next.js/BFF: `frontend-bff-engineer-typescript`
|
|
- Infrastructure: `ring:devops-engineer`
|
|
- Testing: `ring:qa-analyst`
|
|
- Reliability: `ring:sre`
|
|
|
|
### Step 4: Run Code Review
|
|
After each batch, all 5 reviewers run in parallel:
|
|
- `ring:code-reviewer` - Architecture and patterns
|
|
- `ring:business-logic-reviewer` - Requirements and edge cases
|
|
- `ring:security-reviewer` - OWASP and auth validation
|
|
- `ring:test-reviewer` - Test coverage and quality
|
|
- `ring:nil-safety-reviewer` - Null/nil safety patterns
|
|
|
|
**Issue handling by severity:**
|
|
| Severity | Action |
|
|
|----------|--------|
|
|
| Critical/High/Medium | Fix immediately, re-run all reviewers |
|
|
| Low | Add `TODO(review):` comment in code |
|
|
| Cosmetic/Nitpick | Add `FIXME(nitpick):` comment in code |
|
|
|
|
### Step 5: Report and Continue
|
|
**One-go mode:** Continues to next batch automatically, reports only at final completion.
|
|
|
|
**Batch mode:** Shows implementation summary, verification output, and code review results. Waits for your feedback before proceeding.
|
|
|
|
### Step 6: Complete Development
|
|
After all tasks complete:
|
|
- Uses `ring:finishing-a-development-branch` skill
|
|
- Verifies tests pass
|
|
- Presents options for branch completion
|
|
|
|
## Related Commands/Skills
|
|
|
|
| Command/Skill | Relationship |
|
|
|---------------|--------------|
|
|
| `/ring:write-plan` | Use first to create the plan file |
|
|
| `/ring:brainstorm` | Use before ring:writing-plans if design unclear |
|
|
| `ring:writing-plans` | Creates the plan files this command executes |
|
|
| `ring:requesting-code-review` | Called automatically after each batch |
|
|
| `ring:finishing-a-development-branch` | Called at completion |
|
|
|
|
## Troubleshooting
|
|
|
|
### "No plan file found"
|
|
Ensure the path is correct. Plans are typically stored in `docs/plans/`. Use `ls docs/plans/` to list available plans.
|
|
|
|
### "Plan has critical gaps"
|
|
The plan was reviewed and found to have issues preventing execution. You'll be asked to clarify or revise the plan before proceeding.
|
|
|
|
### "Verification failed repeatedly"
|
|
Execution stops when a verification step fails multiple times. Review the output to determine if the plan needs revision or if there's an environmental issue.
|
|
|
|
### "Code review finds Critical issues"
|
|
All Critical, High, and Medium issues must be fixed before proceeding. The reviewers will re-run after fixes until the batch passes.
|
|
|
|
### Execution mode was not asked
|
|
If you're not prompted for execution mode, this is a violation of the skill protocol. The mode selection is mandatory regardless of any "just execute" or "don't wait" instructions.
|
|
|
|
### When NOT to use this command
|
|
- No plan exists - use `/ring:write-plan` first
|
|
- Plan needs revision - use `/ring:brainstorm` to refine the design
|
|
- Working on independent tasks in current session - use `ring:subagent-driven-development` skill directly
|
|
|
|
---
|
|
|
|
## MANDATORY: Load Full Skill
|
|
|
|
**This command MUST load the skill for complete workflow execution.**
|
|
|
|
```
|
|
Use Skill tool: ring:executing-plans
|
|
```
|
|
|
|
The skill contains the complete workflow with:
|
|
- Batch execution with review checkpoints
|
|
- Task state management
|
|
- Failure recovery procedures
|
|
- Progress tracking
|
|
- Code review integration
|