mirror of
https://github.com/LerianStudio/ring
synced 2026-04-21 13:37:27 +00:00
feat(workflows): expand code review and dev-cycle with advanced testing
The parallel code review process expands from 3 to 5 reviewers to enhance code quality. This introduces `ring:test-reviewer` and `ring:nil-safety-reviewer` to provide deeper analysis of test coverage and null safety patterns, improving overall reliability. The `dev-cycle` workflow is upgraded from a 6-gate to a 10-gate process, incorporating a sophisticated suite of automated testing gates: - Unit Testing (Gate 3) - Fuzz Testing (Gate 4) - Property-based Testing (Gate 5) - Integration Testing (Gate 6) - Chaos Testing (Gate 7) This change establishes a much higher standard for testing and ensures features are more resilient and production-ready. Finally, new agents and commands are added to the PMO and Product plugins to support delivery tracking, design validation, and reporting, further extending the system's capabilities across the development lifecycle. All documentation is updated to reflect these enhancements.
This commit is contained in:
Fred Amaral
parent
de8f326258
commit
7fd01e41f7
15 changed files with 258 additions and 179 deletions
134
ARCHITECTURE.md
134
ARCHITECTURE.md
|
|
@ -33,18 +33,18 @@ Ring operates on three core principles:
|
|||
│ │ Ring Marketplace │ │
|
||||
│ │ ┌──────────────────────┐ ┌──────────────────────┐ │ │
|
||||
│ │ │ ring-default │ │ ring-dev-team │ │ │
|
||||
│ │ │ Skills(25) Agents(7) │ │ Skills(9) Agents(9) │ │ │
|
||||
│ │ │ Skills(25) Agents(7) │ │ Skills(13) Agents(10)│ │ │
|
||||
│ │ │ Cmds(12) Hooks/Lib │ │ Cmds(5) │ │ │
|
||||
│ │ └──────────────────────┘ └──────────────────────┘ │ │
|
||||
│ │ ┌──────────────────────┐ ┌──────────────────────┐ │ │
|
||||
│ │ │ ring-pm-team │ │ ring-tw-team │ │ │
|
||||
│ │ │ Skills(10) Agents(3) │ │ Skills(7) Agents(3) │ │ │
|
||||
│ │ │ Cmds(2) │ │ Cmds(3) │ │ │
|
||||
│ │ │ Skills(13) Agents(4) │ │ Skills(7) Agents(3) │ │ │
|
||||
│ │ │ Cmds(3) │ │ Cmds(3) │ │ │
|
||||
│ │ └──────────────────────┘ └──────────────────────┘ │ │
|
||||
│ │ ┌──────────────────────┐ ┌──────────────────────┐ │ │
|
||||
│ │ │ ring-finops-team │ │ ring-pmo-team │ │ │
|
||||
│ │ │ Skills(6) Agents(2) │ │ Skills(8) Agents(5) │ │ │
|
||||
│ │ └──────────────────────┘ │ Cmds(3) │ │ │
|
||||
│ │ │ Skills(7) Agents(3) │ │ Skills(9) Agents(6) │ │ │
|
||||
│ │ └──────────────────────┘ │ Cmds(4) │ │ │
|
||||
│ │ └──────────────────────┘ │ │
|
||||
│ └───────────────────────────────────────────────────────────────────────────┘ │
|
||||
│ │
|
||||
|
|
@ -75,10 +75,10 @@ _Versions managed in `.claude-plugin/marketplace.json`_
|
|||
| Plugin | Description | Components |
|
||||
| -------------------- | ------------------------------------ | -------------------------------- |
|
||||
| **ring-default** | Core skills library | 25 skills, 7 agents, 12 commands |
|
||||
| **ring-dev-team** | Developer agents | 9 skills, 9 agents, 5 commands |
|
||||
| **ring-dev-team** | Developer agents | 13 skills, 10 agents, 5 commands |
|
||||
| **ring-finops-team** | FinOps regulatory compliance | 7 skills, 3 agents |
|
||||
| **ring-pm-team** | Product planning workflows | 10 skills, 4 agents, 2 commands |
|
||||
| **ring-pmo-team** | PMO portfolio management specialists | 8 skills, 5 agents, 3 commands |
|
||||
| **ring-pm-team** | Product planning workflows | 13 skills, 4 agents, 3 commands |
|
||||
| **ring-pmo-team** | PMO portfolio management specialists | 9 skills, 6 agents, 4 commands |
|
||||
| **ring-tw-team** | Technical writing specialists | 7 skills, 3 agents, 3 commands |
|
||||
|
||||
## Component Hierarchy
|
||||
|
|
@ -128,33 +128,35 @@ default/agents/
|
|||
|
||||
```
|
||||
dev-team/agents/
|
||||
├── ring:backend-engineer-golang.md # Go backend specialist for financial systems
|
||||
├── ring:backend-engineer-typescript.md # TypeScript/Node.js backend specialist
|
||||
├── ring:devops-engineer.md # DevOps infrastructure specialist
|
||||
├── frontend-bff-engineer-typescript.md # BFF & React/Next.js frontend specialist
|
||||
├── ring:frontend-designer.md # Visual design specialist
|
||||
├── ring:frontend-engineer.md # General frontend development
|
||||
├── prompt-quality-reviewer.md # AI prompt quality review
|
||||
├── ring:qa-analyst.md # Quality assurance specialist
|
||||
└── sre.md # Site reliability engineer
|
||||
├── ring:backend-engineer-golang.md # Go backend specialist for financial systems
|
||||
├── ring:backend-engineer-typescript.md # TypeScript/Node.js backend specialist
|
||||
├── ring:devops-engineer.md # DevOps infrastructure specialist
|
||||
├── ring:frontend-bff-engineer-typescript.md # BFF & React/Next.js frontend specialist
|
||||
├── ring:frontend-designer.md # Visual design specialist
|
||||
├── ring:frontend-engineer.md # General frontend development
|
||||
├── ring:prompt-quality-reviewer.md # AI prompt quality review
|
||||
├── ring:qa-analyst.md # Quality assurance specialist
|
||||
├── ring:sre.md # Site reliability engineer
|
||||
└── ring:ui-engineer.md # UI component specialist
|
||||
```
|
||||
|
||||
**Structure (ring-pmo-team plugin):**
|
||||
|
||||
```
|
||||
pmo-team/agents/
|
||||
├── delivery-reporter.md # Delivery progress reporting
|
||||
├── executive-reporter.md # Executive dashboards and communications
|
||||
├── governance-specialist.md # Gate reviews and process compliance
|
||||
├── portfolio-manager.md # Portfolio-level planning and coordination
|
||||
├── resource-planner.md # Capacity planning and allocation
|
||||
├── risk-analyst.md # Portfolio risk identification and mitigation
|
||||
├── governance-specialist.md # Gate reviews and process compliance
|
||||
└── executive-reporter.md # Executive dashboards and communications
|
||||
└── risk-analyst.md # Portfolio risk identification and mitigation
|
||||
```
|
||||
|
||||
**Key Characteristics:**
|
||||
|
||||
- Invoked via Claude's `Task` tool with `subagent_type`
|
||||
- Must specify model (typically "opus" for comprehensive analysis)
|
||||
- Review agents run in parallel (3 reviewers dispatch simultaneously via `/ring:codereview` command)
|
||||
- Review agents run in parallel (5 reviewers dispatch simultaneously via `/ring:codereview` command)
|
||||
- Developer agents provide specialized domain expertise
|
||||
- Return structured reports with severity-based findings
|
||||
|
||||
|
|
@ -244,18 +246,41 @@ All ring-dev-team agents include a `## Standards Compliance` section in their ou
|
|||
|
||||
```
|
||||
default/commands/
|
||||
├── brainstorm.md # /ring:brainstorm - Socratic design refinement
|
||||
├── ring:codereview.md # /ring:codereview - Parallel 3-reviewer dispatch
|
||||
├── commit.md # /ring:commit - Git commit with trailers
|
||||
├── ring:execute-plan.md # /ring:execute-plan - Batch execution
|
||||
├── ring:explore-codebase.md # /ring:explore-codebase - Deep architecture analysis
|
||||
├── lint.md # /ring:lint - Run linters and fix issues
|
||||
├── worktree.md # /ring:worktree - Git worktree creation
|
||||
└── ring:write-plan.md # /ring:write-plan - Implementation planning
|
||||
├── brainstorm.md # /ring:brainstorm - Socratic design refinement
|
||||
├── codereview.md # /ring:codereview - Parallel 5-reviewer dispatch
|
||||
├── commit.md # /ring:commit - Git commit with trailers
|
||||
├── create-handoff.md # /ring:create-handoff - Create session handoff
|
||||
├── execute-plan.md # /ring:execute-plan - Batch execution
|
||||
├── explore-codebase.md # /ring:explore-codebase - Deep architecture analysis
|
||||
├── interview-me.md # /ring:interview-me - Interactive interview
|
||||
├── lint.md # /ring:lint - Run linters and fix issues
|
||||
├── release-guide.md # /ring:release-guide - Release guidance
|
||||
├── resume-handoff.md # /ring:resume-handoff - Resume from handoff
|
||||
├── worktree.md # /ring:worktree - Git worktree creation
|
||||
└── write-plan.md # /ring:write-plan - Implementation planning
|
||||
|
||||
pm-team/commands/
|
||||
├── ring:pre-dev-feature.md # /ring:pre-dev-feature - 3-gate workflow
|
||||
└── ring:pre-dev-full.md # /ring:pre-dev-full - 8-gate workflow
|
||||
├── delivery-status.md # /ring:delivery-status - Delivery status tracking
|
||||
├── pre-dev-feature.md # /ring:pre-dev-feature - 5-gate workflow
|
||||
└── pre-dev-full.md # /ring:pre-dev-full - 10-gate workflow
|
||||
|
||||
pmo-team/commands/
|
||||
├── delivery-report.md # /ring:delivery-report - PMO delivery reporting
|
||||
├── dependency-analysis.md # /ring:dependency-analysis - Dependency analysis
|
||||
├── executive-summary.md # /ring:executive-summary - Executive summary
|
||||
└── portfolio-review.md # /ring:portfolio-review - Portfolio review
|
||||
|
||||
dev-team/commands/
|
||||
├── dev-cancel.md # /ring:dev-cancel - Cancel dev cycle
|
||||
├── dev-cycle.md # /ring:dev-cycle - 10-gate development cycle
|
||||
├── dev-refactor.md # /ring:dev-refactor - Standards refactoring
|
||||
├── dev-report.md # /ring:dev-report - Development reporting
|
||||
└── dev-status.md # /ring:dev-status - Development status
|
||||
|
||||
tw-team/commands/
|
||||
├── review-docs.md # /ring:review-docs - Documentation review
|
||||
├── write-api.md # /ring:write-api - API documentation
|
||||
└── write-guide.md # /ring:write-guide - Guide writing
|
||||
```
|
||||
|
||||
**Key Characteristics:**
|
||||
|
|
@ -300,6 +325,7 @@ default/hooks/
|
|||
├── ring-dev-team # Developer agents
|
||||
├── ring-finops-team # FinOps regulatory
|
||||
├── ring-pm-team # Product planning
|
||||
├── ring-pmo-team # PMO specialists
|
||||
└── ring-tw-team # Technical writing
|
||||
```
|
||||
|
||||
|
|
@ -335,6 +361,12 @@ default/hooks/
|
|||
"source": "./pm-team",
|
||||
"keywords": ["product", "planning"]
|
||||
},
|
||||
{
|
||||
"name": "ring-pmo-team",
|
||||
"version": "...",
|
||||
"source": "./pmo-team",
|
||||
"keywords": ["pmo", "portfolio", "governance"]
|
||||
},
|
||||
{
|
||||
"name": "ring-tw-team",
|
||||
"version": "...",
|
||||
|
|
@ -396,11 +428,13 @@ sequenceDiagram
|
|||
participant ring:code-reviewer
|
||||
participant ring:business-logic-reviewer
|
||||
participant ring:security-reviewer
|
||||
participant ring:test-reviewer
|
||||
participant ring:nil-safety-reviewer
|
||||
|
||||
User->>Claude: /ring:codereview
|
||||
Note over Claude: Command provides<br/>parallel review workflow
|
||||
|
||||
Claude->>Task Tool: Dispatch 3 parallel tasks
|
||||
Claude->>Task Tool: Dispatch 5 parallel tasks
|
||||
|
||||
par Parallel Execution
|
||||
Task Tool->>ring:code-reviewer: Review architecture
|
||||
|
|
@ -408,11 +442,17 @@ sequenceDiagram
|
|||
Task Tool->>ring:business-logic-reviewer: Review correctness
|
||||
and
|
||||
Task Tool->>ring:security-reviewer: Review vulnerabilities
|
||||
and
|
||||
Task Tool->>ring:test-reviewer: Review test coverage
|
||||
and
|
||||
Task Tool->>ring:nil-safety-reviewer: Review nil safety
|
||||
end
|
||||
|
||||
ring:code-reviewer-->>Claude: Return findings
|
||||
ring:business-logic-reviewer-->>Claude: Return findings
|
||||
ring:security-reviewer-->>Claude: Return findings
|
||||
ring:test-reviewer-->>Claude: Return findings
|
||||
ring:nil-safety-reviewer-->>Claude: Return findings
|
||||
|
||||
Note over Claude: Aggregate & prioritize by severity
|
||||
Claude->>User: Consolidated report
|
||||
|
|
@ -475,13 +515,15 @@ User Request → ring:using-ring check → Relevant skill?
|
|||
### Pattern 2: Parallel Review Execution
|
||||
|
||||
```
|
||||
Review Request → /ring:codereview → Dispatch 3 Tasks (parallel)
|
||||
Review Request → /ring:codereview → Dispatch 5 Tasks (parallel)
|
||||
├─ ring:code-reviewer ─┐
|
||||
├─ ring:business-logic-reviewer ─┼─→ Aggregate findings → Handle by severity
|
||||
└─ ring:security-reviewer ─┘
|
||||
├─ ring:business-logic-reviewer │
|
||||
├─ ring:security-reviewer ┼─→ Aggregate findings → Handle by severity
|
||||
├─ ring:test-reviewer │
|
||||
└─ ring:nil-safety-reviewer ─┘
|
||||
```
|
||||
|
||||
**Implementation:** Single message with 3 Task tool calls ensures parallel execution. All reviewers work independently and return simultaneously.
|
||||
**Implementation:** Single message with 5 Task tool calls ensures parallel execution. All reviewers work independently and return simultaneously.
|
||||
|
||||
### Pattern 3: Skill-to-Command Mapping
|
||||
|
||||
|
|
@ -538,7 +580,7 @@ Complex Skill → TodoWrite tracking
|
|||
|
||||
- `/ring:brainstorm` → `ring:brainstorming` skill
|
||||
- `/ring:write-plan` → `ring:writing-plans` skill
|
||||
- `/ring:codereview` → dispatches 3 parallel review agents (`ring:code-reviewer`, `ring:business-logic-reviewer`, `ring:security-reviewer`)
|
||||
- `/ring:codereview` → dispatches 5 parallel review agents (`ring:code-reviewer`, `ring:business-logic-reviewer`, `ring:security-reviewer`, `ring:test-reviewer`, `ring:nil-safety-reviewer`)
|
||||
|
||||
### Skills ↔ Shared Patterns
|
||||
|
||||
|
|
@ -745,25 +787,25 @@ _Component counts reflect current state; plugin versions managed in `.claude-plu
|
|||
| ------------------------- | ---------- | ---------------------- |
|
||||
| Active Plugins | 6 | All plugin directories |
|
||||
| Skills (ring-default) | 25 | `default/skills/` |
|
||||
| Skills (ring-dev-team) | 9 | `dev-team/skills/` |
|
||||
| Skills (ring-dev-team) | 13 | `dev-team/skills/` |
|
||||
| Skills (ring-finops-team) | 7 | `finops-team/skills/` |
|
||||
| Skills (ring-pm-team) | 10 | `pm-team/skills/` |
|
||||
| Skills (ring-pmo-team) | 8 | `pmo-team/skills/` |
|
||||
| Skills (ring-pm-team) | 13 | `pm-team/skills/` |
|
||||
| Skills (ring-pmo-team) | 9 | `pmo-team/skills/` |
|
||||
| Skills (ring-tw-team) | 7 | `tw-team/skills/` |
|
||||
| **Total Skills** | **66** | **All plugins** |
|
||||
| **Total Skills** | **74** | **All plugins** |
|
||||
| Agents (ring-default) | 7 | `default/agents/` |
|
||||
| Agents (ring-dev-team) | 10 | `dev-team/agents/` |
|
||||
| Agents (ring-finops-team) | 3 | `finops-team/agents/` |
|
||||
| Agents (ring-pm-team) | 4 | `pm-team/agents/` |
|
||||
| Agents (ring-pmo-team) | 5 | `pmo-team/agents/` |
|
||||
| Agents (ring-pmo-team) | 6 | `pmo-team/agents/` |
|
||||
| Agents (ring-tw-team) | 3 | `tw-team/agents/` |
|
||||
| **Total Agents** | **32** | **All plugins** |
|
||||
| **Total Agents** | **33** | **All plugins** |
|
||||
| Commands (ring-default) | 12 | `default/commands/` |
|
||||
| Commands (ring-dev-team) | 5 | `dev-team/commands/` |
|
||||
| Commands (ring-pm-team) | 2 | `pm-team/commands/` |
|
||||
| Commands (ring-pmo-team) | 3 | `pmo-team/commands/` |
|
||||
| Commands (ring-pm-team) | 3 | `pm-team/commands/` |
|
||||
| Commands (ring-pmo-team) | 4 | `pmo-team/commands/` |
|
||||
| Commands (ring-tw-team) | 3 | `tw-team/commands/` |
|
||||
| **Total Commands** | **25** | **All plugins** |
|
||||
| **Total Commands** | **27** | **All plugins** |
|
||||
| Hooks | Per plugin | `{plugin}/hooks/` |
|
||||
|
||||
The system achieves these goals through clear component separation, structured workflows, automatic context management, and a modular marketplace architecture, creating a robust foundation for AI-assisted software development.
|
||||
|
|
|
|||
53
CLAUDE.md
53
CLAUDE.md
|
|
@ -53,7 +53,8 @@ When modifying standards files (`dev-team/docs/standards/*.md`):
|
|||
2. **Update TOC** - Add section to the `## Table of Contents` at the top of the same file
|
||||
3. Edit `dev-team/skills/shared-patterns/standards-coverage-table.md` - Add section to agent's index table
|
||||
4. Edit `dev-team/agents/{agent}.md` - Verify agent references coverage table (not inline categories)
|
||||
5. **All files in same commit** - Never update one without the others
|
||||
|
||||
**All files in same commit** - Never update one without the others.
|
||||
|
||||
**⛔ TOC MAINTENANCE RULE:**
|
||||
Every standards file has a `## Table of Contents` section that MUST stay in sync:
|
||||
|
|
@ -334,7 +335,7 @@ Use these sparingly and only at the **beginning** of instructions:
|
|||
Examples:
|
||||
- MUST dispatch agent before proceeding to next gate
|
||||
- STOP and report if PROJECT_RULES.md is missing
|
||||
- HARD GATE: All 3 reviewers must pass before Gate 5
|
||||
- HARD GATE: All 5 reviewers must pass before Gate 5
|
||||
- FORBIDDEN: Reading source code directly as orchestrator
|
||||
```
|
||||
|
||||
|
|
@ -425,17 +426,17 @@ Ring is a comprehensive skills library and workflow system for AI agents that en
|
|||
**Active Plugins:**
|
||||
|
||||
- **ring-default**: 25 core skills, 12 slash commands, 7 specialized agents
|
||||
- **ring-dev-team**: 9 development skills, 5 slash commands, 9 developer agents (Backend Go, Backend TypeScript, DevOps, Frontend TypeScript, Frontend Designer, QA, SRE)
|
||||
- **ring-pm-team**: 12 product management skills, 3 research agents, 3 slash commands (includes delivery planning + status tracking)
|
||||
- **ring-pmo-team**: 8 PMO skills, 3 slash commands, 5 PMO agents (Portfolio Manager, Resource Planner, Risk Analyst, Governance Specialist, Executive Reporter)
|
||||
- **ring-dev-team**: 13 development skills, 5 slash commands, 10 developer agents (Backend Go, Backend TypeScript, DevOps, Frontend TypeScript, Frontend Designer, Frontend Engineer, QA, SRE, UI Engineer, Prompt Quality Reviewer)
|
||||
- **ring-pm-team**: 13 product management skills, 4 research agents, 3 slash commands (includes delivery planning + status tracking + Product Designer)
|
||||
- **ring-pmo-team**: 9 PMO skills, 4 slash commands, 6 PMO agents (Portfolio Manager, Resource Planner, Risk Analyst, Governance Specialist, Executive Reporter, Delivery Reporter)
|
||||
- **ring-finops-team**: 7 regulatory skills, 3 FinOps agents (Analyzer, Automation, Infrastructure Cost Estimator)
|
||||
- **ring-tw-team**: 7 technical writing skills, 3 slash commands, 3 documentation agents (Functional Writer, API Writer, Docs Reviewer)
|
||||
|
||||
**Note:** Plugin versions are managed in `.claude-plugin/marketplace.json`
|
||||
|
||||
**Total: 68 skills (25 + 9 + 12 + 8 + 7 + 7) across 6 plugins**
|
||||
**Total: 30 agents (7 + 10 + 4 + 5 + 3 + 3) across 6 plugins**
|
||||
**Total: 26 commands (12 + 5 + 5 + 3 + 0 + 3) across 6 plugins**
|
||||
**Total: 74 skills (25 + 13 + 13 + 9 + 7 + 7) across 6 plugins**
|
||||
**Total: 33 agents (7 + 10 + 4 + 6 + 3 + 3) across 6 plugins**
|
||||
**Total: 27 commands (12 + 5 + 3 + 4 + 0 + 3) across 6 plugins**
|
||||
|
||||
The architecture uses markdown-based skill definitions with YAML frontmatter, auto-discovered at session start via hooks, and executed through Claude Code's native Skill/Task tools.
|
||||
|
||||
|
|
@ -456,9 +457,9 @@ See [README.md](README.md#installation) for detailed installation instructions.
|
|||
| Plugin | Path | Contents |
|
||||
| ---------------- | -------------- | -------------------------------- |
|
||||
| ring-default | `default/` | 25 skills, 7 agents, 12 commands |
|
||||
| ring-dev-team | `dev-team/` | 9 skills, 10 agents, 5 commands |
|
||||
| ring-pm-team | `pm-team/` | 12 skills, 4 agents, 3 commands |
|
||||
| ring-pmo-team | `pmo-team/` | 8 skills, 5 agents, 3 commands |
|
||||
| ring-dev-team | `dev-team/` | 13 skills, 10 agents, 5 commands |
|
||||
| ring-pm-team | `pm-team/` | 13 skills, 4 agents, 3 commands |
|
||||
| ring-pmo-team | `pmo-team/` | 9 skills, 6 agents, 4 commands |
|
||||
| ring-finops-team | `finops-team/` | 7 skills, 3 agents |
|
||||
| ring-tw-team | `tw-team/` | 7 skills, 3 agents, 3 commands |
|
||||
|
||||
|
|
@ -482,11 +483,11 @@ Skill tool: "ring:systematic-debugging" # Debug with 4-phase analysis
|
|||
Skill tool: "ring:using-ring" # Load mandatory workflows
|
||||
|
||||
# Slash commands
|
||||
/ring:codereview # Dispatch 3 parallel reviewers
|
||||
/ring:codereview # Dispatch 5 parallel reviewers
|
||||
/ring:brainstorm # Socratic design refinement
|
||||
/ring:pre-dev-feature # <2 day features (5 gates)
|
||||
/ring:pre-dev-full # ≥2 day features (10 gates)
|
||||
/ring:dev-cycle # 7-gate development cycle (with optional Gate 3.5 for integration-testing)
|
||||
/ring:dev-cycle # 10-gate development cycle
|
||||
/ring:execute-plan # Batch execution with checkpoints
|
||||
/ring:worktree # Create isolated development branch
|
||||
|
||||
|
|
@ -504,10 +505,10 @@ python default/hooks/generate-skills-ref.py # Generate skill overview
|
|||
| Add skill | `mkdir default/skills/name/` → create `SKILL.md` with frontmatter |
|
||||
| Add agent | Create `*/agents/name.md` → verify required sections per [Agent Design](docs/AGENT_DESIGN.md) |
|
||||
| Modify hooks | Edit `*/hooks/hooks.json` → test with `bash */hooks/session-start.sh` |
|
||||
| Code review | `/ring:codereview` dispatches 3 parallel reviewers |
|
||||
| Code review | `/ring:codereview` dispatches 5 parallel reviewers |
|
||||
| Pre-dev (small) | `/ring:pre-dev-feature` → 5-gate workflow |
|
||||
| Pre-dev (large) | `/ring:pre-dev-full` → 10-gate workflow |
|
||||
| Dev cycle (7 gates) | `/ring:dev-cycle [tasks-file]` → implementation→devops→SRE→testing→(optional: integration-testing)→review→validation (see [dev-team/skills/dev-cycle/SKILL.md](dev-team/skills/dev-cycle/SKILL.md)) |
|
||||
| Dev cycle (10 gates) | `/ring:dev-cycle [tasks-file]` → implementation→devops→SRE→unit-testing→fuzz-testing→property-testing→integration-testing→chaos-testing→review→validation (see [dev-team/skills/dev-cycle/SKILL.md](dev-team/skills/dev-cycle/SKILL.md)) |
|
||||
|
||||
See [docs/WORKFLOWS.md](docs/WORKFLOWS.md) for detailed instructions.
|
||||
|
||||
|
|
@ -522,24 +523,18 @@ See [docs/WORKFLOWS.md](docs/WORKFLOWS.md) for detailed instructions.
|
|||
- **Hook Scripts**: Must output JSON with success/error fields
|
||||
- **Shared Patterns**: Reference via `default/skills/shared-patterns/*.md`
|
||||
- **Documentation**: Artifacts in `docs/pre-dev/{feature}/*.md`
|
||||
- **Monorepo Layout**: Each plugin (`default/`, `team-*/`, `dev-team/`) is self-contained
|
||||
- **Monorepo Layout**: Each plugin (`default/`, `{name}-team/`) is self-contained
|
||||
|
||||
### Naming Conventions
|
||||
|
||||
- Skills: `kebab-case` matching directory name
|
||||
- Agents: `{domain}-reviewer.md` format
|
||||
- Agents: `ring:{domain}.md` or `ring:{domain}-reviewer.md` format
|
||||
- Commands: `/{action}` format (e.g., `/ring:brainstorm`, `/ring:pre-dev-feature`)
|
||||
- Hooks: `{event}-{purpose}.sh` format
|
||||
|
||||
#### Agent/Skill/Command Invocation
|
||||
|
||||
- **always use the unified ring: namespace**: `ring:{component}`
|
||||
- **Examples:**
|
||||
- ✅ Correct: `ring:code-reviewer`
|
||||
- ✅ Correct: `ring:backend-engineer-golang`
|
||||
- ❌ Wrong: `<missing ring prefix>` (FORBIDDEN: omitting the `ring:` prefix)
|
||||
- ❌ Wrong: `ring-default:ring:code-reviewer` (deprecated plugin-specific prefix)
|
||||
- **Rationale:** Unified namespace simplifies invocation; plugin routing is handled internally
|
||||
See [Unified Ring Namespace](#4-unified-ring-namespace-always) above for invocation format. Always use `ring:{component}` (e.g., `ring:code-reviewer`, `ring:backend-engineer-golang`).
|
||||
|
||||
---
|
||||
|
||||
|
|
@ -559,14 +554,14 @@ See [docs/AGENT_DESIGN.md](docs/AGENT_DESIGN.md) for complete schema definitions
|
|||
|
||||
## Compliance Rules
|
||||
|
||||
```bash
|
||||
```text
|
||||
# TDD compliance (default/skills/test-driven-development/SKILL.md)
|
||||
- Test file must exist before implementation
|
||||
- Test must produce failure output (RED)
|
||||
- Only then write implementation (GREEN)
|
||||
|
||||
# Review compliance (default/skills/requesting-code-review/SKILL.md)
|
||||
- All 3 reviewers must pass
|
||||
- All 5 reviewers must pass
|
||||
- Critical findings = immediate fix required
|
||||
- Re-run all reviewers after fixes
|
||||
|
||||
|
|
@ -600,9 +595,9 @@ The system loads at SessionStart (from `default/` plugin):
|
|||
- Active plugins: 6 (`ring-default`, `ring-dev-team`, `ring-pm-team`, `ring-pmo-team`, `ring-finops-team`, `ring-tw-team`)
|
||||
- Plugin versions: See `.claude-plugin/marketplace.json`
|
||||
- Core plugin: `default/` (25 skills, 7 agents, 12 commands)
|
||||
- Developer agents: `dev-team/` (9 skills, 10 agents, 5 commands)
|
||||
- Product planning: `pm-team/` (12 skills, 4 agents, 3 commands)
|
||||
- PMO specialists: `pmo-team/` (8 skills, 5 agents, 3 commands)
|
||||
- Developer agents: `dev-team/` (13 skills, 10 agents, 5 commands)
|
||||
- Product planning: `pm-team/` (13 skills, 4 agents, 3 commands)
|
||||
- PMO specialists: `pmo-team/` (9 skills, 6 agents, 4 commands)
|
||||
- FinOps regulatory: `finops-team/` (7 skills, 3 agents)
|
||||
- Technical writing: `tw-team/` (7 skills, 3 agents, 3 commands)
|
||||
- Current git branch: `main`
|
||||
|
|
|
|||
98
MANUAL.md
98
MANUAL.md
|
|
@ -1,6 +1,6 @@
|
|||
# Ring Marketplace Manual
|
||||
|
||||
Quick reference guide for the Ring skills library and workflow system. This monorepo provides 6 plugins with 66 skills, 32 agents, and 25 slash commands for enforcing proven software engineering practices across the entire software delivery value chain.
|
||||
Quick reference guide for the Ring skills library and workflow system. This monorepo provides 6 plugins with 74 skills, 33 agents, and 27 slash commands for enforcing proven software engineering practices across the entire software delivery value chain.
|
||||
|
||||
---
|
||||
|
||||
|
|
@ -13,15 +13,15 @@ Quick reference guide for the Ring skills library and workflow system. This mono
|
|||
│ │
|
||||
│ ┌───────────────┐ ┌───────────────┐ ┌───────────────┐ ┌───────────────┐ │
|
||||
│ │ ring-default │ │ ring-dev-team │ │ ring-pm-team │ │ring-finops- │ │
|
||||
│ │ Skills(25) │ │ Skills(9) │ │ Skills(10) │ │ team │ │
|
||||
│ │ Agents(7) │ │ Agents(9) │ │ Agents(3) │ │ Skills(6) │ │
|
||||
│ │ Cmds(12) │ │ Cmds(5) │ │ Cmds(2) │ │ Agents(2) │ │
|
||||
│ │ Skills(25) │ │ Skills(13) │ │ Skills(13) │ │ team │ │
|
||||
│ │ Agents(7) │ │ Agents(10) │ │ Agents(4) │ │ Skills(7) │ │
|
||||
│ │ Cmds(12) │ │ Cmds(5) │ │ Cmds(3) │ │ Agents(3) │ │
|
||||
│ └───────────────┘ └───────────────┘ └───────────────┘ └───────────────┘ │
|
||||
│ ┌───────────────┐ ┌───────────────┐ │
|
||||
│ │ ring-tw-team │ │ ring-pmo-team │ │
|
||||
│ │ Skills(7) │ │ Skills(8) │ │
|
||||
│ │ Agents(3) │ │ Agents(5) │ │
|
||||
│ │ Cmds(3) │ │ Cmds(3) │ │
|
||||
│ │ Skills(7) │ │ Skills(9) │ │
|
||||
│ │ Agents(3) │ │ Agents(6) │ │
|
||||
│ │ Cmds(3) │ │ Cmds(4) │ │
|
||||
│ └───────────────┘ └───────────────┘ │
|
||||
└────────────────────────────────────────────────────────────────────────────────────┘
|
||||
|
||||
|
|
@ -86,17 +86,18 @@ Commands are invoked directly: `/command-name`.
|
|||
| `/ring:explore-codebase [path]` | Autonomous two-phase codebase exploration | `/ring:explore-codebase payment/` |
|
||||
| `/ring:interview-me [topic]` | Proactive requirements gathering interview | `/ring:interview-me auth-system` |
|
||||
| `/ring:release-guide` | Generate step-by-step release instructions | `/ring:release-guide` |
|
||||
| `/ring:pre-dev-feature [name]` | Plan simple features (<2 days) – 3 gates | `/ring:pre-dev-feature logout-button` |
|
||||
| `/ring:pre-dev-full [name]` | Plan complex features (≥2 days) – 8 gates | `/ring:pre-dev-full payment-system` |
|
||||
| `/ring:pre-dev-feature [name]` | Plan simple features (<2 days) – 5 gates | `/ring:pre-dev-feature logout-button` |
|
||||
| `/ring:pre-dev-full [name]` | Plan complex features (≥2 days) – 10 gates | `/ring:pre-dev-full payment-system` |
|
||||
| `/ring:worktree [branch-name]` | Create isolated git workspace | `/ring:worktree auth-system` |
|
||||
| `/ring:write-plan [feature]` | Generate detailed task breakdown | `/ring:write-plan dashboard-redesign` |
|
||||
| `/ring:execute-plan [path]` | Execute plan in batches with checkpoints | `/ring:execute-plan docs/pre-dev/feature/tasks.md` |
|
||||
| `/ring:delivery-status` | Show delivery status and tracking | `/ring:delivery-status` |
|
||||
|
||||
### Code & Integration Workflows
|
||||
|
||||
| Command | Use Case | Example |
|
||||
| ----------------------------------- | ---------------------------------------------- | ---------------------------------------------------- |
|
||||
| `/ring:codereview [files-or-paths]` | Dispatch 3 parallel code reviewers | `/ring:codereview src/auth/` |
|
||||
| `/ring:codereview [files-or-paths]` | Dispatch 5 parallel code reviewers | `/ring:codereview src/auth/` |
|
||||
| `/ring:commit [message]` | Create git commit with AI trailers | `/ring:commit "fix(auth): improve token validation"` |
|
||||
| `/ring:lint [path]` | Run lint and dispatch agents to fix all issues | `/ring:lint src/` |
|
||||
|
||||
|
|
@ -111,7 +112,7 @@ Commands are invoked directly: `/command-name`.
|
|||
|
||||
| Command | Use Case | Example |
|
||||
| --------------------------- | ---------------------------------- | --------------------------------------- |
|
||||
| `/ring:dev-cycle [task]` | Start 6-gate development workflow | `/ring:dev-cycle "implement user auth"` |
|
||||
| `/ring:dev-cycle [task]` | Start 10-gate development workflow | `/ring:dev-cycle "implement user auth"` |
|
||||
| `/ring:dev-refactor [path]` | Analyze codebase against standards | `/ring:dev-refactor src/` |
|
||||
| `/ring:dev-status` | Show current gate progress | `/ring:dev-status` |
|
||||
| `/ring:dev-report` | Generate development cycle report | `/ring:dev-report` |
|
||||
|
|
@ -132,12 +133,13 @@ Commands are invoked directly: `/command-name`.
|
|||
| `/ring:portfolio-review [scope]` | Comprehensive portfolio review | `/ring:portfolio-review Q1-2025` |
|
||||
| `/ring:dependency-analysis [scope]` | Cross-project dependency mapping | `/ring:dependency-analysis payment-system` |
|
||||
| `/ring:executive-summary [scope]` | Executive status summary | `/ring:executive-summary board-meeting` |
|
||||
| `/ring:delivery-report [scope]` | Generate delivery status report | `/ring:delivery-report Q1-2025` |
|
||||
|
||||
---
|
||||
|
||||
## 💡 About Skills
|
||||
|
||||
Skills (65) are workflows that Claude Code invokes automatically when it detects they're applicable. They handle testing, debugging, verification, planning, and code review enforcement. You don't call them directly – Claude Code uses them internally to enforce best practices.
|
||||
Skills (74) are workflows that Claude Code invokes automatically when it detects they're applicable. They handle testing, debugging, verification, planning, and code review enforcement. You don't call them directly – Claude Code uses them internally to enforce best practices.
|
||||
|
||||
Examples: ring:test-driven-development, ring:systematic-debugging, ring:requesting-code-review, ring:verification-before-completion, ring:production-readiness-audit (27-dimension audit, 10 explorers per batch, incremental report 0–270; see [default/skills/production-readiness-audit/SKILL.md](default/skills/production-readiness-audit/SKILL.md)), etc.
|
||||
|
||||
|
|
@ -202,6 +204,7 @@ Use when you need expert depth in specific domains:
|
|||
| `ring:prompt-quality-reviewer` | AI prompt quality review | Prompt engineering, clarity, effectiveness |
|
||||
| `ring:qa-analyst` | Quality assurance | Test strategy, automation, coverage |
|
||||
| `ring:sre` | Site reliability & ops | Monitoring, alerting, incident response, SLOs |
|
||||
| `ring:ui-engineer` | UI component specialist | Design systems, accessibility, React |
|
||||
|
||||
**Standards Compliance Output:** All ring-dev-team agents include a `## Standards Compliance` output section with conditional requirement:
|
||||
|
||||
|
|
@ -239,38 +242,40 @@ For best practices research and repository analysis:
|
|||
| `ring:best-practices-researcher` | Best practices research | Industry patterns, framework standards |
|
||||
| `ring:framework-docs-researcher` | Framework documentation research | Official docs, API references, examples |
|
||||
| `ring:repo-research-analyst` | Repository analysis | Codebase patterns, structure analysis |
|
||||
| `ring:product-designer` | Product design and UX research | UX specifications, user validation, design review |
|
||||
|
||||
### Technical Writing (ring-tw-team)
|
||||
|
||||
For documentation creation and review:
|
||||
|
||||
| Agent | Purpose | Use For |
|
||||
| ------------------- | ---------------------------- | ------------------------------------ |
|
||||
| `functional-writer` | Functional documentation | Guides, tutorials, conceptual docs |
|
||||
| `api-writer` | API reference documentation | Endpoints, schemas, examples |
|
||||
| `docs-reviewer` | Documentation quality review | Voice, tone, structure, completeness |
|
||||
| Agent | Purpose | Use For |
|
||||
| ------------------------ | ---------------------------- | ------------------------------------ |
|
||||
| `ring:functional-writer` | Functional documentation | Guides, tutorials, conceptual docs |
|
||||
| `ring:api-writer` | API reference documentation | Endpoints, schemas, examples |
|
||||
| `ring:docs-reviewer` | Documentation quality review | Voice, tone, structure, completeness |
|
||||
|
||||
### Regulatory & FinOps (ring-finops-team)
|
||||
|
||||
For Brazilian financial compliance workflows and cost analysis:
|
||||
|
||||
| Agent | Purpose | Use For |
|
||||
| ------------------------------- | ------------------------------ | ----------------------------------------------- |
|
||||
| `finops-analyzer` | Regulatory compliance analysis | Field mapping, BACEN/RFB validation (Gates 1-2) |
|
||||
| `finops-automation` | Template generation | Create .tpl files (Gate 3) |
|
||||
| `infrastructure-cost-estimator` | Cost estimation and analysis | Infrastructure cost planning and optimization |
|
||||
| Agent | Purpose | Use For |
|
||||
| ------------------------------------ | ------------------------------ | ----------------------------------------------- |
|
||||
| `ring:finops-analyzer` | Regulatory compliance analysis | Field mapping, BACEN/RFB validation (Gates 1-2) |
|
||||
| `ring:finops-automation` | Template generation | Create .tpl files (Gate 3) |
|
||||
| `ring:infrastructure-cost-estimator` | Cost estimation and analysis | Infrastructure cost planning and optimization |
|
||||
|
||||
### PMO Specialists (ring-pmo-team)
|
||||
|
||||
For portfolio-level project management and oversight:
|
||||
|
||||
| Agent | Purpose | Use For |
|
||||
| ----------------------- | ------------------------- | ----------------------------------------------- |
|
||||
| `portfolio-manager` | Portfolio-level planning | Multi-project coordination, strategic alignment |
|
||||
| `resource-planner` | Capacity planning | Resource allocation, conflict resolution |
|
||||
| `risk-analyst` | Portfolio risk management | Risk identification, mitigation planning |
|
||||
| `governance-specialist` | Process compliance | Gate reviews, audit readiness |
|
||||
| `executive-reporter` | Executive communications | Dashboards, board packages, status summaries |
|
||||
| Agent | Purpose | Use For |
|
||||
| ---------------------------- | ------------------------- | ----------------------------------------------- |
|
||||
| `ring:portfolio-manager` | Portfolio-level planning | Multi-project coordination, strategic alignment |
|
||||
| `ring:resource-planner` | Capacity planning | Resource allocation, conflict resolution |
|
||||
| `ring:risk-analyst` | Portfolio risk management | Risk identification, mitigation planning |
|
||||
| `ring:governance-specialist` | Process compliance | Gate reviews, audit readiness |
|
||||
| `ring:executive-reporter` | Executive communications | Dashboards, board packages, status summaries |
|
||||
| `ring:delivery-reporter` | Delivery reporting | Delivery status reports and tracking |
|
||||
|
||||
---
|
||||
|
||||
|
|
@ -282,7 +287,7 @@ For portfolio-level project management and oversight:
|
|||
2. **Plan** → `/ring:pre-dev-feature feature-name` (or `ring:pre-dev-full` if complex)
|
||||
3. **Isolate** → `/ring:worktree feature-branch`
|
||||
4. **Implement** → Use `ring:test-driven-development` skill
|
||||
5. **Review** → `/ring:codereview src/` (dispatches 3 reviewers)
|
||||
5. **Review** → `/ring:codereview src/` (dispatches 5 reviewers)
|
||||
6. **Commit** → `/ring:commit "message"`
|
||||
|
||||
### Bug Investigation
|
||||
|
|
@ -339,7 +344,7 @@ These enforce quality standards:
|
|||
|
||||
| Need | Agent to Use |
|
||||
| --------------------------------- | ------------------------------------------- |
|
||||
| General code quality review | 3 parallel reviewers via `/ring:codereview` |
|
||||
| General code quality review | 5 parallel reviewers via `/ring:codereview` |
|
||||
| Implementation planning | `ring:write-plan` |
|
||||
| Deep codebase analysis | `ring:codebase-explorer` |
|
||||
| Go backend expertise | `ring:backend-engineer-golang` |
|
||||
|
|
@ -348,23 +353,26 @@ These enforce quality standards:
|
|||
| React/Next.js frontend & BFF | `ring:frontend-bff-engineer-typescript` |
|
||||
| General frontend development | `ring:frontend-engineer` |
|
||||
| Visual design & aesthetics | `ring:frontend-designer` |
|
||||
| UI component development | `ring:ui-engineer` |
|
||||
| AI prompt quality review | `ring:prompt-quality-reviewer` |
|
||||
| Quality assurance & testing | `ring:qa-analyst` |
|
||||
| Site reliability & operations | `ring:sre` |
|
||||
| Best practices research | `ring:best-practices-researcher` |
|
||||
| Framework documentation research | `ring:framework-docs-researcher` |
|
||||
| Repository analysis | `ring:repo-research-analyst` |
|
||||
| Functional documentation (guides) | `functional-writer` |
|
||||
| API reference documentation | `api-writer` |
|
||||
| Documentation quality review | `docs-reviewer` |
|
||||
| Regulatory compliance analysis | `finops-analyzer` |
|
||||
| Regulatory template generation | `finops-automation` |
|
||||
| Infrastructure cost estimation | `infrastructure-cost-estimator` |
|
||||
| Portfolio-level planning | `portfolio-manager` |
|
||||
| Resource capacity planning | `resource-planner` |
|
||||
| Portfolio risk assessment | `risk-analyst` |
|
||||
| Governance and compliance | `governance-specialist` |
|
||||
| Executive reporting | `executive-reporter` |
|
||||
| Product design & UX research | `ring:product-designer` |
|
||||
| Functional documentation (guides) | `ring:functional-writer` |
|
||||
| API reference documentation | `ring:api-writer` |
|
||||
| Documentation quality review | `ring:docs-reviewer` |
|
||||
| Regulatory compliance analysis | `ring:finops-analyzer` |
|
||||
| Regulatory template generation | `ring:finops-automation` |
|
||||
| Infrastructure cost estimation | `ring:infrastructure-cost-estimator` |
|
||||
| Portfolio-level planning | `ring:portfolio-manager` |
|
||||
| Resource capacity planning | `ring:resource-planner` |
|
||||
| Portfolio risk assessment | `ring:risk-analyst` |
|
||||
| Governance and compliance | `ring:governance-specialist` |
|
||||
| Executive reporting | `ring:executive-reporter` |
|
||||
| Delivery status reporting | `ring:delivery-reporter` |
|
||||
|
||||
---
|
||||
|
||||
|
|
@ -373,7 +381,7 @@ These enforce quality standards:
|
|||
### Session Startup
|
||||
|
||||
1. SessionStart hook runs automatically
|
||||
2. All 66 skills are auto-discovered and available
|
||||
2. All 74 skills are auto-discovered and available
|
||||
3. `ring:using-ring` workflow is activated (skill checking is now mandatory)
|
||||
|
||||
### Agent Dispatching
|
||||
|
|
@ -392,11 +400,13 @@ Returns structured output per agent's output_schema
|
|||
### Parallel Review Pattern
|
||||
|
||||
```
|
||||
Single message with 3 Task calls (not sequential):
|
||||
Single message with 5 Task calls (not sequential):
|
||||
|
||||
Task #1: ring:code-reviewer
|
||||
Task #2: ring:business-logic-reviewer
|
||||
Task #3: ring:security-reviewer
|
||||
Task #4: ring:test-reviewer
|
||||
Task #5: ring:nil-safety-reviewer
|
||||
↓
|
||||
All run in parallel (saves ~15 minutes vs sequential)
|
||||
↓
|
||||
|
|
|
|||
92
README.md
92
README.md
|
|
@ -17,8 +17,8 @@ Without Ring, AI assistants often:
|
|||
Ring solves this by:
|
||||
|
||||
- **Enforcing proven workflows** - Test-driven development, systematic debugging, proper planning
|
||||
- **Providing 66 specialized skills** (25 core + 9 dev-team + 10 product planning + 7 FinOps regulatory + 7 technical writing + 8 PMO)
|
||||
- **32 specialized agents** - 7 review/planning + 10 developer + 4 product research + 3 FinOps regulatory + 3 technical writing + 5 PMO
|
||||
- **Providing 74 specialized skills** (25 core + 13 dev-team + 13 product planning + 7 FinOps regulatory + 7 technical writing + 9 PMO)
|
||||
- **33 specialized agents** - 7 review/planning + 10 developer + 4 product research + 3 FinOps regulatory + 3 technical writing + 6 PMO
|
||||
- **Automating skill discovery** - Skills load automatically at session start
|
||||
- **Preventing common failures** - Built-in anti-patterns and mandatory checklists
|
||||
|
||||
|
|
@ -87,6 +87,7 @@ Ring solves this by:
|
|||
- `ring:risk-analyst` - Portfolio risk identification and mitigation planning
|
||||
- `ring:governance-specialist` - Gate reviews and process compliance
|
||||
- `ring:executive-reporter` - Executive dashboards and stakeholder communications
|
||||
- `ring:delivery-reporter` - Delivery status reporting and tracking
|
||||
|
||||
_Plugin versions are managed in `.claude-plugin/marketplace.json`_
|
||||
|
||||
|
|
@ -236,7 +237,7 @@ When you start a new Claude Code session with Ring installed, you'll see:
|
|||
- ring:test-driven-development (RED-GREEN-REFACTOR cycle)
|
||||
- ring:systematic-debugging (4-phase root cause analysis)
|
||||
- ring:verification-before-completion (Evidence before claims)
|
||||
... and 47 more skills
|
||||
... and 70 more skills
|
||||
```
|
||||
|
||||
## 🎯 Core Skills
|
||||
|
|
@ -275,7 +276,7 @@ Run command → Paste output → Then claim
|
|||
No "should work" → Only "does work" with proof
|
||||
```
|
||||
|
||||
## 📚 All 66 Skills (Across 6 Plugins)
|
||||
## 📚 All 74 Skills (Across 6 Plugins)
|
||||
|
||||
### Core Skills (ring-default plugin - 25 skills)
|
||||
|
||||
|
|
@ -295,7 +296,7 @@ No "should work" → Only "does work" with proof
|
|||
- `ring:interviewing-user` - Proactive requirements gathering through structured interview
|
||||
- `ring:writing-plans` - Zero-context implementation plans
|
||||
- `ring:executing-plans` - Batch execution with checkpoints
|
||||
- `ring:requesting-code-review` - **Parallel 3-reviewer dispatch** with severity-based handling
|
||||
- `ring:requesting-code-review` - **Parallel 5-reviewer dispatch** with severity-based handling
|
||||
- `ring:receiving-code-review` - Responding to feedback
|
||||
- `ring:dispatching-parallel-agents` - Concurrent workflows
|
||||
- `ring:subagent-driven-development` - Fast iteration with **parallel reviews**
|
||||
|
|
@ -313,31 +314,41 @@ No "should work" → Only "does work" with proof
|
|||
**Session & Learning (2):**
|
||||
|
||||
- `ring:exploring-codebase` - Two-phase codebase exploration
|
||||
- `ring:doubt-triggered-questions` - Decision hierarchy for asking vs proceeding
|
||||
- `ring:release-guide-info` - Generate Ops Update Guide from git diff analysis
|
||||
|
||||
**Audit & Readiness (1):**
|
||||
|
||||
- `ring:production-readiness-audit` - 27-dimension production readiness audit; runs 10 explorers per batch, appends incrementally to a single report; output: scored report (0–270) with severity ratings. See [default/skills/production-readiness-audit/SKILL.md](default/skills/production-readiness-audit/SKILL.md) for invocation and implementation details.
|
||||
|
||||
### Developer Skills (ring-dev-team plugin - 9 skills)
|
||||
### Developer Skills (ring-dev-team plugin - 13 skills)
|
||||
|
||||
**Code Development:**
|
||||
|
||||
- `ring:using-dev-team` - Introduction to developer specialist agents
|
||||
- `ring:dev-refactor` - Codebase analysis against standards
|
||||
- `ring:dev-cycle` - 6-gate development workflow orchestrator
|
||||
- `ring:dev-cycle` - 10-gate development workflow orchestrator
|
||||
|
||||
**6-Gate Workflow Skills:**
|
||||
**10-Gate Workflow Skills:**
|
||||
|
||||
- `ring:dev-implementation` - Gate 0: TDD implementation
|
||||
- `ring:dev-devops` - Gate 1: DevOps setup (Docker, compose)
|
||||
- `ring:dev-sre` - Gate 2: Observability setup
|
||||
- `ring:dev-testing` - Gate 3: Test coverage
|
||||
- `ring:requesting-code-review` - Gate 4: Parallel code review (3 reviewers)
|
||||
- `ring:dev-validation` - Gate 5: User approval
|
||||
- `ring:dev-sre` - Gate 2: Observability validation
|
||||
|
||||
**Advanced Testing Gates (5):**
|
||||
|
||||
- `ring:dev-unit-testing` - Gate 3: Unit test coverage (85%+ threshold)
|
||||
- `ring:dev-fuzz-testing` - Gate 4: Fuzz testing with seed corpus for edge case discovery
|
||||
- `ring:dev-property-testing` - Gate 5: Property-based tests for domain invariants
|
||||
- `ring:dev-integration-testing` - Gate 6: Integration tests with real containers via testcontainers
|
||||
- `ring:dev-chaos-testing` - Gate 7: Chaos tests using Toxiproxy for graceful degradation
|
||||
|
||||
**Review & Validation:**
|
||||
|
||||
- `ring:requesting-code-review` - Gate 8: Parallel code review (5 reviewers)
|
||||
- `ring:dev-validation` - Gate 9: User approval
|
||||
- `ring:dev-feedback-loop` - Assertiveness scoring and metrics
|
||||
|
||||
### Product Planning Skills (ring-pm-team plugin - 10 skills)
|
||||
### Product Planning Skills (ring-pm-team plugin - 13 skills)
|
||||
|
||||
**Pre-Development Workflow (includes ring:using-pm-team + 9 gates):**
|
||||
|
||||
|
|
@ -353,6 +364,12 @@ No "should work" → Only "does work" with proof
|
|||
7. `ring:pre-dev-task-breakdown` - Work increments
|
||||
8. `ring:pre-dev-subtask-creation` - Atomic units
|
||||
|
||||
**Additional Planning Skills:**
|
||||
|
||||
- `ring:pre-dev-design-validation` - Gate 1.5/2.5: Design validation for UI features
|
||||
- `ring:pre-dev-delivery-planning` - Gate 4 (Small) / Gate 9 (Large): Delivery roadmap and timeline
|
||||
- `ring:delivery-status-tracking` - Delivery progress tracking against roadmap
|
||||
|
||||
### Technical Writing Skills (ring-tw-team plugin - 7 skills)
|
||||
|
||||
**Documentation Creation:**
|
||||
|
|
@ -380,7 +397,7 @@ No "should work" → Only "does work" with proof
|
|||
|
||||
- `ring:infrastructure-cost-estimation` - Infrastructure cost estimation and analysis
|
||||
|
||||
### PMO Skills (ring-pmo-team plugin - 8 skills)
|
||||
### PMO Skills (ring-pmo-team plugin - 9 skills)
|
||||
|
||||
**Portfolio Management:**
|
||||
|
||||
|
|
@ -392,14 +409,15 @@ No "should work" → Only "does work" with proof
|
|||
- `ring:project-health-check` - Individual project health assessment
|
||||
- `ring:pmo-retrospective` - Portfolio lessons learned and process improvements
|
||||
- `ring:executive-reporting` - Executive dashboards and board packages
|
||||
- `ring:delivery-reporting` - Delivery status reports and executive communications
|
||||
|
||||
## 🎮 Interactive Commands
|
||||
|
||||
Ring provides 25 slash commands across 6 plugins for common workflows.
|
||||
Ring provides 27 slash commands across 6 plugins for common workflows.
|
||||
|
||||
### Core Workflows (ring-default)
|
||||
|
||||
- `/ring:codereview [files-or-paths]` - Dispatch 3 parallel code reviewers for comprehensive review
|
||||
- `/ring:codereview [files-or-paths]` - Dispatch 5 parallel code reviewers for comprehensive review
|
||||
- `/ring:commit [message]` - Create git commit with AI identification via Git trailers
|
||||
- `/ring:worktree [branch-name]` - Create isolated git workspace for parallel development
|
||||
- `/ring:brainstorm [topic]` - Interactive design refinement using Socratic method
|
||||
|
|
@ -414,12 +432,13 @@ Ring provides 25 slash commands across 6 plugins for common workflows.
|
|||
|
||||
### Product Planning (ring-pm-team)
|
||||
|
||||
- `/ring:pre-dev-feature [feature-name]` - Lightweight 4-gate pre-dev workflow for small features (<2 days)
|
||||
- `/ring:pre-dev-full [feature-name]` - Complete 9-gate pre-dev workflow for large features (>=2 days)
|
||||
- `/ring:pre-dev-feature [feature-name]` - 5-gate pre-dev workflow for small features (<2 days)
|
||||
- `/ring:pre-dev-full [feature-name]` - 10-gate pre-dev workflow for large features (>=2 days)
|
||||
- `/ring:delivery-status [scope]` - Track delivery progress against roadmap
|
||||
|
||||
### Development Cycle (ring-dev-team)
|
||||
|
||||
- `/ring:dev-cycle [task]` - Start 6-gate development workflow (implementation→devops→SRE→testing→review→validation)
|
||||
- `/ring:dev-cycle [task]` - Start 10-gate development workflow (implementation→devops→SRE→unit-testing→fuzz-testing→property-testing→integration-testing→chaos-testing→review→validation)
|
||||
- `/ring:dev-refactor [path]` - Analyze codebase against standards
|
||||
- `/ring:dev-status` - Show current gate progress
|
||||
- `/ring:dev-report` - Generate development cycle report
|
||||
|
|
@ -436,6 +455,7 @@ Ring provides 25 slash commands across 6 plugins for common workflows.
|
|||
- `/ring:portfolio-review [scope]` - Conduct comprehensive portfolio review across projects
|
||||
- `/ring:dependency-analysis [scope]` - Analyze cross-project dependencies
|
||||
- `/ring:executive-summary [scope]` - Generate executive summary for leadership
|
||||
- `/ring:delivery-report [scope]` - Generate delivery status report
|
||||
|
||||
## 💡 Usage Examples
|
||||
|
||||
|
|
@ -473,16 +493,19 @@ Claude: I'll use the pre-dev workflow to plan this systematically...
|
|||
... [Through all 8 gates]
|
||||
```
|
||||
|
||||
### Code Review (Parallel, 3x Faster!)
|
||||
### Code Review (Parallel, 5 Reviewers!)
|
||||
|
||||
```
|
||||
User: "Review my authentication implementation"
|
||||
Claude: Dispatching all 3 reviewers in parallel...
|
||||
[Launches ring:code-reviewer, ring:business-logic-reviewer, ring:security-reviewer simultaneously]
|
||||
Claude: Dispatching all 5 reviewers in parallel...
|
||||
[Launches ring:code-reviewer, ring:business-logic-reviewer, ring:security-reviewer,
|
||||
ring:test-reviewer, ring:nil-safety-reviewer simultaneously]
|
||||
|
||||
Code reviewer: PASS. Clean architecture, good tests.
|
||||
Business reviewer: FAIL. Missing password reset flow (HIGH severity).
|
||||
Security reviewer: FAIL. JWT secret hardcoded (CRITICAL severity).
|
||||
Test reviewer: PASS. Good coverage, assertions well-structured.
|
||||
Nil-safety reviewer: PASS. No unguarded nil dereferences found.
|
||||
|
||||
Aggregating issues by severity:
|
||||
- CRITICAL: JWT secret hardcoded in auth.ts:42
|
||||
|
|
@ -491,13 +514,13 @@ Claude: Dispatching all 3 reviewers in parallel...
|
|||
Dispatching fix subagent to address Critical/High issues...
|
||||
[Fixes applied]
|
||||
|
||||
Re-running all 3 reviewers in parallel...
|
||||
Re-running all 5 reviewers in parallel...
|
||||
All reviewers: PASS. Ready for production.
|
||||
```
|
||||
|
||||
**Key benefits:**
|
||||
|
||||
- **3x faster** - All reviewers run simultaneously (not sequential)
|
||||
- **All reviewers run simultaneously** (not sequential)
|
||||
- **Comprehensive** - Get all feedback at once, easier to prioritize
|
||||
- **Tech debt tracking** - Low/Cosmetic issues tracked with TODO/FIXME comments in code
|
||||
- **Model-specific** - All reviewers run on Opus for deep analysis
|
||||
|
|
@ -529,8 +552,8 @@ ring/ # Monorepo root
|
|||
│ │ ├── ring:write-plan.md # Implementation planning
|
||||
│ │ └── ring:codebase-explorer.md # Deep architecture analysis (Opus)
|
||||
│ └── docs/ # Documentation
|
||||
├── dev-team/ # Developer Agents plugin (ring-dev-team)
|
||||
│ └── agents/ # 9 specialized developer agents
|
||||
├── dev-team/ # Developer Agents plugin (ring-dev-team) - 13 skills, 10 agents, 5 commands
|
||||
│ └── agents/ # 10 specialized developer agents
|
||||
│ ├── ring:backend-engineer-golang.md # Go backend specialist
|
||||
│ ├── ring:backend-engineer-typescript.md # TypeScript/Node.js backend specialist
|
||||
│ ├── ring:devops-engineer.md # DevOps infrastructure
|
||||
|
|
@ -539,9 +562,10 @@ ring/ # Monorepo root
|
|||
│ ├── ring:frontend-engineer.md # Senior Frontend Engineer (React/Next.js)
|
||||
│ ├── prompt-quality-reviewer.md # Agent Quality Analyst
|
||||
│ ├── qa-analyst.md # Quality assurance
|
||||
│ └── sre.md # Site reliability engineer
|
||||
│ ├── sre.md # Site reliability engineer
|
||||
│ └── ui-engineer.md # UI component specialist
|
||||
├── pm-team/ # Product Planning plugin (ring-pm-team)
|
||||
│ └── skills/ # 10 pre-dev workflow skills
|
||||
│ └── skills/ # 13 pre-dev workflow skills
|
||||
│ └── pre-dev-*/ # PRD, TRD, API, Data, Tasks
|
||||
├── finops-team/ # FinOps Regulatory plugin (ring-finops-team)
|
||||
│ ├── skills/ # 7 regulatory skills
|
||||
|
|
@ -549,14 +573,15 @@ ring/ # Monorepo root
|
|||
│ ├── docs/regulatory/ # Regulatory templates and dictionaries
|
||||
│ └── hooks/ # SessionStart hook
|
||||
├── pmo-team/ # PMO Specialists plugin (ring-pmo-team)
|
||||
│ ├── agents/ # 5 PMO specialist agents
|
||||
│ ├── agents/ # 6 PMO specialist agents
|
||||
│ │ ├── portfolio-manager.md
|
||||
│ │ ├── resource-planner.md
|
||||
│ │ ├── risk-analyst.md
|
||||
│ │ ├── governance-specialist.md
|
||||
│ │ └── executive-reporter.md
|
||||
│ ├── skills/ # 8 PMO skills
|
||||
│ ├── commands/ # 3 PMO commands
|
||||
│ │ ├── executive-reporter.md
|
||||
│ │ └── delivery-reporter.md
|
||||
│ ├── skills/ # 9 PMO skills
|
||||
│ ├── commands/ # 4 PMO commands
|
||||
│ └── hooks/ # SessionStart hook
|
||||
└── tw-team/ # Technical Writing plugin (ring-tw-team)
|
||||
├── skills/ # 7 documentation skills
|
||||
|
|
@ -667,6 +692,7 @@ ring/ # Monorepo root
|
|||
- **Skills Quick Reference** - Auto-generated at session start from skill frontmatter
|
||||
- [CLAUDE.md](CLAUDE.md) - Repository guide for Claude Code
|
||||
- [MANUAL.md](MANUAL.md) - Quick reference for all commands, agents, and workflows
|
||||
- [ARCHITECTURE.md](ARCHITECTURE.md) - Architecture diagrams and component relationships
|
||||
- [Design Documents](docs/plans/) - Implementation plans and architecture decisions
|
||||
- **Platform Guides:**
|
||||
- [Claude Code](docs/platforms/claude-code.md) - Native format setup
|
||||
|
|
|
|||
|
|
@ -402,16 +402,16 @@ Add this step after every 3-5 tasks (or after significant features):
|
|||
```markdown
|
||||
### Task N: Run Code Review
|
||||
|
||||
1. **Dispatch all 3 reviewers in parallel:**
|
||||
1. **Dispatch all 5 reviewers in parallel:**
|
||||
- REQUIRED SUB-SKILL: Use ring:requesting-code-review
|
||||
- All reviewers run simultaneously (ring:code-reviewer, ring:business-logic-reviewer, ring:security-reviewer)
|
||||
- All reviewers run simultaneously (ring:code-reviewer, ring:business-logic-reviewer, ring:security-reviewer, ring:test-reviewer, ring:nil-safety-reviewer)
|
||||
- Wait for all to complete
|
||||
|
||||
2. **Handle findings by severity (MANDATORY):**
|
||||
|
||||
**Critical/High/Medium Issues:**
|
||||
- Fix immediately (do NOT add TODO comments for these severities)
|
||||
- Re-run all 3 reviewers in parallel after fixes
|
||||
- Re-run all 5 reviewers in parallel after fixes
|
||||
- Repeat until zero Critical/High/Medium issues remain
|
||||
|
||||
**Low Issues:**
|
||||
|
|
|
|||
|
|
@ -66,10 +66,12 @@ You will be asked to choose between:
|
|||
- Reliability: `ring:sre`
|
||||
|
||||
### Step 4: Run Code Review
|
||||
After each batch, all 3 reviewers run in parallel:
|
||||
After each batch, all 5 reviewers run in parallel:
|
||||
- `ring:code-reviewer` - Architecture and patterns
|
||||
- `ring:business-logic-reviewer` - Requirements and edge cases
|
||||
- `ring:security-reviewer` - OWASP and auth validation
|
||||
- `ring:test-reviewer` - Test coverage and quality
|
||||
- `ring:nil-safety-reviewer` - Null/nil safety patterns
|
||||
|
||||
**Issue handling by severity:**
|
||||
| Severity | Action |
|
||||
|
|
|
|||
|
|
@ -147,10 +147,10 @@ User saying "don't wait", "don't ask questions", or "just execute" does NOT skip
|
|||
For each task: Check context switch (Step 2.5) → Mark in_progress → Dispatch to agent with working_directory → Follow plan steps exactly → Run verifications → Mark completed
|
||||
|
||||
### Step 4: Run Code Review
|
||||
**After each batch, REQUIRED:** Use ring:requesting-code-review (all 3 reviewers in parallel)
|
||||
**After each batch, REQUIRED:** Use ring:requesting-code-review (all 5 reviewers in parallel)
|
||||
|
||||
**Handle by severity:**
|
||||
- **Critical/High/Medium:** Fix immediately (no TODO) → re-run all 3 reviewers → repeat until resolved
|
||||
- **Critical/High/Medium:** Fix immediately (no TODO) → re-run all 5 reviewers → repeat until resolved
|
||||
- **Low:** Add `TODO(review): [Issue] ([reviewer], [date], Low)`
|
||||
- **Cosmetic:** Add `FIXME(nitpick): [Issue] ([reviewer], [date], Cosmetic)`
|
||||
|
||||
|
|
@ -173,7 +173,7 @@ Use finishing-a-development-branch to verify tests, present options, execute cho
|
|||
|
||||
- **MANDATORY:** `AskUserQuestion` for execution mode - NO exceptions
|
||||
- Use `*` agents over `general-purpose` when available
|
||||
- Run code review after each batch (all 3 parallel)
|
||||
- Run code review after each batch (all 5 parallel)
|
||||
- Fix Critical/High/Medium immediately (no TODO)
|
||||
- Low → TODO, Cosmetic → FIXME
|
||||
- Stop when blocked, don't guess
|
||||
|
|
|
|||
|
|
@ -103,23 +103,25 @@ Read plan file, create TodoWrite with all tasks.
|
|||
|
||||
### 3. Review Subagent's Work (Parallel Execution)
|
||||
|
||||
**CRITICAL: Single message with 3 Task tool calls** - all reviewers execute simultaneously.
|
||||
**CRITICAL: Single message with 5 Task tool calls** - all reviewers execute simultaneously.
|
||||
|
||||
| Reviewer | Context |
|
||||
|----------|---------|
|
||||
| `ring:code-reviewer` | WHAT_WAS_IMPLEMENTED, PLAN, BASE_SHA, HEAD_SHA |
|
||||
| `ring:business-logic-reviewer` | Same context |
|
||||
| `ring:security-reviewer` | Same context |
|
||||
| `ring:test-reviewer` | Same context |
|
||||
| `ring:nil-safety-reviewer` | Same context |
|
||||
|
||||
**Each returns:** Strengths, Issues (Critical/High/Medium/Low/Cosmetic), Assessment (PASS/FAIL)
|
||||
|
||||
### 4. Aggregate and Handle Review Feedback
|
||||
|
||||
**Aggregate** all issues by severity across all 3 reviewers.
|
||||
**Aggregate** all issues by severity across all 5 reviewers.
|
||||
|
||||
| Severity | Action |
|
||||
|----------|--------|
|
||||
| **Critical/High/Medium** | Dispatch fix subagent → Re-run all 3 reviewers → Repeat until clear |
|
||||
| **Critical/High/Medium** | Dispatch fix subagent → Re-run all 5 reviewers → Repeat until clear |
|
||||
| **Low** | Add `# TODO(review): [issue] - reviewer, date, Severity: Low` |
|
||||
| **Cosmetic** | Add `# FIXME(nitpick): [issue] - reviewer, date, Severity: Cosmetic` |
|
||||
|
||||
|
|
@ -135,7 +137,7 @@ After all Critical/High/Medium issues resolved for current task:
|
|||
|
||||
### 6. Final Review (After All Tasks)
|
||||
|
||||
**Same pattern as Step 3** but reviewing entire implementation (all tasks, full BASE_SHA→HEAD_SHA range). Aggregate, fix, re-run until all 3 PASS.
|
||||
**Same pattern as Step 3** but reviewing entire implementation (all tasks, full BASE_SHA→HEAD_SHA range). Aggregate, fix, re-run until all 5 PASS.
|
||||
|
||||
### 7. Complete Development
|
||||
|
||||
|
|
@ -146,13 +148,13 @@ After final review passes:
|
|||
|
||||
## Example Workflow
|
||||
|
||||
**Task 1:** Implement → All 3 reviewers PASS → Mark complete.
|
||||
**Task 1:** Implement → All 5 reviewers PASS → Mark complete.
|
||||
|
||||
**Task 2:** Implement → Review finds: Critical (hardcoded secret), High (missing password reset, missing input validation), Low (extract token logic) → Dispatch fix subagent → Re-run reviewers → All PASS → Add TODO for Low → Mark complete.
|
||||
|
||||
**Final:** All 3 reviewers PASS entire implementation → Done.
|
||||
**Final:** All 5 reviewers PASS entire implementation → Done.
|
||||
|
||||
**Why parallel:** 3x faster, all feedback at once, TODO/FIXME tracks tech debt.
|
||||
**Why parallel:** 5x faster, all feedback at once, TODO/FIXME tracks tech debt.
|
||||
|
||||
## Advantages
|
||||
|
||||
|
|
@ -168,17 +170,17 @@ After final review passes:
|
|||
**Never:**
|
||||
- Skip code review between tasks
|
||||
- Proceed with unfixed Critical/High/Medium issues
|
||||
- Dispatch reviewers sequentially (use parallel - 3x faster!)
|
||||
- Dispatch reviewers sequentially (use parallel - 5x faster!)
|
||||
- Dispatch multiple implementation subagents in parallel (conflicts)
|
||||
- Implement without reading plan task
|
||||
- Forget to add TODO/FIXME comments for Low/Cosmetic issues
|
||||
|
||||
**Always:**
|
||||
- Launch all 3 reviewers in single message with 3 Task calls
|
||||
- Launch all 5 reviewers in single message with 5 Task calls
|
||||
- Wait for all reviewers before aggregating findings
|
||||
- Fix Critical/High/Medium immediately
|
||||
- Add TODO for Low, FIXME for Cosmetic
|
||||
- Re-run all 3 reviewers after fixes
|
||||
- Re-run all 5 reviewers after fixes
|
||||
|
||||
**If subagent fails task:**
|
||||
- Dispatch fix subagent with specific instructions
|
||||
|
|
|
|||
|
|
@ -211,7 +211,7 @@ For each edge case failure, add explicit handling to agent definition:
|
|||
- Context comments: Consider but don't use to dismiss issues
|
||||
## Testing Parallel Agent Workflows
|
||||
|
||||
When agents run in parallel (like 3 reviewers), test combined workflow:
|
||||
When agents run in parallel (like 5 reviewers), test combined workflow:
|
||||
- **Parallel Consistency**: Same input to all reviewers → check findings overlap appropriately, no contradictions
|
||||
- **Aggregation Testing**: Same issue found by multiple reviewers → severity should be consistent; fix misalignments
|
||||
|
||||
|
|
|
|||
|
|
@ -88,7 +88,7 @@ CANNOT override CRITICAL gates. Provides custom context to agents.
|
|||
|
||||
CRITICAL: Gates 3, 4, 5 enforce mandatory requirements:
|
||||
- MUST enforce 85% coverage (Gate 3 Testing)
|
||||
- MUST dispatch all 3 reviewers (Gate 4 Review)
|
||||
- MUST dispatch all 5 reviewers (Gate 4 Review)
|
||||
- MUST require user approval (Gate 5 Validation)
|
||||
|
||||
**Conflict Detection:**
|
||||
|
|
@ -232,6 +232,6 @@ See skill `ring:dev-cycle` for full details. Key rules:
|
|||
|
||||
- **all 6 gates execute** - Checkpoints affect pauses, not gates
|
||||
- **Gates execute in order** - 0 → 1 → 2 → 3 → 4 → 5
|
||||
- **Gate 4 requires all 3 reviewers** - 2/3 = FAIL
|
||||
- **Gate 4 requires all 5 reviewers** - 4/5 = FAIL
|
||||
- **Coverage threshold** - 85% minimum, no exceptions
|
||||
- **State persisted** - Can resume with `--resume` after any interruption
|
||||
|
|
|
|||
|
|
@ -22,7 +22,7 @@ CRITICAL: The following gates enforce mandatory requirements that `--prompt` CAN
|
|||
| Gate | What CANNOT Be Overridden |
|
||||
|------|---------------------------|
|
||||
| Gate 3 (Testing) | MUST enforce 85% coverage threshold, TDD RED phase |
|
||||
| Gate 4 (Review) | MUST dispatch all 3 reviewers |
|
||||
| Gate 4 (Review) | MUST dispatch all 5 reviewers |
|
||||
| Gate 5 (Validation) | MUST require user approval |
|
||||
|
||||
## Conflict Detection
|
||||
|
|
|
|||
|
|
@ -66,10 +66,10 @@ These rationalizations are always wrong, regardless of context:
|
|||
|-----------------|----------------|-----------------|
|
||||
| "Trivial change, skip review" | Security vulnerabilities fit in 1 line. all changes require review. | **Review all changes** |
|
||||
| "Only N lines changed" | Line count is irrelevant. SQL injection is 1 line. | **Review all changes** |
|
||||
| "One reviewer is enough" | 3 reviewers catch different issues. All required. | **Dispatch all 3 reviewers** |
|
||||
| "Run reviewers sequentially" | Sequential = 3x slower. Parallel is REQUIRED. | **Single message, 3 Task calls** |
|
||||
| "One reviewer is enough" | 5 reviewers catch different issues. All required. | **Dispatch all 5 reviewers** |
|
||||
| "Run reviewers sequentially" | Sequential = 5x slower. Parallel is REQUIRED. | **Single message, 5 Task calls** |
|
||||
| "Only MEDIUM issues, can proceed" | MEDIUM = Fix NOW. No deferral, no FIXME. | **Fix MEDIUM issues** |
|
||||
| "Small fix, no re-review needed" | Small fixes can have big impacts. | **Re-run all 3 reviewers after any fix** |
|
||||
| "Small fix, no re-review needed" | Small fixes can have big impacts. | **Re-run all 5 reviewers after any fix** |
|
||||
|
||||
---
|
||||
|
||||
|
|
|
|||
|
|
@ -260,7 +260,7 @@ All workflows converge to the 10-gate development cycle:
|
|||
| **1: DevOps** | Dockerfile, docker-compose, .env | `ring:devops-engineer` |
|
||||
| **2: SRE** | Health checks, logging, tracing | `ring:sre` |
|
||||
| **3: Testing** | Unit tests, coverage ≥85% | `ring:qa-analyst` |
|
||||
| **4: Review** | 3 reviewers IN PARALLEL | `ring:code-reviewer`, `ring:business-logic-reviewer`, `ring:security-reviewer` |
|
||||
| **4: Review** | 5 reviewers IN PARALLEL | `ring:code-reviewer`, `ring:business-logic-reviewer`, `ring:security-reviewer`, `ring:test-reviewer`, `ring:nil-safety-reviewer` |
|
||||
| **5: Validation** | User approval: APPROVED/REJECTED | User decision |
|
||||
|
||||
**Gate 0 Agent Selection for Frontend:**
|
||||
|
|
|
|||
|
|
@ -81,7 +81,7 @@ These provide context but dilute emphasis when capitalized:
|
|||
Examples:
|
||||
- MUST dispatch agent before proceeding to next gate
|
||||
- STOP and report if PROJECT_RULES.md is missing
|
||||
- HARD GATE: All 3 reviewers must pass before Gate 5
|
||||
- HARD GATE: All 5 reviewers must pass before Gate 5
|
||||
- FORBIDDEN: Reading source code directly as orchestrator
|
||||
- REQUIRED: WebFetch Ring standards before implementation
|
||||
- MANDATORY: Save state after every gate transition
|
||||
|
|
|
|||
|
|
@ -223,12 +223,14 @@ The **ring:dev-cycle** skill orchestrates task execution through **10 gates**: i
|
|||
|
||||
## Parallel Code Review
|
||||
|
||||
### Instead of sequential (60 min)
|
||||
### Instead of sequential (100 min)
|
||||
|
||||
```python
|
||||
review1 = Task("ring:code-reviewer") # 20 min
|
||||
review2 = Task("ring:business-logic-reviewer") # 20 min
|
||||
review3 = Task("ring:security-reviewer") # 20 min
|
||||
review4 = Task("ring:test-reviewer") # 20 min
|
||||
review5 = Task("ring:nil-safety-reviewer") # 20 min
|
||||
```
|
||||
|
||||
### Run parallel (20 min total)
|
||||
|
|
|
|||
Loading…
Reference in a new issue