I noticed a spelling issue and a grammar issue and fixed similar ones
elsewhere in our docs
# Checklist for submitter
If some of the following don't apply, delete the relevant line.
<!-- Note that API documentation changes are now addressed by the
product design team. -->
There's some discussion in the community of the best way to describe
this, but 0-day has associations with vulnerabilities. "Same-day
support" seems to the currently agreed upon phrase other products use.
# Checklist for submitter
If some of the following don't apply, delete the relevant line.
<!-- Note that API documentation changes are now addressed by the
product design team. -->
- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] If paths of existing endpoints are modified without backwards
compatibility, checked the frontend/CLI for any necessary changes
- [ ] If database migrations are included, checked table schema to
confirm autoupdate
- For database migrations:
- [ ] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [ ] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [ ] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
- [ ] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [ ] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
Done as part of oncall improvements.
`vars.GO_VERSION` can only be changed by admins and it's not public
(Fleet devs don't know the current value of the variable), this approach
uses the version specified in our `go.mod` file.
In addition to a word choice issue (first line fixed), there were a
couple of passive-voice/missing punctuation issues later in the table,
so figured I might as well clean those up.
If the active voice isn't right here for how the process actually goes,
bonus points for me learning something :)
---------
Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
Give better instructions to fix and check for patch readiness that
matches what we do today.
---------
Co-authored-by: Martin Angers <martin.n.angers@gmail.com>
This outlines a new patch branching strategy to avoid the conflicts
we've been running into recently.
This will introduce more friction in the form of two PRs for released
bug fixes during patch weeks. The benefit is that we won't have to deal
with merge conflicts when we're cherry-picking commits into the patch
branch, which sometimes becomes a big distraction for the team.
We also found ourselves in a situation with 4.46.3 where we couldn't
release a fix without rewriting it because it had been built on top of
feature code that was not included in the patch. That was the motivation
to make this change.
---------
Co-authored-by: George Karr <georgekarrv@users.noreply.github.com>
Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
Changes:
- Fixed two broken links on the digital experience handbook page
- Updated link text and removed a broken link on the engineering
handbook page.
Also updated the language in the notification process slightly so that
we only notify impacted customers and the community if community
features are impacted.
Changes:
- Removed Markdown links from ritual descriptions (and added them to the
moreInfoUrl value of the rituals)
- Updated the "Generate merged schema" ritual to be weekly, and added a
`moreInfoUrl` value.
- Fixed the ritual table on the sales handbook page.
---------
Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>