Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-23 17:28:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Ship the enable inline update by default for IGListBindingSingleSectionController

Browse source 
Summary:
We had shipped the IGListBindingSingleSectionController and have been using it for direct inbox/message/reaction list for a while now and it's quite stable for the inline update infra, there is no need to keep this boolean around anymore.

Let's cleanup for good!

Differential Revision: D25871674

fbshipit-source-id: b6cc9de9308d2d3feb7e354040c1b49ce588a4ec
This commit is contained in:
Zhisheng Huang 2021-01-11 14:04:33 -08:00 committed by Facebook GitHub Bot
parent 057eaf3f14
commit f1a7f70c24
2 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Source/IGListKit/IGListBindingSingleSectionController.h
View file

@ -20,9 +20,6 @@ NS_ASSUME_NONNULL_BEGIN
NS_SWIFT_NAME(ListBindingSingleSectionController)
@interface IGListBindingSingleSectionController<__covariant ViewModel : id<IGListDiffable>, Cell : UICollectionViewCell *> : IGListSectionController
// Testing the stability of this infra. Defaults to NO.
@property (nonatomic, readwrite, assign) BOOL enabledCellConfigurationDuringUpdate;
#pragma mark - Subclass
// Required to be implemented by subclass.

6
Source/IGListKit/IGListBindingSingleSectionController.m
View file

@ -74,10 +74,8 @@
}
_item = object;
if (_enabledCellConfigurationDuringUpdate) {
if (_displayingCell) {
[self configureCell:_displayingCell withViewModel:_item];
}
if (_displayingCell) {
[self configureCell:_displayingCell withViewModel:_item];
}
}