mirror of
https://github.com/Instagram/IGListKit
synced 2026-05-24 01:38:26 +00:00
Add shouldSelectItemAtIndex to IGListSectionController (#1479)
Summary: ## Changes in this pull request Add `shouldSelectItemAtIndex:` to `IGListSectionController`. Issue fixed: https://github.com/Instagram/IGListKit/issues/1033 ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: https://github.com/Instagram/IGListKit/pull/1479 Reviewed By: DimaVartanian Differential Revision: D25562797 Pulled By: lorixx fbshipit-source-id: 39e398914e35f2cff090c9b8bd9f32a345bc5d6f
This commit is contained in:
parent
7fc7e5e6c9
commit
057eaf3f14
4 changed files with 20 additions and 0 deletions
|
|
@ -16,6 +16,8 @@ The changelog for `IGListKit`. Also see the [releases](https://github.com/instag
|
|||
|
||||
### Enhancements
|
||||
|
||||
- Added `shouldSelectItemAtIndex:` to `IGListSectionController` . [dirtmelon](https://github.com/dirtmelon)
|
||||
|
||||
- Introduce `IGListSwiftKit`, with Swift refinements for `dequeueReusableCellOfClass` methods. [Koen Punt](https://github.com/koenpunt) [(#1388)](https://github.com/Instagram/IGListKit/pull/1388).
|
||||
|
||||
- Added `APPLICATION_EXTENSION_API_ONLY` support for `IGListDiffKit` [Peter Meyers](https://github.com/pm-dev) [(#1422)](https://github.com/Instagram/IGListKit/pull/1422)
|
||||
|
|
|
|||
|
|
@ -75,6 +75,15 @@ NS_SWIFT_NAME(ListSectionController)
|
|||
*/
|
||||
- (void)didUpdateToObject:(id)object;
|
||||
|
||||
/**
|
||||
Asks the section controller if the cell at the specified index path should be selected
|
||||
|
||||
@param index The index of cell to be selected.
|
||||
|
||||
@note The default implementation returns YES. **Calling super is not required.**
|
||||
*/
|
||||
- (BOOL)shouldSelectItemAtIndex:(NSInteger)index;
|
||||
|
||||
/**
|
||||
Tells the section controller that the cell at the specified index path was selected.
|
||||
|
||||
|
|
|
|||
|
|
@ -80,6 +80,10 @@ void IGListSectionControllerPopThread(void) {
|
|||
|
||||
- (void)didUpdateToObject:(id)object {}
|
||||
|
||||
- (BOOL)shouldSelectItemAtIndex:(NSInteger)index {
|
||||
return YES;
|
||||
}
|
||||
|
||||
- (void)didSelectItemAtIndex:(NSInteger)index {}
|
||||
|
||||
- (void)didDeselectItemAtIndex:(NSInteger)index {}
|
||||
|
|
|
|||
|
|
@ -118,6 +118,11 @@
|
|||
|
||||
#pragma mark - UICollectionViewDelegate
|
||||
|
||||
- (BOOL)collectionView:(UICollectionView *)collectionView shouldSelectItemAtIndexPath:(NSIndexPath *)indexPath {
|
||||
IGListSectionController * sectionController = [self sectionControllerForSection:indexPath.section];
|
||||
return [sectionController shouldSelectItemAtIndex:indexPath.item];
|
||||
}
|
||||
|
||||
- (void)collectionView:(UICollectionView *)collectionView didSelectItemAtIndexPath:(NSIndexPath *)indexPath {
|
||||
// forward this method to the delegate b/c this implementation will steal the message from the proxy
|
||||
id<UICollectionViewDelegate> collectionViewDelegate = self.collectionViewDelegate;
|
||||
|
|
|
|||
Loading…
Reference in a new issue