From f1a7f70c2446b4d08d51499bcf3b111b0918a5c5 Mon Sep 17 00:00:00 2001 From: Zhisheng Huang Date: Mon, 11 Jan 2021 14:04:33 -0800 Subject: [PATCH] Ship the enable inline update by default for IGListBindingSingleSectionController Summary: We had shipped the IGListBindingSingleSectionController and have been using it for direct inbox/message/reaction list for a while now and it's quite stable for the inline update infra, there is no need to keep this boolean around anymore. Let's cleanup for good! Differential Revision: D25871674 fbshipit-source-id: b6cc9de9308d2d3feb7e354040c1b49ce588a4ec --- Source/IGListKit/IGListBindingSingleSectionController.h | 3 --- Source/IGListKit/IGListBindingSingleSectionController.m | 6 ++---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/Source/IGListKit/IGListBindingSingleSectionController.h b/Source/IGListKit/IGListBindingSingleSectionController.h index 3594070f..50bb496a 100644 --- a/Source/IGListKit/IGListBindingSingleSectionController.h +++ b/Source/IGListKit/IGListBindingSingleSectionController.h @@ -20,9 +20,6 @@ NS_ASSUME_NONNULL_BEGIN NS_SWIFT_NAME(ListBindingSingleSectionController) @interface IGListBindingSingleSectionController<__covariant ViewModel : id, Cell : UICollectionViewCell *> : IGListSectionController -// Testing the stability of this infra. Defaults to NO. -@property (nonatomic, readwrite, assign) BOOL enabledCellConfigurationDuringUpdate; - #pragma mark - Subclass // Required to be implemented by subclass. diff --git a/Source/IGListKit/IGListBindingSingleSectionController.m b/Source/IGListKit/IGListBindingSingleSectionController.m index 3e1e8fed..d1d208cb 100644 --- a/Source/IGListKit/IGListBindingSingleSectionController.m +++ b/Source/IGListKit/IGListBindingSingleSectionController.m @@ -74,10 +74,8 @@ } _item = object; - if (_enabledCellConfigurationDuringUpdate) { - if (_displayingCell) { - [self configureCell:_displayingCell withViewModel:_item]; - } + if (_displayingCell) { + [self configureCell:_displayingCell withViewModel:_item]; } }