Building a modern alternative to Salesforce, powered by the community.
Find a file
Sonarly Claude Code 1f2dccb047 Logging and timing instrumentation for Lambda executor
https://sonarly.com/issue/28633?type=bug

A TOCTOU (Time-of-Check-Time-of-Use) race condition in `ensureSdkLayer()` causes `CreateFunctionCommand` to fail with `InvalidParameterValueException: Layer version not found`. Two concurrent logic function builds within the same application share a single SDK layer but hold independent per-function locks. One process can delete all versions of the shared SDK layer (via `deleteAllLayerVersions()`) in the window between another process's `ListLayerVersions` call and its `CreateFunctionCommand` call, invalidating the ARN the second process obtained.

Fix: Two changes to `lambda.driver.ts` to fix the SDK layer TOCTOU race condition:

1. **Distributed lock on SDK layer name in `ensureSdkLayer()`**: Wrapped the destructive path (download SDK archive, reprefix, publish new layer version, delete old versions, mark fresh) in `cacheLockService.withLock()` keyed on `sdk-layer-build:${layerName}`. This serializes concurrent rebuild attempts across different logic functions that share the same application SDK layer. The lock uses the same TTL (120s), retry interval (500ms), and max retries (240) as the existing per-function build lock, matching team conventions.

2. **Publish-before-delete with version exclusion in `deleteAllLayerVersions()`**: Reordered `ensureSdkLayer()` to call `publishLayer()` BEFORE `deleteAllLayerVersions()`, and added an optional `excludeVersionArn` parameter to `deleteAllLayerVersions()` that skips the just-published version during cleanup. This ensures that concurrent fast-path readers (processes where `isSdkLayerStale=false`) still hold a valid layer ARN while the new version is being created. The old ARN remains valid throughout the publish window (~seconds of download+zip+upload), while the fast-path usage window is ~milliseconds.

Together, these changes eliminate the race where Process A obtains a layer ARN via `getExistingLayerArn()` that Process B deletes via `deleteAllLayerVersions()` before Process A can use it in `CreateFunctionCommand`.
2026-04-18 14:53:39 +00:00
.claude-pr Upgrade command internal doc (#19541) 2026-04-10 09:43:06 +00:00
.cursor Rename standard and custom apps (#19631) 2026-04-13 13:13:59 +00:00
.github Deprecate IS_RECORD_TABLE_WIDGET_ENABLED feature flag (#19662) 2026-04-13 21:13:15 +00:00
.vscode Migrate from ESLint to OxLint (#18443) 2026-03-06 01:03:50 +01:00
.yarn Refactor dependency graph for SDK, client-sdk and create-app (#18963) 2026-03-26 10:56:52 +00:00
packages Logging and timing instrumentation for Lambda executor 2026-04-18 14:53:39 +00:00
.dockerignore Scaffold light twenty app dev container (#18734) 2026-03-18 20:10:54 +01:00
.gitattributes Consolidate Prettier config and improve consistency (#15191) 2025-10-18 12:24:35 +02:00
.gitignore halftone v2 (#19573) 2026-04-11 10:00:24 +00:00
.mcp.json Fix AI chat re-renders and refactored code (#18585) 2026-03-21 12:52:21 +00:00
.nvmrc Upgrade to Node 24 (#13730) 2025-08-07 17:02:12 +02:00
.yarnrc.yml Refactor dependency graph for SDK, client-sdk and create-app (#18963) 2026-03-26 10:56:52 +00:00
CLAUDE.md Upgrade command internal doc (#19541) 2026-04-10 09:43:06 +00:00
jest.preset.js Move tools/eslint-rules to packages/twenty-eslint-rules (#17203) 2026-01-17 07:37:17 +01:00
LICENSE feat(sso): allow to use OIDC and SAML (#7246) 2024-10-21 20:07:08 +02:00
nx.json fix: replace npm pkg set with node script in set-local-version target (#19344) 2026-04-05 18:56:37 +00:00
package.json Bump @storybook/react-vite from 10.2.13 to 10.3.3 (#19232) 2026-04-02 08:49:11 +00:00
README.md docs: fix contributor docs links and typos (#18637) 2026-03-14 12:54:31 +01:00
tsconfig.base.json Revert "[hacktoberfest] feat: add fireflies" (#15589) 2025-11-04 12:25:23 +01:00
yarn.config.cjs [ENHC] Create Yarn constraints to validate node version (#10542) 2025-02-27 15:18:07 +01:00
yarn.lock fix: socket.io allows an unbounded number of binary attachments (#19812) 2026-04-17 17:17:56 +00:00

Twenty logo

The #1 Open-Source CRM

🌐 Website · 📚 Documentation · Roadmap · Discord · Figma


Cover


Installation

See: 🚀 Self-hosting 🖥️ Local Setup

Why Twenty

We built Twenty for three reasons:

CRMs are too expensive, and users are trapped. Companies use locked-in customer data to hike prices. It shouldn't be that way.

A fresh start is required to build a better experience. We can learn from past mistakes and craft a cohesive experience inspired by new UX patterns from tools like Notion, Airtable or Linear.

We believe in open-source and community. Hundreds of developers are already building Twenty together. Once we have plugin capabilities, a whole ecosystem will grow around it.


What You Can Do With Twenty

Please feel free to flag any specific needs you have by creating an issue.

Below are a few features we have implemented to date:

Personalize layouts with filters, sort, group by, kanban and table views

Companies Kanban Views

Customize your objects and fields

Setting Custom Objects

Create and manage permissions with custom roles

Permissions

Automate workflow with triggers and actions

Workflows

Emails, calendar events, files, and more

Other Features


Stack

Thanks

Chromatic Greptile Sentry Crowdin E2B

Thanks to these amazing services that we use and recommend for UI testing (Chromatic), code review (Greptile), catching bugs (Sentry) and translating (Crowdin).

Join the Community