mirror of
https://github.com/LerianStudio/ring
synced 2026-04-21 13:37:27 +00:00
9cb5a72737
Propagates the 10-reviewer peer list across agent frontmatter, Position/Critical prose, shared-patterns, skill dispatchers, gate validators, and docs — resolving drift left behind when multi-tenant-reviewer and lib-commons-reviewer were added to the pool. Also fixes broken shared-pattern paths in lib-commons-reviewer and adds substantive blocker criteria to multi-tenant-reviewer plus codebase-context severity heuristic (Lerian third-rail vs external recommendation) to lib-commons-reviewer. X-Lerian-Ref: 0x1
55 lines
3.9 KiB
Markdown
55 lines
3.9 KiB
Markdown
---
|
|
name: shared-pattern:gate-cadence-classification
|
|
description: Classification of dev-cycle gates by execution cadence (subtask/task/cycle).
|
|
---
|
|
|
|
# Gate Cadence Classification
|
|
|
|
## Three Cadences
|
|
|
|
### Subtask Cadence
|
|
Runs for every subtask (or task itself if no subtasks). Input scoped to a single unit.
|
|
- Backend: Gate 0 (Implementation + delivery verify), Gate 3 (Unit Testing), Gate 9 (Validation)
|
|
- Frontend: Gate 0 (Implementation), Gate 3 (Unit Testing), Gate 8 (Validation)
|
|
|
|
### Task Cadence
|
|
Runs once per task, after all subtasks complete their subtask-level gates. Input is
|
|
UNION of all subtasks' changes.
|
|
- Backend: Gate 1 (DevOps), Gate 2 (SRE), Gate 4 (Fuzz), Gate 5 (Property), Gate 6 write
|
|
(Integration), Gate 7 write (Chaos), Gate 8 (Review — 10 reviewers)
|
|
- Frontend: Gate 1 (DevOps), Gate 2 (Accessibility), Gate 4 (Visual), Gate 5 (E2E),
|
|
Gate 6 (Performance), Gate 7 (Review — 5 reviewers)
|
|
|
|
### Cycle Cadence
|
|
Runs once per cycle at cycle end.
|
|
- Backend: Gate 6 execute (Integration), Gate 7 execute (Chaos), Multi-Tenant Verify,
|
|
dev-report, Final Commit
|
|
- Frontend: Final Commit (minimal cycle-level processing)
|
|
|
|
## Why Cadence Matters
|
|
|
|
Running task-cadence gates at subtask cadence causes redundant work: Dockerfile
|
|
validation, observability coverage checks, fuzz seed generation, and cumulative diff
|
|
review all have outputs that stabilize at the task boundary, not the subtask boundary.
|
|
The task-level cumulative diff is strictly more informative for review than N
|
|
per-subtask fragments because interaction bugs between subtasks are visible only in
|
|
the cumulative view.
|
|
|
|
## Implementation Requirement
|
|
|
|
Sub-skills that run at task cadence MUST accept aggregated input:
|
|
- `implementation_files`: array (union across all subtasks of the task)
|
|
- `gate0_handoffs`: array (one entry per subtask)
|
|
|
|
Sub-skills that run at subtask cadence MUST continue to accept scoped input:
|
|
- `implementation_files`: array (this subtask's changes only)
|
|
- `gate0_handoff`: object (this subtask's handoff)
|
|
|
|
## Anti-Rationalization Table
|
|
|
|
| Rationalization | Why It's WRONG | Required Action |
|
|
|-----------------|----------------|-----------------|
|
|
| "Running a task-cadence gate per subtask is safer — more runs catch more bugs" | Task-cadence gates (devops, SRE, fuzz, property, integration-write, chaos-write, review) operate on the UNION of subtask outputs. Per-subtask firing wastes cycle time on in-flight code that will be re-tested when the task completes. Fuzz seeds and property shrinkers stabilize at task boundary; earlier firing produces noisier results. | **MUST dispatch task-cadence gates once per task, after ALL subtasks have passed their subtask-cadence gates (0, 3, 9).** |
|
|
| "A cycle-cadence gate can run at task end — close enough" | Cycle-cadence gates (integration-execute, chaos-execute, multi-tenant-verify, migration-safety, dev-report) require shared infrastructure (containers, Toxiproxy, tenant fixtures) whose setup/teardown cost dominates the actual check. Firing them per task inflates cycle duration by the number of tasks. | **MUST defer execute-mode infrastructure gates to cycle end (Step 12.x of dev-cycle).** |
|
|
| "This task has only one subtask, so cadence doesn't matter" | Cadence is a schema-level invariant enforced by `validate-gate-progression.sh` and the state-write paths documented in `dev-cycle/SKILL.md`. Bypassing it writes state to the wrong path and breaks the hook's progression check for the next task that has multiple subtasks. | **MUST follow the documented cadence regardless of subtask count. Treat single-subtask tasks as "subtasks: [task-itself]" for state purposes.** |
|
|
| "I'll run all gates per subtask because the cycle is short anyway" | Cycle brevity does not license cadence violation. The cadence model is also how reviewers consume aggregate context; per-subtask firing produces incomplete review inputs. | **MUST classify each gate against this table before dispatch. When unclear, STOP and ask the orchestrator.** |
|