Commit graph

70 commits

Author SHA1 Message Date
Fred Amaral
9cb5a72737
fix(codereview): align reviewer references and harden lib-commons/multi-tenant agents
Propagates the 10-reviewer peer list across agent frontmatter, Position/Critical prose, shared-patterns, skill dispatchers, gate validators, and docs — resolving drift left behind when multi-tenant-reviewer and lib-commons-reviewer were added to the pool. Also fixes broken shared-pattern paths in lib-commons-reviewer and adds substantive blocker criteria to multi-tenant-reviewer plus codebase-context severity heuristic (Lerian third-rail vs external recommendation) to lib-commons-reviewer.

X-Lerian-Ref: 0x1
2026-04-18 20:18:16 -03:00
Fred Amaral
14d84dbaa0
feat(review): add multi-tenant and lib-commons agents to review cycle
docs: align all documentation with the new 10-reviewer workflow
docs(lib-commons): update skill to reflect major v5.0.2 release
chore(hooks): tune context reminder hook to reduce token consumption
2026-04-18 19:32:16 -03:00
Fred Amaral
33c9e97d03
fix(codereview): complete cache-first standards injection end-to-end
The cache-first feature injected <standards> blocks into 5 reviewer dispatch prompts, but only performance-reviewer parsed them — code, business-logic, security, and test reviewers ignored the injection and re-fetched standards on every run. The orchestrator-side half shipped without the consumer-side half.

Each of the 4 default reviewer agents now has a Standards Loading (Cache-First) section implementing the canonical three-tier resolution: cache hit from state.cached_standards, cache miss via WebFetch with warning, standalone fallback to hardcoded URLs. The per-reviewer fallback URL lists are unique and derived from each reviewer's standards_slice.

The 5-way verbatim duplication of the dispatch block in codereview/SKILL.md is collapsed to per-reviewer URL-slice markers that reference shared-patterns/standards-cache-protocol.md as the single source of truth. The shared pattern now carries the canonical <standards> template, orchestrator pseudocode, three-tier protocol, rolling-standards policy, and an anti-rationalization table defending cache-first behavior. Net 117-line reduction in codereview/SKILL.md.

X-Lerian-Ref: 0x1
2026-04-18 10:44:17 -03:00
Fred Amaral
600a505c9a
docs: propagate performance-reviewer as 8th codereview agent across all downstream references
Update all skills, agents, shared patterns, docs, and platform configs that still referenced 7 code review agents to reflect the 8th reviewer (ring:performance-reviewer). Includes agent self-descriptions, dispatch instructions, anti-rationalization tables, slicing math, gate tables, and opencode schema definitions.

X-Lerian-Ref: 0x1
2026-04-14 15:53:45 -03:00
Fred Amaral
c142c3d720
refactor(skills): remove commands layer and rename skills to match command names
Skills are now the sole invocation mechanism — commands have been eliminated
as an architectural layer. All 33 commands removed, 22 skills renamed to
match the command names teams already knew, and 1 new skill (portfolio-review)
created to replace the last orchestrator command.

Renames: brainstorming→brainstorm, requesting-code-review→codereview,
git-commit→commit, session-handoff→create-handoff, drawing-diagrams→diagram,
executing-plans→execute-plan, exploring-codebase→explore-codebase,
interviewing-user→interview-me, linting-codebase→lint,
release-guide-info→release-guide, visual-explainer→visualize,
using-git-worktrees→worktree, writing-plans→write-plan,
dev-feedback-loop→dev-report, delivery-status-tracking→delivery-status,
delivery-reporting→delivery-report, executive-reporting→executive-summary,
dependency-mapping→dependency-analysis, documentation-review→review-docs,
writing-functional-docs→write-guide, writing-api-docs→write-api

Generated-by: Claude
AI-Model: claude-opus-4-6
2026-04-12 10:14:20 -03:00
Fred Amaral
fa6c4c87e8
docs(frontmatter): create canonical schema to standardize component metadata
feat(hooks): add schema validator and enhance skill generation
refactor(*): align all components with the new frontmatter schema
refactor(commands): replace arguments object with simple argument-hint
refactor(agents): remove invalid version field from agent frontmatter
test(hooks): add unit tests for frontmatter validation and generation
2026-04-06 09:52:28 -07:00
Fred Amaral
483bf84491
feat(review-slicer): upgrade to adaptive cohesion-based slicing (v2)
Replace the deterministic file-count threshold system with a three-phase
adaptive reasoning model (volume → cohesion → cost-benefit) that evaluates
semantic coupling between changed files before deciding whether to slice.

The slicer now receives enriched inputs — package maps, import adjacency
lists, and hunk-header change summaries — enabling it to assess structural
cohesion rather than relying solely on file count and directory spread.
Hard guardrails remain at the extremes (<5 = never, 40+ = always), while
the 5–39 file range triggers mandatory cohesion analysis.

Key changes:
- Agent: 3-phase reasoning, new input schema, Sonnet-class model target
- Skill + Command: collect package_map, import_hints, change_summary
- Shared pattern: updated rationale, cost model, anti-rationalization table

Generated-by: Claude
AI-Model: claude-opus-4-6
2026-03-17 08:34:37 -07:00
Fred Amaral
35508110d3
feat(review): introduce review slicing for large pull requests
Large pull requests suffer from context pollution, where automated
reviewers must process many unrelated files. This dilutes focus, leading
to shallower analysis and degraded review quality.

This commit introduces Review Slicing to solve this problem by improving
review depth for large, multi-themed changes.

A new orchestrator agent, `ring:review-slicer`, is introduced. It uses a
deterministic heuristic (based on file count and directory span) to
decide whether to slice a PR. For large PRs (e.g., 15+ files), it
classifies changed files into thematic slices. For small PRs, the
standard review process is used, adding no overhead.

The core review skill and command now dispatch all seven reviewers in
parallel for each slice, providing them with a focused, scoped diff.
A new consolidation step then merges and deduplicates findings from all
slices into a single report, identifying "cross-cutting concerns" that
appear across multiple slices and may signal architectural issues.
2026-03-10 18:35:48 -03:00
Fred Amaral
c1d4fe6d45
feat(review): add dead-code-reviewer agent for orphan detection
Introduces a new parallel reviewer, `ring:dead-code-reviewer`, to
systematically identify orphaned code resulting from changes. This
enhances codebase hygiene by detecting unused helpers, types, and
tests, thereby reducing technical debt and improving maintainability.

The parallel code review system is expanded from 6 to 7 concurrent
reviewers. All related workflows, skills, commands, and documentation
have been updated to integrate this new capability.

- Add the `ring:dead-code-reviewer` agent, which analyzes code across
 three concentric rings (target, direct dependents, ripple effect) to
 find unreachable code.
- Update the `/ring:codereview` command and `ring:requesting-code-review`
 skill to dispatch all 7 reviewers in a single parallel step.
- Adjust project documentation, including architecture diagrams, manuals,
 and agent guides, to reflect the 7-reviewer workflow.
2026-03-09 21:17:22 -03:00
Fred Amaral
0e7e5ca396
refactor: decouple agents from specific model requirements
Removes the hard-coded `model: "opus"` requirement from all agent
definitions, skill examples, and command documentation. The orchestrator
is now responsible for model selection, making the agent framework more
flexible and model-agnostic.

Key changes include:
- Removing the `model` parameter from all agent frontmatter and Task
 tool examples.
- Deleting the "Model Requirement" hard gate and self-verification
 sections from all agent prompts. This simplifies the prompts and
 removes model-specific enforcement logic.
- Updating core documentation (ARCHITECTURE, MANUAL, README) to reflect
 that model selection is an orchestrator concern.
- Removing redundant `changelog` and `last_updated` fields from agent
 frontmatter, as this information is tracked by source control.

This architectural shift allows the orchestrator to dynamically choose
the best model for a given task based on complexity, cost, or speed,
without being constrained by the agent's definition. It simplifies
agent maintenance and prepares the system for easier integration of
future AI models.
2026-03-08 16:33:12 -03:00
Fred Amaral
44f72ee6a3
feat(review): add consequences-reviewer to parallel code review
Code reviews that focus only on changed files can miss how those
changes break other parts of the codebase. Callers, contract
consumers, and dependent modules can be inadvertently affected, leading to
bugs that are difficult to detect in a localized review.

This commit introduces a new agent, `ring:consequences-reviewer`, to
systematically trace these "ripple effects." Its purpose is to analyze
the downstream impact of code changes by walking caller chains and
verifying consumer contracts.

The core parallel code review workflow, orchestrated by the
`/ring:codereview` command, now dispatches six agents in parallel
instead of five. All related documentation, skills, and agent prompts
have been updated to reflect this more robust 6-reviewer process.
2026-02-20 17:18:33 -03:00
Jefferson Rodrigues
1a770a9d0b
fix(default): normalize enforcement words to sentence start in reviewers
Move MUST/CANNOT/REQUIRED/MANDATORY to beginning of instruction sentences and lowercase context words (all/any/each/every) per lexical salience guidelines across business-logic, code, and test reviewers.

X-Lerian-Ref: 0x1
2026-02-13 00:41:24 -03:00
Jefferson Rodrigues
507c4433df
fix(default): expand Standards Compliance and add XML tags to reviewers
Expand business-logic-reviewer Standards Compliance Report with standards checklist, report template, and documentation rules. Wrap Pressure Resistance, When Not Needed, and Standards Compliance sections in XML semantic tags for code-reviewer and test-reviewer.

X-Lerian-Ref: 0x1
2026-02-13 00:32:47 -03:00
Jefferson Rodrigues
aa56ad163c
fix(default): add XML semantic tags and enforcement-first blocks to agents
Wrap Pressure Resistance, When Not Needed, and Standards Compliance sections in XML semantic tags for business-logic and security reviewers. Replace weak minimal review phrasing with enforcement-first MANDATORY blocks across code, test reviewers. Add required tag to codebase-explorer standards handoff.

X-Lerian-Ref: 0x1
2026-02-13 00:09:41 -03:00
Jefferson Rodrigues
ddfe56248d
fix(default): add missing CLAUDE.md mandatory sections to reviewer agents
Add Pressure Resistance, When Not Needed, and Standards Compliance Report sections to business-logic-reviewer, code-reviewer, security-reviewer, and test-reviewer. Add Non-Negotiables to code-reviewer. Add Standards Compliance Report (N/A) to codebase-explorer. All sections follow nil-safety-reviewer reference pattern.

X-Lerian-Ref: 0x1
2026-02-12 23:53:39 -03:00
Jefferson Rodrigues
212478bfaa
Merge pull request #160 from LerianStudio/feat/agent-testing-modes-and-compliance
Feat/agent testing modes and compliance
2026-02-10 16:24:13 -03:00
Jefferson Rodrigues
cb8d6a4a33
fix(nil-safety-reviewer): add Standards Compliance Report section
Wrap Anti-Rationalization Table under the required Standards Compliance Report heading to complete all mandatory agent sections per CLAUDE.md checklist.

X-Lerian-Ref: 0x1
2026-02-10 15:07:40 -03:00
Jefferson Rodrigues
0637d157c8 fix(nil-safety-reviewer): add missing CLAUDE.md compliance sections
Bring nil-safety-reviewer into compliance with the Agent Modification
Verification checklist. The agent was missing 5 required sections and
had an incomplete anti-rationalization table.

Changes:
- Rename "Shared Patterns" → "Standards Loading (MANDATORY)" with gate
- Add "Blocker Criteria - STOP and Report" with nil-safety specifics
- Add "Cannot Be Overridden" with 6 non-negotiable requirements
- Rename "Domain-Specific Severity Examples" → "Severity Calibration"
- Add "Pressure Resistance" with 6 nil-safety scenarios
- Fix anti-rationalization table: add "Why It's WRONG" column
- Add "When Nil-Safety Review Is Not Needed" section
- Version bump 1.0.0 → 1.1.0

Generated-by: Claude
AI-Model: claude-opus-4-6
2026-02-10 14:39:49 -03:00
Fred Amaral
7fd01e41f7
feat(workflows): expand code review and dev-cycle with advanced testing
The parallel code review process expands from 3 to 5 reviewers to
enhance code quality. This introduces `ring:test-reviewer` and
`ring:nil-safety-reviewer` to provide deeper analysis of test coverage
and null safety patterns, improving overall reliability.

The `dev-cycle` workflow is upgraded from a 6-gate to a 10-gate process,
incorporating a sophisticated suite of automated testing gates:
- Unit Testing (Gate 3)
- Fuzz Testing (Gate 4)
- Property-based Testing (Gate 5)
- Integration Testing (Gate 6)
- Chaos Testing (Gate 7)

This change establishes a much higher standard for testing and ensures
features are more resilient and production-ready.

Finally, new agents and commands are added to the PMO and Product plugins
to support delivery tracking, design validation, and reporting, further
extending the system's capabilities across the development lifecycle.
All documentation is updated to reflect these enhancements.
2026-02-09 21:05:41 -03:00
Fred Amaral
a22f7fc3f7
Revert "docs: update prose and examples to use ring- format"
This reverts commit b69a16c405.
2026-02-09 09:32:25 -03:00
Fred Amaral
b69a16c405
docs: update prose and examples to use ring- format
Transform all user-facing Ring component references from colon-based
notation (ring:) to a standardized hyphen-based format (ring-).

This change affects skill names, agent names, and slash commands in all
documentation, guides, and examples. The goal is to create a consistent
and user-friendly namespace that is easier to read and type.

For example:
- Skill/Agent references like `ring:code-reviewer` become `ring-code-reviewer`
- Slash commands like `/ring:codereview` become `/ring-codereview`

The colon-based format (`ring:`) is intentionally preserved in YAML
frontmatter (`name: ring:skill-name`) for internal metadata, separating
the user-facing display name from the internal tooling identifier.
2026-02-08 22:26:17 -03:00
Jefferson Rodrigues
5f4f8afd63
refactor: remove rate limiting and CORS references
Removes all rate limiting and CORS references across agents, skills, commands, and standards. These features had no dedicated standard — only scattered checklist items and examples. Cleans up 17 files including security-reviewer checklist, API doc status codes, severity examples, and log examples.

X-Lerian-Ref: 0x1
2026-02-07 20:19:34 -03:00
Fred Amaral
29b383e14b
refactor(agents): remove model directives from default/ agents
Remove model: opus from frontmatter and Model Requirements sections

from all 7 default/ agents to allow model inheritance from Task invocation.

Affected agents:

- code-reviewer

- business-logic-reviewer

- security-reviewer

- test-reviewer

- nil-safety-reviewer

- write-plan

- codebase-explorer

X-Lerian-Ref: 0x1
2026-02-04 18:06:33 -03:00
Fred Amaral
d96d40c3a7
refactor: enforce unified ring: namespace across all components
Updates all Ring component references to use the ring: prefix consistently. This applies to commands (/ring:*), skills (ring:*), and agents (ring:*) throughout documentation, command files, and skill files.

Updated counts: 56 skills (was 59), 24 agents (was 22), 22 commands (was 23). Fixed 20+ skill references and 15+ command references missing the ring: prefix.

Files updated: CLAUDE.md, README.md, MANUAL.md, command definitions, skill files, and agent documentation.

X-Lerian-Ref: 0x1
2026-01-15 00:08:25 -03:00
Fred Amaral
5ae0fe0104
refactor: remove project-local persistence layer
Removes all features that saved session data to .ring/ folders in user projects. This includes artifact indexing (SQLite FTS5), context usage tracking, learning extraction, continuity ledgers, outcome inference, and automated session tracking.

Deleted infrastructure: 7 hooks, 4 skills, 2 commands, artifact-index lib (SQLite), compound_learnings lib, outcome-inference lib, shared utilities (ledger-utils, context-check, get-context-usage), tests, and documentation.

Updated: hooks.json (removed PostToolUse/PreCompact/Stop hooks), session-start.sh (removed ledger loading), hook-utils.sh (removed .ring directory functions), test files (removed context/ledger tests).
X-Lerian-Ref: 0x1
2026-01-15 00:07:53 -03:00
Fred Amaral
6309c51213
refactor(core): prefix all components with 'ring:' for a unified API
feat(codereview): add data-flow and context-compilation analysis tools
2026-01-14 03:10:38 -03:00
Fred Amaral
67e5677a4e
refactor(plugins): unify namespace and archive legacy teams
This commit restructures the plugin ecosystem to improve maintainability,
simplify component invocation, and focus on high-value domains.

Key changes:
- **Unified Namespace:** All component invocations are standardized to the
 `ring:{component}` format, replacing the verbose `ring-{plugin}:...`
 prefix. This simplifies usage and abstracts the internal plugin
 structure.

- **Archive Legacy Plugins:** The `finance-team`, `ops-team`, `pmm-team`,
 and `pmo-team` plugins are moved to a new `.archive` directory.
 These plugins contained complex, outdated patterns and are now
 preserved for historical reference only.

- **Introduce FinOps Plugin:** A new, highly-focused `finops-team` plugin
 is added to handle Brazilian financial regulatory compliance (BACEN,
 RFB), consolidating critical functionality into a more focused package.

- **Update Documentation:** Core documentation (`ARCHITECTURE.md`,`README.md`,
 `CLAUDE.md`, `MANUAL.md`) and the plugin marketplace are updated to
 reflect the new structure and unified namespace.
2026-01-12 14:54:27 -03:00
Fred Amaral
c5e9c57799
refactor(naming): prefix default entities with 'ring:' namespace
This change introduces a namespacing convention for all built-in agents,
commands, and skills to prevent potential naming collisions with
user-defined entities.

All default entity names in the frontmatter are now prefixed with
'ring:'. For example, 'name: code-reviewer' becomes
'name: ring:code-reviewer'.

This creates a clear distinction between core framework components and
custom ones, improving the system's overall robustness and
extensibility.
2026-01-12 14:35:51 -03:00
Fred Amaral
99a097ea47
feat(reviewers): add CodeRabbit nitpick pattern coverage
Expands Ring reviewers to detect patterns commonly flagged by CodeRabbit:

test-reviewer.md:
- Category 9: Error Handling in Test Code (silenced errors detection)
- Anti-Pattern 7: Silenced Errors in Test Code (Go/TS examples)
- Anti-Pattern 8: Misleading Test Names
- Anti-Pattern 9: Testing Language Behavior
- Enhanced Category 5: Assertion Quality with validation tables

code-reviewer.md:
- Dead Code Detection section (unused vars, no-op assignments, dead imports)
- Cross-Package Duplication detection

nil-safety-reviewer.md:
- API Response Initialization section (nil slice JSON serialization)
- Added omitempty tag documentation
- New patterns: nil slice/map in API response

ai-slop-detection.md:
- Stateless Structs pattern (Go-specific over-engineering)

reviewer-blocker-criteria.md:
- Updated test-reviewer from 8 to 9 categories

Coverage: 100% of identified CodeRabbit nitpick patterns now detected.
X-Lerian-Ref: 0x1
2026-01-09 18:42:26 -03:00
Fred Amaral
2cd2792f6d
fix(reviewers): address code review findings from 5-reviewer analysis
Changes based on parallel code review by code-reviewer, business-logic-reviewer,
security-reviewer, test-reviewer, and nil-safety-reviewer:

High priority fixes:
- Add self-verification section to test-reviewer for checklist enforcement
- Add conflict resolution guidance to codereview.md orchestration
- Create reviewer-quality-feedback.md shared pattern for accuracy tracking

Medium priority fixes:
- Add inline Model Requirements sections to code/business-logic/security reviewers
- Remove overlapping Test Quality section from code-reviewer
- Update reviewer-orchestrator-boundary.md to show all 5 reviewers
- Add prompt injection resistance to reviewer-anti-rationalization.md
- Fix interface nil check pattern with Kind() guard in nil-safety-reviewer
- Expand error-then-use pattern to cover (nil, nil) returns
- Add test security checks category to test-reviewer

Low priority fixes:
- Add TypeScript patterns (Array.find, Map.get) to nil-safety-reviewer
- Update test-reviewer blocker criteria to 4 items
- Clarify nullish coalescing gap description

X-Lerian-Ref: 0x1
2026-01-09 17:44:11 -03:00
Fred Amaral
3df2970318
feat(reviewers): add test and nil-safety agents, refactor to shared patterns
This commit significantly expands the automated code review capabilities
by introducing two new specialized reviewers and refactoring the existing
agent architecture for improved maintainability and scalability.

The primary goal is to provide more comprehensive feedback by assessing
test quality and nil/null pointer safety, which are common sources of bugs.

To avoid massive duplication of instructions with the introduction of
new agents, common reviewer principles have been extracted into a new
`shared-patterns` directory. This makes each reviewer agent's prompt
more focused on its specific domain and ensures consistency across all
reviewers.

Changes:
- Add `test-reviewer` to analyze test quality, coverage, edge cases,
 and anti-patterns.
- Add `nil-safety-reviewer` for Go and TypeScript to trace and report
 nil/null pointer risks.
- Create a `shared-patterns` directory containing common logic for agent
 model requirements, severity calibration, anti-rationalization,
 pressure resistance, and output schemas.
- Refactor `code-reviewer`, `business-logic-reviewer`, and
 `security-reviewer` to reference these shared patterns, significantly
 reducing their file size and complexity.
- Update the `codereview` command and `requesting-code-review` skill to
 orchestrate all five reviewers in parallel.
2026-01-09 17:15:14 -03:00
Fred Amaral
c589bc8ca1
feat(agents): introduce system-wide AI slop detection and prevention
AI agents can generate plausible but flawed code ("AI slop") that
includes hallucinated dependencies, scope creep, and context-unaware
implementations. This is a primary source of bugs and security risks.

To address this, introduce a system-wide framework for detecting and
preventing AI slop, centered around a new shared skill document:
`ai-slop-detection.md`.

This framework is integrated across the agent ecosystem:
- Specialist agents (engineers, DevOps) now perform a mandatory
 pre-submission self-check to catch their own slop before review.
- Reviewer agents (code, security, business) use new mandatory
 checklists to enforce quality gates against slop from other agents.
- Validation agents (QA, SRE) must verify command outputs to prevent
 reporting hallucinated metrics or test results.

This provides a defense-in-depth strategy against common AI failure
modes, improving code quality and mitigating supply-chain attack
vectors like "slopsquatting."
2025-12-28 10:32:42 -03:00
Fred Amaral
1c0f275660
feat(rag-planning): implement RAG-enhanced plan judging system
Add planning mode to artifact_query.py that returns structured precedent (successful/failed handoffs, relevant plans) for plan generation. Create plan validation script that checks keyword overlap with known failure patterns using bidirectional algorithm to prevent dilution bias. Update write-plan agent and writing-plans skill with mandatory Historical Precedent section, keyword sanitization, and validation step. Add comprehensive integration tests (15 passing) and documentation.

X-Lerian-Ref: 0x1
2025-12-27 22:00:53 -03:00
Jefferson Rodrigues
fd2fb62e5c
fix(security-reviewer): align VERDICT values with output_schema
Change 'CONDITIONAL (with conditions)' to 'NEEDS_DISCUSSION' to match
output_schema.verdict_values: [PASS, FAIL, NEEDS_DISCUSSION]

X-Lerian-Ref: 0x1
2025-12-23 03:41:53 -03:00
Jefferson Rodrigues
af1ff23fc6
fix(code-reviewer): align VERDICT values with output_schema
Change 'CONDITIONAL (with conditions)' to 'NEEDS_DISCUSSION' to match
output_schema.verdict_values: [PASS, FAIL, NEEDS_DISCUSSION]

X-Lerian-Ref: 0x1
2025-12-23 03:40:35 -03:00
Jefferson Rodrigues
9926803f86
fix(business-logic-reviewer): align VERDICT values with output_schema
Change 'CONDITIONAL (with conditions)' to 'NEEDS_DISCUSSION' to match
output_schema.verdict_values: [PASS, FAIL, NEEDS_DISCUSSION]

X-Lerian-Ref: 0x1
2025-12-23 03:39:51 -03:00
Jefferson Rodrigues
6f435ea98d
fix(code-reviewer): add blank line for MD058 and Standards Compliance Report section
- Add blank line between Anti-Rationalization heading and table (MD058)
- Add Standards Compliance Report section with required output fields:
  VERDICT, Issues Found, What Was Done Well, Recommendations, Evidence/References
- Add severity definitions table (CRITICAL/HIGH/MEDIUM/LOW)

X-Lerian-Ref: 0x1
2025-12-23 03:31:55 -03:00
Jefferson Rodrigues
0d3eebd0d4
fix(security-reviewer): add blank line for MD058 and Standards Compliance Report section
- Add blank line between Anti-Rationalization heading and table (MD058)
- Add Standards Compliance Report section with required output fields:
  VERDICT, Vulnerabilities Found, OWASP Top 10 Coverage, Attack Vector Analysis,
  What Was Done Well, Remediation Guidance
- Add security reference mappings table (CWE, OWASP, Severity formats)

X-Lerian-Ref: 0x1
2025-12-23 03:26:04 -03:00
Jefferson Rodrigues
379133cd09
fix(business-logic-reviewer): add blank line for MD058 and Standards Compliance Report section
- Add blank line between Anti-Rationalization heading and table (MD058)
- Add Standards Compliance Report section with required output fields:
  VERDICT, Issues Found, Mental Execution Analysis, What Was Done Well, Recommendations

X-Lerian-Ref: 0x1
2025-12-23 03:24:48 -03:00
Jefferson Rodrigues
fd0313fa28
feat(reviewers): enforce orchestrator boundary pattern
- Add shared-patterns/reviewer-orchestrator-boundary.md defining the
  'Reviewers REPORT, Agents FIX' principle
- Add 'Orchestrator Boundary' section to all three reviewer agents:
  - code-reviewer.md: CANNOT use Edit/Create tools, must report only
  - business-logic-reviewer.md: CANNOT modify code, must report only
  - security-reviewer.md: CANNOT fix vulnerabilities, must report only
- Include anti-rationalization tables for 'I'll just fix this' temptation
- Document workflow: reviewer reports -> orchestrator dispatches -> agent fixes

This ensures consistent separation of concerns across all reviewers.

Generated-by: Claude
AI-Model: claude-sonnet-4-20250514
2025-12-23 01:23:10 -03:00
Brecci
22e60c02f2
feat(standards): add Access Manager Integration documentation
Add comprehensive Access Manager (plugin-auth + identity + lib-auth)
integration documentation across Ring standards and pre-dev workflows.

Changes:
- golang.md: Add "Access Manager Integration (MANDATORY)" section with
  lib-auth v2 patterns, route middleware, M2M auth, forbidden patterns
- standards-coverage-table.md: Add section #7 to backend-engineer-golang
  index (now 20 sections total)
- backend-engineer-golang.md: Update inline section index with Access Manager
- pre-dev-full.md: Add Question 2 for auth requirements selection
- pre-dev-feature.md: Add Question 2 for auth requirements selection
- pre-dev-trd-creation: Add Authentication/Authorization Architecture section
  with conditional check and middleware emphasis
- pre-dev-prd-creation: Add Security Requirements Discovery (business level)
- pre-dev-dependency-map: Add Authentication Dependencies section with
  lib-auth requirement and middleware implementation notes
- security-reviewer.md: Add conditional Access Manager checks for Go services
  focusing on route middleware protection

Key patterns documented:
- Route middleware: auth.Authorize(applicationName, resource, action)
- M2M auth: GetApplicationToken(ctx, clientID, clientSecret)
- Required env vars: PLUGIN_AUTH_ADDRESS, PLUGIN_AUTH_ENABLED
- lib-auth is mandatory; direct plugin-auth calls are forbidden

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-17 11:55:35 -03:00
Jefferson Rodrigues
f4ef03b244
refactor: remove ring-{plugin}: prefix from agent/skill/command names
Simplify naming convention by removing fully qualified prefixes from all components. Names now use simple format (e.g., code-reviewer instead of ring-default:code-reviewer).

X-Lerian-Ref: 0x1
2025-12-16 01:50:31 -03:00
Jefferson Rodrigues
4cd6651cac
fix: use fully qualified agent names (ring-{plugin}:{agent})
Update all agent references to use the ring-{plugin}:{agent-name} format instead of bare agent names. This ensures consistent naming across all plugins and prevents ambiguity in multi-plugin environments.

X-Lerian-Ref: 0x1
2025-12-15 22:13:38 -03:00
Jefferson Rodrigues
f23d22fa05
fix: add ring-default prefix to skill refs in write-plan agent
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-15 20:42:04 -03:00
Jefferson Rodrigues
f5c0b9f273
fix: add ring-default prefix to agent refs in business-logic-reviewer
Updated lines 85 and 641 to use fully qualified agent names:
- code-reviewer → ring-default:code-reviewer
- security-reviewer → ring-default:security-reviewer

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-15 20:40:26 -03:00
Jefferson Rodrigues
9b4fd3a5f4
fix: update all remaining component references to ring-{plugin}:{name} format
Comprehensive update of all agent, skill, and command references throughout
the repository to use fully qualified names:

- Agent refs: `agent-name` → `ring-{plugin}:agent-name`
- Skill refs: `skill-name` → `ring-{plugin}:skill-name`
- Command refs: `/command` → `/ring-{plugin}:command`

Files updated include:
- All agent files in */agents/
- All skill files in */skills/
- All command files in */commands/
- Documentation files (README, CLAUDE.md, ARCHITECTURE.md, WORKFLOWS.md)
- Shared patterns and standards files

This ensures consistency between documentation and implementation,
enabling unambiguous component resolution in multi-plugin environments.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-15 20:26:43 -03:00
Jefferson Rodrigues
bd9bc7d2ad
fix: update all internal references to use ring-{plugin}:{name} format
- Agent invocation examples in 44 agent files
- Subagent_type references in skill files
- Skill tool references across all plugins
- Command references in pmo-team, ops-team, tw-team commands
- docs/platforms/claude-code.md examples
- dev-team/skills/shared-patterns/shared-orchestrator-principle.md
2025-12-15 20:14:32 -03:00
Jefferson Rodrigues
5473e2a41b
refactor: standardize naming to ring-{plugin}:{component} format
Update all agents, skills, and commands across 9 plugins to use fully qualified names in YAML frontmatter. This enables unambiguous component identification in multi-plugin environments.

Changes:

- 42 agents: name field updated to ring-{plugin}:{agent-name}

- 87 skills: name field updated to ring-{plugin}:{skill-name}

- 27 commands: name field updated (added frontmatter where missing)

- CLAUDE.md: Fixed contradictory examples in naming conventions

- ARCHITECTURE.md: Updated invocation examples throughout

X-Lerian-Ref: 0x1
2025-12-15 19:52:14 -03:00
Jefferson Rodrigues
228a79cb20
refactor: rename shared-patterns files with semantic prefixes
- Rename execution-report.md to output-execution-report.md
- Rename anti-rationalization.md to shared-anti-rationalization.md
- Rename orchestrator-principle.md to shared-orchestrator-principle.md
- Rename pressure-resistance.md to shared-pressure-resistance.md
- Rename red-flags.md to shared-red-flags.md
- Rename tdd-prompt-templates.md to template-tdd-prompts.md
- Update all references across skills, agents, and documentation

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
2025-12-15 19:22:07 -03:00
Fred Amaral
03e6136464
feat(agents): add model self-verification to prevent incorrect usage
docs(standards): mandate explicit model parameter for specialized agents
feat(reviewers): add guidance for skipping reviews on trivial changes
refactor(docs): simplify shared pattern files for better reusability
fix(security): add SSRF to blocker criteria and OWASP version check
fix(docs): align heading levels and table formats for consistency
2025-12-14 00:05:33 -03:00