Commit graph

1623 commits

Author SHA1 Message Date
Vladimir Diaz
b0c86cacb4 Remove test condition for tuf.ForbiddenTargetError exception (has been removed) 2016-03-31 17:29:38 -04:00
Vladimir Diaz
e02f2f54a9 Minor comment fix and cosmetic edit 2016-03-31 17:26:10 -04:00
Vladimir Diaz
efc01f0007 Remove obsolete functions tested in test_roledb.py 2016-03-31 17:24:57 -04:00
Vladimir Diaz
09f6261b4a Specify correct number of arguments for modified _visit_child_role() 2016-03-31 13:26:06 -04:00
Vladimir Diaz
44ebd65b34 Remove roledb.get_parent_roles() 2016-03-31 13:09:03 -04:00
Vladimir Diaz
7196e547af Implement changes to allow for expected verification of target paths
Following the change where a repository resembles a graph of delegations, we now verify target paths (according to some parent role) when we visit child roles
2016-03-31 13:08:04 -04:00
Vladimir Diaz
bc8f51b9dd Update updater.py to remove the use of remove_delegated_roles() 2016-03-30 17:25:03 -04:00
Vladimir Diaz
f162b4b7e8 Update test_roledb following the changes to remove_delegated_roles() 2016-03-30 17:24:11 -04:00
Vladimir Diaz
aaf755e381 Delete remove_delegated_roles() and modify affected lines (including add_role())
We shouldn't remove delegated roles if the repository can resemble a graph of delegations, since the delegations of one role are independent of another
2016-03-30 16:43:51 -04:00
Vladimir Diaz
c20c83b3ff Remove parent 'targets' directory from role1.json paths 2016-03-29 15:35:20 -04:00
Vladimir Diaz
9536cacdee Fix bug where the snapshot and timestamp roles are listed in snapshot.json 2016-03-29 15:28:18 -04:00
Vladimir Diaz
28e738ed8c Repository data that contains the correct number of delegated roles in snapshot.json 2016-03-28 17:51:43 -04:00
Vladimir Diaz
51adc771a0 More bug fixes
When loading roles from disk, ensure these roles are not marked as dirty.  Add a boolean to relevant functions to provide the option to update the roledb without marking roles as dirty
2016-03-28 17:49:56 -04:00
Vladimir Diaz
f47cdb04d2 Remove 'targets' directory from path in 'test_extraneous_dependencies_attack.py
and fixes in repository_tool.py
2016-03-28 16:30:35 -04:00
Vladimir Diaz
8ccdff540f Convert list of dirty roles to set to avoid duplicates 2016-03-28 16:25:49 -04:00
Vladimir Diaz
283c62abe0 More unit test fixes
A delegated rolename is no longer required to start with 'targets'
2016-03-25 11:59:11 -04:00
Vladimir Diaz
9c0064e39d Fix remaining issues with add_target_to_bin() and remove_target_from_bin() 2016-03-24 13:55:44 -04:00
Vladimir Diaz
251bbaa93c Remove full name for hashed bin delegation, update comment, and remove outdated test condition 2016-03-24 13:16:43 -04:00
Vladimir Diaz
debf6190ee Use correct metadata name for hashed bin delegation 2016-03-24 13:15:36 -04:00
Vladimir Diaz
f844d1e6f1 wrap line 2016-03-24 13:14:41 -04:00
Vladimir Diaz
4cb34c45a6 Remove call to roledb.get_parent_rolename() in load_repository
Add all encountered delegated roles to the top-level targets object.  For example:
'django' role delegated by 'unclaimed' (which in turn was delgated by 'targets') is available at repository.targets('unclaimed')
2016-03-24 11:20:16 -04:00
Vladimir Diaz
b9c085114a Edit remaining changes required to the documentation following design changes to repo tools 2016-03-24 11:09:19 -04:00
Vladimir Diaz
37bdfd61ed Review and update repository tool documentation up to section 'Revoke Delegated Role' 2016-03-24 10:51:44 -04:00
Vladimir Diaz
9aa8c8ae9f Correct more bugs when loading delegated roles 2016-03-22 17:53:25 -04:00
Vladimir Diaz
b982c063db Latest WIP 2016-03-22 11:26:55 -04:00
Vladimir Diaz
b4626f172a Merge branch 'develop' of github.com:theupdateframework/tuf into remaining-1.0-tasks 2016-03-17 12:23:51 -04:00
Vladimir Diaz
d2cc96766f Merge pull request #325 from vladimir-v-diaz/awwad-detect_expiry_322_clean
Awwad detect expiry 322 clean
2016-03-17 11:51:58 -04:00
Vladimir Diaz
dd8a7eb0dd Review test_indefinite_freeze_attack.py and updater.py. Minor edits made 2016-03-17 11:36:11 -04:00
Sebastien Awwad
7cd20fe035
Fixing another bug in tuf/__init__() and making the intended logging there happen. 2016-03-16 16:45:58 -04:00
Sebastien Awwad
c4ef697ec8
Fix for newly discovered python 3 issue causing unprintable exceptions 2016-03-16 16:39:47 -04:00
Sebastien Awwad
1ee1f92a4d
added clarifying comments to repo and key loading 2016-03-16 14:27:40 -04:00
Sebastien Awwad
4d8732bee8
removing unnecessary loading of root keys in test 2016-03-16 14:23:58 -04:00
Sebastien Awwad
9137986301
Removing superstitious 0.1s sleeps. 2016-03-16 14:14:26 -04:00
Sebastien Awwad
167af8dd65
comment wording: refresh docstring explanation 2016-03-16 12:25:33 -04:00
Sebastien Awwad
893911614a
fixing minor comment wording 2016-03-16 11:54:18 -04:00
Sebastien Awwad
85a7502603
- Tweaked the sleep durations to be more minimal, based on time that had passed. (updater.refresh() can take a while.)
- Put code back into working state after some failure mode debugging of a separate bug by Vlad and me.
- Expanded some comments, added explanations, and made a few others more readable.
- Removed an unnecessary path recalculation and an unnecessary sleep.
2016-03-16 11:50:11 -04:00
Sebastien Awwad
ab4cbdde52
guaranteed test failure: unprintable on 3, printable on 2 2016-03-14 18:08:24 -04:00
Sebastien Awwad
93aec83fd5
fixing bug with logger.exception called outside of an except block 2016-03-14 17:43:22 -04:00
Sebastien Awwad
fee25a44cd
sharing bug with Vlad 2016-03-14 17:39:04 -04:00
Sebastien Awwad
0bf30b7ec3
Adding .DS_Store to gitignore 2016-03-14 16:51:54 -04:00
Sebastien Awwad
8250223207
removed unnecessary temp variable reload line; switched names of Test 1 and Test 2 2016-03-14 16:30:12 -04:00
Sebastien Awwad
08e005330a
Minor log message improvements. 2016-03-14 15:51:58 -04:00
Sebastien Awwad
6a4982fa8a
Improving comments in test_indefinite_freeze_attack 2016-03-14 12:59:46 -04:00
Sebastien Awwad
8adab689ff
Expanding and clarifying docstring for tuf.client.updater::refresh() 2016-03-14 12:40:06 -04:00
Sebastien Awwad
0fa4518929 comment improvement in indefinite freeze attack test 2016-03-11 17:01:35 -05:00
Sebastien Awwad
66f56271d2 This is a manual squash commit of detect_expiry_322, to avoid merge conflicts.
Comment lines from the individual commits include:
1. Fix #322 by detecting expiry of stale files. initial attempt
2. temp commit of files from Soma
3. removing freeze_attack_stale_expiry and leaving the test added to indefinite freeze attack
4. fixing indefinite freeze attack test: now incorporates old reject-freshly-downloaded-but-expired-timestamp test as well as reject-stale-already-present-but-expired-snapshot test
5. small refinements to indefinite freeze attack test
6. Pulled the recursion out of the except block in refresh() to avoid unprintable nested exceptions.
7. Added comments to the last commit (retry_once)
8. Merge pull request #1 from awwad/detect_expiry_322_temp (removing cruft in another branch)
2016-03-10 15:01:12 -05:00
Vladimir Diaz
c0dcc51a42 Add whitespace between two functions 2016-03-02 13:12:29 -05:00
Vladimir Diaz
a111661a72 Fix roledb.get_delegated_roles() and test cases in test_repository_tool.py 2016-03-02 13:08:46 -05:00
Vladimir Diaz
47265b36d4 Remove print() statement and add comment for generation of delegated roles 2016-03-02 12:09:19 -05:00
Vladimir Diaz
6611efbf09 Add the new delegation structure to repository_data 2016-03-02 12:03:39 -05:00