Vladimir Diaz
a048ca1630
Merge branch 'tighten-preorder-dfs' of https://github.com/trishankkarthik/tuf into trishankkarthik-tighten-preorder-dfs
2016-06-09 10:49:11 -04:00
Vladimir Diaz
dd8a7eb0dd
Review test_indefinite_freeze_attack.py and updater.py. Minor edits made
2016-03-17 11:36:11 -04:00
Sebastien Awwad
7cd20fe035
Fixing another bug in tuf/__init__() and making the intended logging there happen.
2016-03-16 16:45:58 -04:00
Sebastien Awwad
c4ef697ec8
Fix for newly discovered python 3 issue causing unprintable exceptions
2016-03-16 16:39:47 -04:00
Sebastien Awwad
167af8dd65
comment wording: refresh docstring explanation
2016-03-16 12:25:33 -04:00
Sebastien Awwad
93aec83fd5
fixing bug with logger.exception called outside of an except block
2016-03-14 17:43:22 -04:00
Sebastien Awwad
fee25a44cd
sharing bug with Vlad
2016-03-14 17:39:04 -04:00
Sebastien Awwad
8adab689ff
Expanding and clarifying docstring for tuf.client.updater::refresh()
2016-03-14 12:40:06 -04:00
Sebastien Awwad
66f56271d2
This is a manual squash commit of detect_expiry_322, to avoid merge conflicts.
...
Comment lines from the individual commits include:
1. Fix #322 by detecting expiry of stale files. initial attempt
2. temp commit of files from Soma
3. removing freeze_attack_stale_expiry and leaving the test added to indefinite freeze attack
4. fixing indefinite freeze attack test: now incorporates old reject-freshly-downloaded-but-expired-timestamp test as well as reject-stale-already-present-but-expired-snapshot test
5. small refinements to indefinite freeze attack test
6. Pulled the recursion out of the except block in refresh() to avoid unprintable nested exceptions.
7. Added comments to the last commit (retry_once)
8. Merge pull request #1 from awwad/detect_expiry_322_temp (removing cruft in another branch)
2016-03-10 15:01:12 -05:00
Vladimir Diaz
05d0acafd5
Remove extra whitespace
2016-02-29 11:03:12 -05:00
Vladimir Diaz
605d119195
Relocate the extraction of 'expected_versioninfo' earlier in the function as well
2016-02-26 16:50:30 -05:00
Vladimir Diaz
1193b79a75
Relocate the check for compressed metadata in _update_metadata_if_changed()
2016-02-26 16:45:37 -05:00
Vladimir Diaz
21910083bf
Fix comment to say that _update_metadata_if_changed() returns early if metadata has not been updated.
2016-02-26 15:54:38 -05:00
Vladimir Diaz
ddd06f6205
Clean up if-else clauses in _update_metadata_if_changed()
2016-02-26 14:27:15 -05:00
Vladimir Diaz
a92f6c5a35
Avoid find(), use split() instead
2016-02-26 13:36:34 -05:00
Vladimir Diaz
a1c4e76a50
Add note to previous comments for os.makedirs() OSError exceptions.
2016-02-26 12:59:07 -05:00
Vladimir Diaz
14843acc28
Expand comments related to os.makedirs() exception handling in download_target()
2016-02-26 12:47:12 -05:00
Vladimir Diaz
c270a1ed5a
Fix typo in _versioninfo_has_been_updated() docstring
2016-02-26 12:11:13 -05:00
Vladimir Diaz
acb2aa7d83
Avoid reusing/overwriting parameter _strip_consistent_snapshot_version_number()
2016-02-22 16:29:23 -05:00
Vladimir Diaz
ffd76ef2d6
Fix typo
...
All instances of embeded --> embedded
2016-02-22 16:21:16 -05:00
Vladimir Diaz
5ac9440edd
Emphasize exclusive-or paths in formats.make_versioninfo()
2016-02-22 16:16:44 -05:00
Vladimir Diaz
f580811202
Minor wording change in docstring of formats.make_versioninfo()
2016-02-22 16:11:52 -05:00
Vladimir Diaz
012e99ea2d
Remove unneeded information in Side Effects field of doctstring
2016-02-22 16:07:38 -05:00
Vladimir Diaz
dd9d31bef9
Add and fix comments in download_target() related to OSError exceptions
2016-02-22 16:03:49 -05:00
Vladimir Diaz
f52a9c8eff
Fix minor wording issue in _update_versioninfo()
2016-02-22 14:57:23 -05:00
Vladimir Diaz
7548163912
Change function name and update comments
...
_versioninfo_has_changed() --> _versioninfo_has_been_updated()
false --> False (typo)
Update comments to make it clear that metadata is considered updated when it's version number increases, rather than simply changed.
2016-02-22 14:46:54 -05:00
Trishank Karthik Kuppusamy
da0a9aa196
By default, limit visited number of delegations in preorder DFS.
2016-02-19 17:44:21 -05:00
Trishank Karthik Kuppusamy
03fbe320e1
Skip visited roles in preorder DFS.
2016-02-19 17:27:17 -05:00
Vladimir Diaz
cbdb3fc722
Update README.md
...
Tweak the `Overview of the Update Process` section (after discussion and tracing of behavior with Seb).
2016-02-19 17:06:11 -05:00
Vladimir Diaz
7119973af9
Revert "[WIP] Read all files from the metadata directory"
...
This reverts commit 88fc74af71 .
2016-02-19 16:07:19 -05:00
Vladimir Diaz
24646526dc
Update README.md
...
Include note that the root file is re-fetched once to avoid an infinite loop. (It loops only once in the reference implementation.)
2016-02-19 14:28:42 -05:00
Vladimir Diaz
dad3bff867
Merge branch 'develop' of github.com:theupdateframework/tuf into logo
2016-02-19 11:08:44 -05:00
Vladimir Diaz
88fc74af71
[WIP] Read all files from the metadata directory
2016-02-19 10:09:48 -05:00
Vladimir Diaz
da8221ccf9
Explain that crypto libraries may place further restrictions on keys
...
For example, PyCrypto requires that RSA keys be a multiple of 256
2016-02-12 13:07:42 -05:00
Vladimir Diaz
6bded2bce7
Remove remaining exception messages that are stored in temp variables
2016-02-11 15:28:51 -05:00
Vladimir Diaz
2a7bd8248f
Merge branch 'develop' of github.com:theupdateframework/tuf into 1.0-review2
2016-02-11 12:31:06 -05:00
Vladimir Diaz
2612ab6856
Minor edit to comment in create_rsa_signature()
2016-02-11 12:19:15 -05:00
Vladimir Diaz
e007507e0b
Expand comment to say that users have the option to update tuf.conf if a required library is unavailable
2016-02-11 12:17:52 -05:00
Vladimir Diaz
5b1a931177
Remove unneeded import statement ('Crypto')
2016-02-11 11:25:35 -05:00
Vladimir Diaz
541279be7a
Minor cosmetic edit to repository_tool.py
2016-02-11 10:07:32 -05:00
Vladimir Diaz
b5e75ab277
Raise an exception if a required privat key is unset
2016-01-29 10:57:25 -05:00
Vladimir Diaz
3f1bb37560
Clarify that keys with sizes lower than what we recommend may still be imported
2016-01-28 17:46:28 -05:00
Vladimir Diaz
6953fd758b
Delete irrelevant comment in import_rsakey_from_encrypted_pem()
2016-01-28 17:36:26 -05:00
Vladimir Diaz
c99bb0fe01
Reduce redundant info in a comment, but emphasize what is excluded in keyid
2016-01-28 15:48:29 -05:00
Vladimir Diaz
35ce49707c
Do not store exception message in temporary variables
2016-01-28 15:22:20 -05:00
Vladimir Diaz
39535f82e1
Do not store exception messages in temporary variables
2016-01-28 14:39:43 -05:00
Vladimir Diaz
75b8b66523
Fix doc test failures in two functions of keys.py
2016-01-28 14:26:56 -05:00
Vladimir Diaz
d9ecbc851f
Do not store private key material in exception messages
2016-01-28 14:03:49 -05:00
Vladimir Diaz
2452076467
Update comment to list PyCA's newly supported crypto library
2016-01-28 13:41:15 -05:00
Vladimir Diaz
1380b67642
conformat --> conformant
2016-01-28 13:30:17 -05:00