Vladimir Diaz
a048ca1630
Merge branch 'tighten-preorder-dfs' of https://github.com/trishankkarthik/tuf into trishankkarthik-tighten-preorder-dfs
2016-06-09 10:49:11 -04:00
Vladimir Diaz
d2cc96766f
Merge pull request #325 from vladimir-v-diaz/awwad-detect_expiry_322_clean
...
Awwad detect expiry 322 clean
2016-03-17 11:51:58 -04:00
Vladimir Diaz
dd8a7eb0dd
Review test_indefinite_freeze_attack.py and updater.py. Minor edits made
2016-03-17 11:36:11 -04:00
Sebastien Awwad
7cd20fe035
Fixing another bug in tuf/__init__() and making the intended logging there happen.
2016-03-16 16:45:58 -04:00
Sebastien Awwad
c4ef697ec8
Fix for newly discovered python 3 issue causing unprintable exceptions
2016-03-16 16:39:47 -04:00
Sebastien Awwad
1ee1f92a4d
added clarifying comments to repo and key loading
2016-03-16 14:27:40 -04:00
Sebastien Awwad
4d8732bee8
removing unnecessary loading of root keys in test
2016-03-16 14:23:58 -04:00
Sebastien Awwad
9137986301
Removing superstitious 0.1s sleeps.
2016-03-16 14:14:26 -04:00
Sebastien Awwad
167af8dd65
comment wording: refresh docstring explanation
2016-03-16 12:25:33 -04:00
Sebastien Awwad
893911614a
fixing minor comment wording
2016-03-16 11:54:18 -04:00
Sebastien Awwad
85a7502603
- Tweaked the sleep durations to be more minimal, based on time that had passed. (updater.refresh() can take a while.)
...
- Put code back into working state after some failure mode debugging of a separate bug by Vlad and me.
- Expanded some comments, added explanations, and made a few others more readable.
- Removed an unnecessary path recalculation and an unnecessary sleep.
2016-03-16 11:50:11 -04:00
Sebastien Awwad
ab4cbdde52
guaranteed test failure: unprintable on 3, printable on 2
2016-03-14 18:08:24 -04:00
Sebastien Awwad
93aec83fd5
fixing bug with logger.exception called outside of an except block
2016-03-14 17:43:22 -04:00
Sebastien Awwad
fee25a44cd
sharing bug with Vlad
2016-03-14 17:39:04 -04:00
Sebastien Awwad
0bf30b7ec3
Adding .DS_Store to gitignore
2016-03-14 16:51:54 -04:00
Sebastien Awwad
8250223207
removed unnecessary temp variable reload line; switched names of Test 1 and Test 2
2016-03-14 16:30:12 -04:00
Sebastien Awwad
08e005330a
Minor log message improvements.
2016-03-14 15:51:58 -04:00
Sebastien Awwad
6a4982fa8a
Improving comments in test_indefinite_freeze_attack
2016-03-14 12:59:46 -04:00
Sebastien Awwad
8adab689ff
Expanding and clarifying docstring for tuf.client.updater::refresh()
2016-03-14 12:40:06 -04:00
Sebastien Awwad
0fa4518929
comment improvement in indefinite freeze attack test
2016-03-11 17:01:35 -05:00
Sebastien Awwad
66f56271d2
This is a manual squash commit of detect_expiry_322, to avoid merge conflicts.
...
Comment lines from the individual commits include:
1. Fix #322 by detecting expiry of stale files. initial attempt
2. temp commit of files from Soma
3. removing freeze_attack_stale_expiry and leaving the test added to indefinite freeze attack
4. fixing indefinite freeze attack test: now incorporates old reject-freshly-downloaded-but-expired-timestamp test as well as reject-stale-already-present-but-expired-snapshot test
5. small refinements to indefinite freeze attack test
6. Pulled the recursion out of the except block in refresh() to avoid unprintable nested exceptions.
7. Added comments to the last commit (retry_once)
8. Merge pull request #1 from awwad/detect_expiry_322_temp (removing cruft in another branch)
2016-03-10 15:01:12 -05:00
Vladimir Diaz
a417f67129
Merge pull request #321 from vladimir-v-diaz/address-pr#295-review
...
Address pr#295 review
2016-03-01 13:22:40 -05:00
Vladimir Diaz
05d0acafd5
Remove extra whitespace
2016-02-29 11:03:12 -05:00
Vladimir Diaz
605d119195
Relocate the extraction of 'expected_versioninfo' earlier in the function as well
2016-02-26 16:50:30 -05:00
Vladimir Diaz
1193b79a75
Relocate the check for compressed metadata in _update_metadata_if_changed()
2016-02-26 16:45:37 -05:00
Vladimir Diaz
21910083bf
Fix comment to say that _update_metadata_if_changed() returns early if metadata has not been updated.
2016-02-26 15:54:38 -05:00
Vladimir Diaz
ddd06f6205
Clean up if-else clauses in _update_metadata_if_changed()
2016-02-26 14:27:15 -05:00
Vladimir Diaz
a92f6c5a35
Avoid find(), use split() instead
2016-02-26 13:36:34 -05:00
Vladimir Diaz
c6ffcf0d83
Update the unit tests for _versioninfo_has_been_updated() (to use the renamed function)
2016-02-26 13:35:37 -05:00
Vladimir Diaz
a1c4e76a50
Add note to previous comments for os.makedirs() OSError exceptions.
2016-02-26 12:59:07 -05:00
Vladimir Diaz
14843acc28
Expand comments related to os.makedirs() exception handling in download_target()
2016-02-26 12:47:12 -05:00
Vladimir Diaz
c270a1ed5a
Fix typo in _versioninfo_has_been_updated() docstring
2016-02-26 12:11:13 -05:00
Vladimir Diaz
1bed3e09a4
Update tuf-spec.txt
2016-02-25 17:29:36 -05:00
Vladimir Diaz
b008edd7cd
Update tuf-spec.txt
...
Begin section 5.1 (The Client Application) with a concise overview of the update procedure followed by client applications. Follow the overview text with the more detailed explanation of the update procedure.
2016-02-25 17:24:23 -05:00
Vladimir Diaz
acb2aa7d83
Avoid reusing/overwriting parameter _strip_consistent_snapshot_version_number()
2016-02-22 16:29:23 -05:00
Vladimir Diaz
ffd76ef2d6
Fix typo
...
All instances of embeded --> embedded
2016-02-22 16:21:16 -05:00
Vladimir Diaz
5ac9440edd
Emphasize exclusive-or paths in formats.make_versioninfo()
2016-02-22 16:16:44 -05:00
Vladimir Diaz
f580811202
Minor wording change in docstring of formats.make_versioninfo()
2016-02-22 16:11:52 -05:00
Vladimir Diaz
012e99ea2d
Remove unneeded information in Side Effects field of doctstring
2016-02-22 16:07:38 -05:00
Vladimir Diaz
dd9d31bef9
Add and fix comments in download_target() related to OSError exceptions
2016-02-22 16:03:49 -05:00
Vladimir Diaz
f52a9c8eff
Fix minor wording issue in _update_versioninfo()
2016-02-22 14:57:23 -05:00
Vladimir Diaz
7548163912
Change function name and update comments
...
_versioninfo_has_changed() --> _versioninfo_has_been_updated()
false --> False (typo)
Update comments to make it clear that metadata is considered updated when it's version number increases, rather than simply changed.
2016-02-22 14:46:54 -05:00
Trishank Karthik Kuppusamy
da0a9aa196
By default, limit visited number of delegations in preorder DFS.
2016-02-19 17:44:21 -05:00
Trishank Karthik Kuppusamy
03fbe320e1
Skip visited roles in preorder DFS.
2016-02-19 17:27:17 -05:00
Vladimir Diaz
cbdb3fc722
Update README.md
...
Tweak the `Overview of the Update Process` section (after discussion and tracing of behavior with Seb).
2016-02-19 17:06:11 -05:00
Vladimir Diaz
001a3af102
Merge pull request #317 from vladimir-v-diaz/develop
...
Revert "[WIP] Read all files from the metadata directory"
2016-02-19 16:16:52 -05:00
Vladimir Diaz
7119973af9
Revert "[WIP] Read all files from the metadata directory"
...
This reverts commit 88fc74af71 .
2016-02-19 16:07:19 -05:00
Vladimir Diaz
24646526dc
Update README.md
...
Include note that the root file is re-fetched once to avoid an infinite loop. (It loops only once in the reference implementation.)
2016-02-19 14:28:42 -05:00
Vladimir Diaz
00e3d580e7
Update AUTHORS.txt
2016-02-19 14:23:13 -05:00
Vladimir Diaz
c13ab89447
Merge pull request #315 from vladimir-v-diaz/diplomat_paper
...
Add Diplomat paper
2016-02-19 14:14:26 -05:00