### What does this PR do?
When testing a compiled binary on macOS, it is a special case as there
is validation against the Electron binary before launching.
If you are using `pnpm compile:current`, you should be able to run the
app after launch.
Unfortunatley this requires:
```sh
codesign --force --deep --sign - "dist/mac-arm64/Podman Desktop.app"
```
To be ran.
This adds those instructions to the documentation.
### Screenshot / video of UI
<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->
N/A
### What issues does this PR fix or reference?
<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->
N/A
### How to test this PR?
<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->
1. Be on macOS
2. `pnpm compile:current`
3. Try to launch the binary (`dist/mac-arm64/Podman Desktop.app`)
4. Get error. Close app.
5. `codesign --force --deep --sign - "dist/mac-arm64/Podman
Desktop.app"`
6. No more error when launching.
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Updates the contributing guide to use lint-staged, because:
- it's simpler
- it's faster in many cases. e.g. for this PR on my machine it is one task and a
consistent 17s vs two tasks and 3.5s format + anywhere from 4-42s for lint
- that's what our Husky task does
Fixes#12141.
Signed-off-by: Tim deBoer <git@tdeboer.ca>
The contributing guide has an entry on extensions - but it is out of date, and buried
enough that I didn't find it on my first pass.
This creates a section to add some visibility (too high up? It felt like it should be
before contributing to Podman Desktop itself), along with a bit of text to mention
what you can do with extensions.
Part of #10715.
Signed-off-by: Tim deBoer <git@tdeboer.ca>
* fix: use prettier for checking markdown
Since biome doesn't handle markdown yet, only svelte and code.
Restore the previous config, but skip "prettier-plugin-svelte".
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
### What does this PR do?
Adds documentation on how to use the color registry.
### Screenshot / video of UI
<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->
N/A
### What issues does this PR fix or reference?
<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->
https://github.com/containers/podman-desktop/issues/7576
### How to test this PR?
<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->
Please confirm these are the correct steps.
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
### What does this PR do?
* Remove EXTENSIONS.md in favour of the website
* Improves the extensions page on the website by combining some details
* Improves formatting of the website by putting examples in a different
section.
### Screenshot / video of UI
<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->
N/A, see Netlify preview
### What issues does this PR fix or reference?
<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->
Closes https://github.com/containers/podman-desktop/issues/5344
### How to test this PR?
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* docs: adds website contributing doc
### What does this PR do?
Adds a website contributing doc with some initial information /
templates on how to write documentation so we have some consistency in
writing documentation.
### Screenshot / video of UI
<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->
N/A
### What issues does this PR fix or reference?
<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->
N/A, some small notes I had written while writing website documentation
### How to test this PR?
<!-- Please explain steps to verify the functionality,
do not forget to provide unit/component tests -->
N/A, it's docs
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* another section for standard templates
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
---------
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
### What does this PR do?
Adds more responsibilities / tasks for the triage manager
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast
explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->
Discussed in sprint planning call.
### How to test this PR?
N/A
<!-- Please explain steps to reproduce -->
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
### What does this PR do?
Adds a disclaimer not to enable auto-merge unless a maintainer has
reviewed it.
Gives some feedback that reviews may be fast, but merging may be slow.
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast
explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->
N/A
### How to test this PR?
<!-- Please explain steps to reproduce -->
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* docs: add triage label maintainer documentation
### What does this PR do?
Added documentation on how to triage issues.
### Screenshot/screencast of this PR
N/A
### What issues does this PR fix or reference?
N/A
### How to test this PR?
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Update CONTRIBUTING.md
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Update CONTRIBUTING.md
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
---------
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
### What does this PR do?
Adds a small note that we should test on all three platforms before
merging
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
N/A
### How to test this PR?
<!-- Please explain steps to reproduce -->
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* docs: add documentation on ProviderConnectionStatus, LifeCycle and ProviderStatus
### What does this PR do?
Add documentation detailing the lifecycle and provider status calls
within our API.
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
Closes https://github.com/containers/podman-desktop/issues/2018
### How to test this PR?
<!-- Please explain steps to reproduce -->
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* update based on comments
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* update based on review
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
---------
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
### What does this PR do?
Removes the update documentation that's not really needed anymore as we
test this on our own forked repo.
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
N/A
### How to test this PR?
N/A
<!-- Please explain steps to reproduce -->
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* chore(docs): improve test and code coverage options in Contributing guide
* Include linux debian based GNU C/c++ compiler package installation instruction
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
### What does this PR do?
Adds a small note on binary extensions / compilation for Linux flatpak
support.
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
N/A
### How to test this PR?
<!-- Please explain steps to reproduce -->
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Adds an "update" button on the bottom right that spins when an update
is available
* Podman Desktop will check every 12 hours that it's running for any new
updates
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
### What does this PR do?
Adds missing part for chore description / reorders the section so that
it's similar to the "example" part
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
N/A
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
### How to test this PR?
N/A
<!-- Please explain steps to reproduce -->
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
the namespace was temporary but now that we have external extensions that
should build upon it, make it using a good external name
fixes https://github.com/containers/podman-desktop/issues/1625
Change-Id: I70c7ea1c6a00de791133505366ce9bf47ce11704
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
* docs: information regarding writting tests
### What does this PR do?
* Adds what test frameworks we are using / what we are going to use
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
N/A
### How to test this PR?
<!-- Please explain steps to reproduce -->
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Update CONTRIBUTING.md
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
---------
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
### What does this PR do?
Adds more information on how many reviews need to be done for reviewing
a PR
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
Brought up during F2F
### How to test this PR?
<!-- Please explain steps to reproduce -->
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
### What does this PR do?
Added information on how many approvals is needed for documentation or
coding.
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
N/A
### How to test this PR?
<!-- Please explain steps to reproduce -->
N/A
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* docs: document where code is located within Podman Desktop
### What does this PR do?
Documents what goes go where within Podman Desktop. For example, we use
`extensions` extensively and the `tmpwip` module, but it's not
documented.
This helps for future contributors (and onboarding developers) what code
is located where.
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
N/A
### How to test this PR?
N/A
<!-- Please explain steps to reproduce -->
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Update CONTRIBUTING.md
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* Update CONTRIBUTING.md
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
* docs: update contributing guide
### What does this PR do?
Updates the contributing guide with new styling as well as reorganizing
some sections.
I have also added some tips such as running `yarn test` as well as the
linter and formatter.
### Screenshot/screencast of this PR
<!-- Please include a screenshot or a screencast explaining what is doing this PR -->
N/A
### What issues does this PR fix or reference?
<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->
N/A
### How to test this PR?
<!-- Please explain steps to reproduce -->
See docs :)
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
* docs: update based on review
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
