Elgato_dark/hyperdx
1
0
Fork 0
mirror of https://github.com/hyperdxio/hyperdx synced 2026-04-21 13:37:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix: doesExceedThreshold greater than logic (#408)

Browse source
This commit is contained in:
Warren 2024-05-23 01:13:04 -07:00 committed by GitHub
parent 4176710570
commit 884938a2f4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/late-teachers-greet.md Normal file
View file

@ -0,0 +1,5 @@
---
'@hyperdx/api': patch
---
fix: doesExceedThreshold greater than logic

6
packages/api/src/tasks/__tests__/checkAlerts.test.ts
View file

@ -84,9 +84,11 @@ describe('checkAlerts', () => {
it('doesExceedThreshold', () => {
expect(doesExceedThreshold(true, 10, 11)).toBe(true);
expect(doesExceedThreshold(true, 10, 10)).toBe(true);
expect(doesExceedThreshold(false, 10, 9)).toBe(true);
expect(doesExceedThreshold(true, 10, 10)).toBe(false);
expect(doesExceedThreshold(true, 10, 9)).toBe(false);
expect(doesExceedThreshold(false, 10, 11)).toBe(false);
expect(doesExceedThreshold(false, 10, 10)).toBe(false);
expect(doesExceedThreshold(false, 10, 9)).toBe(true);
});
it('expandToNestedObject', () => {

2
packages/api/src/tasks/checkAlerts.ts
View file

@ -100,7 +100,7 @@ export const doesExceedThreshold = (
threshold: number,
value: number,
) => {
if (isThresholdTypeAbove && value >= threshold) {
if (isThresholdTypeAbove && value > threshold) {
return true;
} else if (!isThresholdTypeAbove && value < threshold) {
return true;