diff --git a/.changeset/late-teachers-greet.md b/.changeset/late-teachers-greet.md new file mode 100644 index 00000000..61e10ca7 --- /dev/null +++ b/.changeset/late-teachers-greet.md @@ -0,0 +1,5 @@ +--- +'@hyperdx/api': patch +--- + +fix: doesExceedThreshold greater than logic diff --git a/packages/api/src/tasks/__tests__/checkAlerts.test.ts b/packages/api/src/tasks/__tests__/checkAlerts.test.ts index a3504c2a..06071d03 100644 --- a/packages/api/src/tasks/__tests__/checkAlerts.test.ts +++ b/packages/api/src/tasks/__tests__/checkAlerts.test.ts @@ -84,9 +84,11 @@ describe('checkAlerts', () => { it('doesExceedThreshold', () => { expect(doesExceedThreshold(true, 10, 11)).toBe(true); - expect(doesExceedThreshold(true, 10, 10)).toBe(true); - expect(doesExceedThreshold(false, 10, 9)).toBe(true); + expect(doesExceedThreshold(true, 10, 10)).toBe(false); + expect(doesExceedThreshold(true, 10, 9)).toBe(false); + expect(doesExceedThreshold(false, 10, 11)).toBe(false); expect(doesExceedThreshold(false, 10, 10)).toBe(false); + expect(doesExceedThreshold(false, 10, 9)).toBe(true); }); it('expandToNestedObject', () => { diff --git a/packages/api/src/tasks/checkAlerts.ts b/packages/api/src/tasks/checkAlerts.ts index 18cb84c2..46b487f2 100644 --- a/packages/api/src/tasks/checkAlerts.ts +++ b/packages/api/src/tasks/checkAlerts.ts @@ -100,7 +100,7 @@ export const doesExceedThreshold = ( threshold: number, value: number, ) => { - if (isThresholdTypeAbove && value >= threshold) { + if (isThresholdTypeAbove && value > threshold) { return true; } else if (!isThresholdTypeAbove && value < threshold) { return true;