fix one more TODO

This commit is contained in:
extrawurst 2022-08-21 15:11:12 +02:00
parent 586acc434d
commit e68e5e2f46
4 changed files with 6 additions and 6 deletions

View file

@ -92,7 +92,7 @@ impl CommitDetailsComponent {
pub fn set_commits(
&mut self,
params: Option<CommitFilesParams>,
tags: Option<CommitTags>,
tags: &Option<CommitTags>,
) -> Result<()> {
if params.is_none() {
self.single_details.set_commit(None, None);
@ -106,7 +106,8 @@ impl CommitDetailsComponent {
self.compare_details
.set_commits(Some((id.id, other)));
} else {
self.single_details.set_commit(Some(id.id), tags);
self.single_details
.set_commit(Some(id.id), tags.clone());
}
if let Some((fetched_id, res)) =

View file

@ -287,7 +287,7 @@ impl CompareCommitsComponent {
fn update(&mut self) -> Result<()> {
self.details.set_commits(
self.get_ids().map(CommitFilesParams::from),
None,
&None,
)?;
self.update_diff()?;

View file

@ -318,10 +318,9 @@ impl InspectCommitComponent {
fn update(&mut self) -> Result<()> {
if let Some(request) = &self.open_request {
//TODO: pass as reference and only clone if details changed
self.details.set_commits(
Some(request.commit_id.into()),
request.tags.clone(),
&request.tags,
)?;
self.update_diff()?;
}

View file

@ -113,7 +113,7 @@ impl Revlog {
self.commit_details.set_commits(
commit.map(CommitFilesParams::from),
tags,
&tags,
)?;
}
}