From e68e5e2f46042665c4744e787c8c0bcd4cc4a535 Mon Sep 17 00:00:00 2001
From: extrawurst <mail@rusticorn.com>
Date: Sun, 21 Aug 2022 15:11:12 +0200
Subject: [PATCH] fix one more TODO

---
 src/components/commit_details/mod.rs | 5 +++--
 src/components/compare_commits.rs    | 2 +-
 src/components/inspect_commit.rs     | 3 +--
 src/tabs/revlog.rs                   | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/components/commit_details/mod.rs b/src/components/commit_details/mod.rs
index 6c57bd38..02781271 100644
--- a/src/components/commit_details/mod.rs
+++ b/src/components/commit_details/mod.rs
@@ -92,7 +92,7 @@ impl CommitDetailsComponent {
 	pub fn set_commits(
 		&mut self,
 		params: Option<CommitFilesParams>,
-		tags: Option<CommitTags>,
+		tags: &Option<CommitTags>,
 	) -> Result<()> {
 		if params.is_none() {
 			self.single_details.set_commit(None, None);
@@ -106,7 +106,8 @@ impl CommitDetailsComponent {
 				self.compare_details
 					.set_commits(Some((id.id, other)));
 			} else {
-				self.single_details.set_commit(Some(id.id), tags);
+				self.single_details
+					.set_commit(Some(id.id), tags.clone());
 			}
 
 			if let Some((fetched_id, res)) =
diff --git a/src/components/compare_commits.rs b/src/components/compare_commits.rs
index 97375ff4..c4048a9d 100644
--- a/src/components/compare_commits.rs
+++ b/src/components/compare_commits.rs
@@ -287,7 +287,7 @@ impl CompareCommitsComponent {
 	fn update(&mut self) -> Result<()> {
 		self.details.set_commits(
 			self.get_ids().map(CommitFilesParams::from),
-			None,
+			&None,
 		)?;
 		self.update_diff()?;
 
diff --git a/src/components/inspect_commit.rs b/src/components/inspect_commit.rs
index c3b1779f..4caa052d 100644
--- a/src/components/inspect_commit.rs
+++ b/src/components/inspect_commit.rs
@@ -318,10 +318,9 @@ impl InspectCommitComponent {
 
 	fn update(&mut self) -> Result<()> {
 		if let Some(request) = &self.open_request {
-			//TODO: pass as reference and only clone if details changed
 			self.details.set_commits(
 				Some(request.commit_id.into()),
-				request.tags.clone(),
+				&request.tags,
 			)?;
 			self.update_diff()?;
 		}
diff --git a/src/tabs/revlog.rs b/src/tabs/revlog.rs
index 47baeff2..9437fc00 100644
--- a/src/tabs/revlog.rs
+++ b/src/tabs/revlog.rs
@@ -113,7 +113,7 @@ impl Revlog {
 
 				self.commit_details.set_commits(
 					commit.map(CommitFilesParams::from),
-					tags,
+					&tags,
 				)?;
 			}
 		}