fleet/server/service
Konstantin Sykulev 46f10b85cd
Improved label(s) validation when running queries (#23834)
Previously when passing labels to the query run endpoints that do not
exist, the labels would simply be ignored. Now the endpoint will return
an error indicating which labels are invalid. This change also affects
the `fleetctl query` command `--labels` flag.

https://github.com/fleetdm/fleet/issues/23015

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Ian Littman <iansltx@gmail.com>
2024-11-21 16:13:30 -06:00
..
async Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
calendar Calendar event body is kept up to date (#20316) 2024-07-29 12:04:40 +02:00
externalsvc remove unused logic specific to DEP+Okta+ROP (#11261) 2023-04-21 14:57:52 -03:00
middleware Remove ineffective rate limit to /api/fleet/device/ping and api/fleet/orbit/ping endpoints (#16334) 2024-01-25 15:05:52 -03:00
mock Update nanomdm dependency with latest bug fixes and improvements. (#23906) 2024-11-20 11:47:11 -06:00
osquery_utils Add team_identifier to macOS software (#23766) 2024-11-15 14:17:04 -03:00
redis_key_value Make software batch endpoint asynchronous (#22258) 2024-09-20 11:55:47 -03:00
redis_lock Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
redis_policy_set Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
schedule feat: initial readme for cron jobs (#23563) 2024-11-06 09:13:45 -05:00
testdata NDES SCEP proxy backend (#22542) 2024-10-09 13:47:27 -05:00
activities.go Add policy ID and name to activity for automated software installs, list Fleet as author rather than installer uploader (#22747) 2024-10-09 18:15:56 -05:00
activities_test.go Activity feed webhooks backend (#19261) 2024-05-24 11:25:27 -05:00
appconfig.go Linux disk encryption: frontend changes, backend missing private key errors, remove disk encryption endpoints dependence on MDM being enabled (#23714) 2024-11-20 11:58:47 -08:00
appconfig_test.go Linux disk encryption: frontend changes, backend missing private key errors, remove disk encryption endpoints dependence on MDM being enabled (#23714) 2024-11-20 11:58:47 -08:00
apple_mdm.go Update nanomdm dependency with latest bug fixes and improvements. (#23906) 2024-11-20 11:47:11 -06:00
apple_mdm_test.go Linux disk encryption: frontend changes, backend missing private key errors, remove disk encryption endpoints dependence on MDM being enabled (#23714) 2024-11-20 11:58:47 -08:00
base_client.go Fixes to fleetctl debug connection and TLS certs documentation (#20166) 2024-07-09 14:04:23 -03:00
base_client_errors.go Finalize MDM commands part 2: implement fleetctl mdm run-command (#10866) 2023-04-03 14:25:49 -04:00
base_client_test.go prevent baseClient from trying to decode 204 responses (#16060) 2024-01-11 17:55:35 -03:00
build_tags_test.go Return 405 when receiving POST request on the route path (#16750) 2024-02-14 12:40:43 -03:00
calendar.go Fix calendar duplicated events and other issues (#20443) 2024-07-24 13:40:33 +02:00
campaigns.go Improved label(s) validation when running queries (#23834) 2024-11-21 16:13:30 -06:00
campaigns_test.go Improved label(s) validation when running queries (#23834) 2024-11-21 16:13:30 -06:00
carves.go Update carve request block id mismatch error code from 500 –> 400 (#17974) 2024-04-04 09:38:10 -07:00
carves_test.go Update carve request block id mismatch error code from 500 –> 400 (#17974) 2024-04-04 09:38:10 -07:00
client.go Merge branch 'main' into feat-include-any-label 2024-11-14 08:33:03 -06:00
client_appconfig.go fleetctl gitops --dry-run now errors on duplicate (or conflicting) global/team enroll secrets. (#19344) 2024-05-31 07:01:13 -05:00
client_carves.go Introduce API version 2022-04, deprecate use of /global in paths (#4731) 2022-04-05 11:35:53 -04:00
client_debug.go Merge conflicts 2024-04-16 10:20:59 -05:00
client_hosts.go 17257 validate bulk ops request filters (#17514) 2024-03-11 10:02:51 -06:00
client_labels.go Improved label(s) validation when running queries (#23834) 2024-11-21 16:13:30 -06:00
client_live_query.go fleetctl, API, copy updates around host identifiers (#20220) 2024-07-09 10:25:01 -07:00
client_live_query_test.go fleetctl, API, copy updates around host identifiers (#20220) 2024-07-09 10:25:01 -07:00
client_mdm.go fix: return error in gitops if using deprecated field and there are more than 1 abm tokens (#23768) 2024-11-13 14:07:59 -05:00
client_mdm_test.go fix fleetctl to set different CmdUID for Windows (#14895) 2023-11-02 15:06:37 -03:00
client_packs.go Add fleetctl upgrade-packs command to migrate 2017 packs to queries (#13078) 2023-08-08 08:21:57 -04:00
client_policies.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
client_profiles.go Unify profiles database identifier to profile_uuid for macOS and Windows profiles. (#15297) 2023-12-04 10:04:06 -05:00
client_queries.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
client_scripts.go SE: CLI setup experience changes (#22956) 2024-10-23 14:51:02 -04:00
client_sessions.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
client_setup.go fleetctl preview to use v1 setup path, to support previous versions of fleet (#5331) 2022-04-25 10:02:21 -03:00
client_software.go Make software batch endpoint asynchronous (#22258) 2024-09-20 11:55:47 -03:00
client_targets.go Add display_name to more results (#8204) 2022-10-14 11:14:18 -03:00
client_teams.go Bugfix and SE: support VPP apps and (install during setup of VPP apps) in gitops for no-team (#23160) 2024-10-28 10:35:57 -04:00
client_test.go GitOps support for NDES SCEP proxy config. (#22918) 2024-10-16 11:12:48 -05:00
client_trigger.go Add fleetctl trigger command (#8877) 2022-12-06 09:56:54 -06:00
client_users.go Return token when creating API-only users (#19525) 2024-06-13 19:10:27 -03:00
cron_schedules.go Implement schedule triggers (#8747) 2022-11-28 13:28:06 -06:00
cron_schedules_test.go Add instanceID to schedule logging (#10413) 2023-03-13 15:37:03 -03:00
debug_handler.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
debug_handler_test.go Add fleetctl debug migrations command to get missing migrations (#2967) 2021-11-22 14:06:12 -03:00
device_client.go Dont send 500 for every call to /debug/errors endpoint (#19827) 2024-06-21 13:12:06 +01:00
device_client_test.go 7766 backmerge main (#14324) 2023-10-05 11:39:48 -06:00
devices.go Add LUKS escrow trigger and orbit config endpoints, persist/retrieve LUKS passphrase (#23763) 2024-11-18 16:44:25 -06:00
devices_test.go Improve LUKS escrow trigger error messages (#24030) 2024-11-21 13:33:37 -06:00
endpoint_campaigns.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
endpoint_middleware.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
endpoint_middleware_test.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
endpoint_setup.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
endpoint_utils.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
endpoint_utils_test.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
frontend.go fix for the enrollment page to not send back a 404 page (#22981) 2024-10-18 11:10:17 +01:00
frontend_test.go fix for the enrollment page to not send back a 404 page (#22981) 2024-10-18 11:10:17 +01:00
full_test.go Return 405 when receiving POST request on the route path (#16750) 2024-02-14 12:40:43 -03:00
global_policies.go Backend build for script automation (#22472) 2024-10-03 20:03:40 -05:00
global_policies_test.go Activity feed webhooks backend (#19261) 2024-05-24 11:25:27 -05:00
global_schedule.go 17745 queries backend (#18582) 2024-05-07 15:43:10 -04:00
global_schedule_test.go Activity feed webhooks backend (#19261) 2024-05-24 11:25:27 -05:00
handler.go remove MDM middleware from 2 endpoints (#23997) 2024-11-20 16:51:00 -08:00
handler_test.go MABM: fix non-integrations skipped tests part 2 (#21805) 2024-09-04 15:17:32 -04:00
hosts.go Add Linux encryption states to APIs (#23806) 2024-11-19 13:11:59 -07:00
hosts_test.go Add Linux encryption states to APIs (#23806) 2024-11-19 13:11:59 -07:00
http_auth.go Remove unused request-id in context (#3632) 2022-01-13 14:12:56 -08:00
http_auth_test.go Activity feed webhooks backend (#19261) 2024-05-24 11:25:27 -05:00
http_publicip.go Log all successful logins as activity and all attempts with ip in stderr. (#9095) 2022-12-21 18:29:51 +01:00
installer.go Add UUID to Fleet errors and clean up error msgs (#10411) 2023-03-13 13:44:06 -03:00
integration_core_test.go Linux disk encryption: frontend changes, backend missing private key errors, remove disk encryption endpoints dependence on MDM being enabled (#23714) 2024-11-20 11:58:47 -08:00
integration_desktop_test.go Adding telemetry for specific Fleet Desktop errors (#23349) 2024-10-31 14:24:42 -05:00
integration_ds_only_test.go Moving Go integration tests to integration test job (#21126) 2024-08-07 14:00:25 +02:00
integration_enterprise_test.go Allow Fleet Premium users to opt out of populating vulnerability details when populating software in the hosts list endpoint (#23710) 2024-11-14 11:09:51 -06:00
integration_live_queries_test.go Improved label(s) validation when running queries (#23834) 2024-11-21 16:13:30 -06:00
integration_logger_test.go Moving Go integration tests to integration test job (#21126) 2024-08-07 14:00:25 +02:00
integration_mdm_ddm_test.go fix: remove declarations that haven't been sent yet (#22993) 2024-10-18 15:16:58 -04:00
integration_mdm_dep_test.go Update nanomdm dependency with latest bug fixes and improvements. (#23906) 2024-11-20 11:47:11 -06:00
integration_mdm_lifecycle_test.go Update nanomdm dependency with latest bug fixes and improvements. (#23906) 2024-11-20 11:47:11 -06:00
integration_mdm_profiles_test.go Fix unreleased bugs with labels_include_any feature (#23734) 2024-11-14 08:30:32 -06:00
integration_mdm_test.go Linux disk encryption: frontend changes, backend missing private key errors, remove disk encryption endpoints dependence on MDM being enabled (#23714) 2024-11-20 11:58:47 -08:00
integration_smtp_test.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
integration_sso_test.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
invites.go Do not return empty SSO and SMTP settings for non-global-admins (#12180) 2023-06-07 16:06:36 -03:00
invites_test.go Add UUID to Fleet errors and clean up error msgs (#10411) 2023-03-13 13:44:06 -03:00
jitter.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
jitter_test.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
labels.go Bugfix: create/update manual label returns outdated info when configured with a mysql replica (#23725) 2024-11-13 08:57:22 -05:00
labels_test.go Bugfix: create/update manual label returns outdated info when configured with a mysql replica (#23725) 2024-11-13 08:57:22 -05:00
linux_mdm.go Add Linux encryption states to APIs (#23806) 2024-11-19 13:11:59 -07:00
linux_mdm_test.go Add Linux encryption states to APIs (#23806) 2024-11-19 13:11:59 -07:00
live_queries.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
mail_test.go fix: reset token team assignments to defaults (#22326) 2024-10-01 10:26:16 -04:00
maintained_apps.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
mdm.go Linux disk encryption: frontend changes, backend missing private key errors, remove disk encryption endpoints dependence on MDM being enabled (#23714) 2024-11-20 11:58:47 -08:00
mdm_scep.go Updating scep package with latest fixes (#22372) 2024-09-27 07:04:11 -05:00
mdm_test.go Add Linux encryption states to APIs (#23806) 2024-11-19 13:11:59 -07:00
mem_failing_policies_set_test.go Fix failing policy sets for redis cluster mode (#3725) 2022-01-17 15:16:54 -05:00
metrics.go
metrics_appconfig.go Fix SMTP e-mail send when SMTP server has credentials (#10758) 2023-03-28 15:23:15 -03:00
metrics_change_email.go
metrics_invites.go
metrics_labels.go add ability to create manual labels (#18303) 2024-04-16 17:22:08 +01:00
metrics_sessions.go add back-end implementation for SSO JIT provisioning (#7182) 2022-08-15 14:42:33 -03:00
metrics_users.go
microsoft_mdm.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
microsoft_mdm_test.go fix: process Add commands in Windows MDM profiles (#17570) 2024-03-12 15:21:17 -04:00
orbit.go Revise LUKS API to expect key slot and salt when escrowing successfully (#23952) 2024-11-20 07:03:02 -06:00
orbit_client.go Linux Key Escrow - Agent (#23771) 2024-11-21 09:31:03 -07:00
orbit_client_test.go Perform early restart before starting sub-systems and minor refactor of orbit sub-systems (#20610) 2024-07-19 12:44:43 -03:00
orbit_test.go Revise LUKS API to expect key slot and salt when escrowing successfully (#23952) 2024-11-20 07:03:02 -06:00
osquery.go Add team_identifier to macOS software (#23766) 2024-11-15 14:17:04 -03:00
osquery_test.go Add team_identifier to macOS software (#23766) 2024-11-15 14:17:04 -03:00
packs.go Activity feed webhooks backend (#19261) 2024-05-24 11:25:27 -05:00
packs_test.go Activity feed webhooks backend (#19261) 2024-05-24 11:25:27 -05:00
queries.go Added server_settings.query_report_cap (#19692) 2024-06-14 12:24:01 -03:00
queries_test.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
scheduled_queries.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
scheduled_queries_test.go Combine Schedules and Queries: API changes (#12778) 2023-07-24 20:17:20 -04:00
scripts.go Delete pending script executions when the underlying script is edited or deleted (#23520) 2024-11-06 18:15:52 -06:00
scripts_test.go Backend build for script automation (#22472) 2024-10-03 20:03:40 -05:00
service.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
service_appconfig.go Do not return empty SSO and SMTP settings for non-global-admins (#12180) 2023-06-07 16:06:36 -03:00
service_appconfig_test.go fix: reset token team assignments to defaults (#22326) 2024-10-01 10:26:16 -04:00
service_campaign_test.go Improvements to go tests in CI (#21545) 2024-08-26 08:55:53 -05:00
service_campaigns.go Add gosimple linter (#23250) 2024-10-29 14:17:51 -05:00
service_errors.go Add UUID to Fleet errors and clean up error msgs (#10411) 2023-03-13 13:44:06 -03:00
service_users.go Activity feed webhooks backend (#19261) 2024-05-24 11:25:27 -05:00
sessions.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
sessions_test.go Activity feed webhooks backend (#19261) 2024-05-24 11:25:27 -05:00
setup_experience.go fix to PUT /setup_experience/software and GET /setup_experience/software endpoints (#23074) 2024-10-23 15:57:02 +01:00
setup_experience_test.go Update backend handlers to record setup experience results (#22911) 2024-10-17 11:48:42 -05:00
software.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
software_installers.go Modify status code for software batch endpoint (#23711) 2024-11-13 17:22:51 -06:00
software_installers_test.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
software_test.go Fixing tests. (#17073) 2024-02-22 16:03:13 -06:00
software_titles.go fix to PUT /setup_experience/software and GET /setup_experience/software endpoints (#23074) 2024-10-23 15:57:02 +01:00
software_titles_test.go fix: add missing software_package field (#18998) 2024-05-15 13:41:35 -04:00
status.go feat: send back forbidden when live queries are disabled (#14804) 2023-10-31 08:58:36 -04:00
targets.go Set interface for response types (#9121) 2022-12-27 11:26:59 -03:00
targets_test.go Refactor license so it is stored in the context (#8544) 2022-11-15 09:08:05 -05:00
team_policies.go Backend build for script automation (#22472) 2024-10-03 20:03:40 -05:00
team_policies_test.go Backend for policy automation to install software (#21650) 2024-08-30 14:13:25 -03:00
team_schedule.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
team_schedule_test.go Activity feed webhooks backend (#19261) 2024-05-24 11:25:27 -05:00
teams.go fix: prevent creating teams with reserved team names (#21727) 2024-09-05 17:44:09 -04:00
teams_test.go Profiles batch activity (#21604) 2024-08-30 16:00:35 -05:00
testing_client.go Improve memory usage of software installers parsing (#23596) 2024-11-12 09:28:08 -05:00
testing_utils.go Linux disk encryption: frontend changes, backend missing private key errors, remove disk encryption endpoints dependence on MDM being enabled (#23714) 2024-11-20 11:58:47 -08:00
translator.go BadRequest when no payloads present; BadRequest for invalid payload types (#18169) 2024-04-10 10:55:38 -07:00
transport.go Allow Fleet Premium users to opt out of populating vulnerability details when populating software in the hosts list endpoint (#23710) 2024-11-14 11:09:51 -06:00
transport_error.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
transport_error_test.go Add UUID to Fleet errors and clean up error msgs (#10411) 2023-03-13 13:44:06 -03:00
transport_setup.go
transport_test.go disable_issues and host issues support for other API endpoints (#19802) 2024-06-18 14:13:38 -05:00
trigger.go Set interface for response types (#9121) 2022-12-27 11:26:59 -03:00
user_roles.go ensure ds.TeamByName returns a 4xx response if no team is found (#12620) 2023-07-13 11:55:05 -03:00
users.go 🧹 friday cleanup party: substitute deprecated import of go-kit (#19774) 2024-06-17 10:27:31 -03:00
users_test.go Updating golangci-lint to 1.61.0 (#22973) 2024-10-18 12:38:26 -05:00
validation_setup.go Use new error handling approach in other packages (#2954) 2021-11-22 09:13:26 -05:00
vpp.go Validate Premium license when uploading VPP tokens (#21720) 2024-09-03 09:39:29 -04:00
vpp_test.go NDES SCEP proxy backend (#22542) 2024-10-09 13:47:27 -05:00
vulnerabilities.go Fix matching typos (#21590) 2024-08-27 21:38:13 -04:00
vulnerabilities_test.go Updated /api/v1/fleet/vulnerabilities/{cve} endpoint (#21463) 2024-08-21 12:52:28 -05:00