mirror of
https://github.com/fleetdm/fleet
synced 2026-04-21 13:37:30 +00:00
10c997b350
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** For #40433 # Details This PR updates `fleetctl gitops` and `fleetctl generate_gitops` to use `unassigned.yml` in place of `no-team.yml`. The two files are utilized identically, except that `unassigned.yml` expects the `name:` to be `Unassigned` rather than `No team`. Internally, we still map some things to the string "no team" before sending to the back end so that we don't have to update back-end code and make more spaghetti to clean up when we 🔪 No Team as a concept in Fleet 5. We do pass the filename into the main `DoGitOps` method, but both I and Claude did our best to determine that it's not used in any way that would break with this change. # Checklist for submitter If some of the following don't apply, delete the relevant line. - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [X] Added/updated automated tests - [X] QA'd all new/changed functionality manually From test plan: - [X] With a pre-existing GitOps folder w/ `no-team.yml`, run `fleetctl gitops -f /path/to/no-team.yml --dry-run --enable-log-topics=deprecated-field-names` and verify that everything works as expected and you get the deprecation warning. - [X] Do the above without `--dry-run` and verify via the UI and/or `fleetctl generate-gitops` that the Fleet config is as expected. - [X] Change `no-team.yml` to `unassigned.yml`, try a gitops run with `fleetctl gitops -f /path/to/unassigned.yml --dry-run --enable-log-topics=deprecated-field-names` and verify that you get an error because the `name:` is still `No team` - [X] Change the `name:` to `Unassigned`, repeat the run above and verify that the output is the same as with `no-team.yml`, and that no deprecation warning is listed. - [X] Do the same as the above without `--dry-run` and verify that the Fleet config is as expected. - [X] Run `fleetctl generate-gitops` and verify that `unassigned.yml` is output rather than `no-team.yml`, and any related files are under the `lib/unassigned` folder rather than `lib/no-team`, and any paths inside `unassigned.yml` (e.g. for scripts) are pointed at `lib/unassigned`. ## New Fleet configuration settings - [X] Verified that the setting is exported via `fleetctl generate-gitops` - [ ] Verified the setting is documented in a separate PR to [the GitOps documentation](https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#L485) @noahtalerman will work on this --------- Co-authored-by: Ian Littman <iansltx@gmail.com> |
||
|---|---|---|
| .. | ||
| .keep | ||
| 14276-post-json-redact-response-body | ||
| 14323-order-by | ||
| 14489-host-transfer-validations | ||
| 25080-show-manage-automations-queries-policies-pages | ||
| 26405-jetbrains | ||
| 29076-vuln-freetier-webhook | ||
| 30670-python-cve | ||
| 30967-disable-calendar-manage-policy-automations-no-team | ||
| 31919-rollback | ||
| 31919-surface-latest-fma-version | ||
| 33427-batch-script-run-deleted-hosts-tooltip | ||
| 33519-url-team-id-param | ||
| 33990-rhel-kernel-vulns | ||
| 34068-software-install-retries | ||
| 34122-remove-stable-scrollbar-gutters | ||
| 34370-vert-padding-ossettings | ||
| 34501-fix-fleetd-escrow-multi-sessions-x11 | ||
| 34620-trim-app-fix | ||
| 34748-tooltip-truncated-host-software-type | ||
| 34990-improve-apns-query-efficiency | ||
| 35044-2-vuln-jobs | ||
| 35528-wrong-title-platform | ||
| 35561-move-textarea-copy-icons | ||
| 35613-android-profiles-pending | ||
| 35659-android-profiles-dont-reverify | ||
| 35805-zero-host-counts | ||
| 36355-activities-max-per_page | ||
| 36361-more-debug-logging-for-ca-profiles | ||
| 36755-add-activity-for-modified-enroll-secrets | ||
| 37182-update-policy-membership-when-labels-change | ||
| 37219-fix | ||
| 37306-fix-certificate-field-truncation | ||
| 37804-filtering-fmas | ||
| 38343-use-custom-icon-display-name-in-setup-experience | ||
| 38351-token-auth | ||
| 38431-enforce-setup-experience-restrictions | ||
| 38514-android-mdm-empty-state | ||
| 38534-fleet-activities-2 | ||
| 38536-new-activity-bc | ||
| 38543-disk-encryption-miscounts | ||
| 38554-populate-idp-host-vitals-android | ||
| 38607-otel-logs | ||
| 38621-add-technician-role | ||
| 38699-ca-cert-country | ||
| 38766-uninstall-android-apps-on-fleet-remove | ||
| 38779-collect-fma-usage | ||
| 38834-update-apple-os-update-time | ||
| 38878-fully-managed-android | ||
| 38889-slog-1 | ||
| 38911-nextcloud-cve | ||
| 38947-handle-renaming-labels-in-gitops | ||
| 38949-policy-automations-stale-data-after-save | ||
| 38955-bulk-team-transfer-cause-long-db-locks | ||
| 39000-ca-bypass-per-policy | ||
| 39048-only-default-if-update-new-hosts-not-explictly-set | ||
| 39083-gitops-label-platform-validation | ||
| 39228-db-failover | ||
| 39260-fix-enroll-secrets-ui | ||
| 39264-entra-tenants | ||
| 39273-filter-button-hover-fix | ||
| 39329-rename-teams-and-queries | ||
| 39344-deprecate-some-api-fields | ||
| 39419-disable-gitops-edit-fma | ||
| 39423-left-align-critical-checkbox-save-policy | ||
| 39437-tarballs-ui-status | ||
| 39522-build-workflow | ||
| 39608-server-worker | ||
| 39613-host-name-not-displayed-hostpage-software-tab | ||
| 39737-dup-kernel | ||
| 39745-notepad-cve | ||
| 39794-alphabetize-host-vitals | ||
| 39858-use-upgrade-code-for-title-matching | ||
| 39871-dep-profile-removed | ||
| 39921-fix-slow-queries-spec-teams | ||
| 40021-ubuntu-python-false-positive | ||
| 40028-otel-client-errors | ||
| 40054-slog-2 | ||
| 40124-add-log-topics | ||
| 40189-update-used-by-heading | ||
| 40433-deprecate-no-team-yml | ||
| 40476-fix-query-results-cleanup-placeholder-limit | ||
| fix-query-results-cleanup-placeholder-limit | ||
| fix-report-creation-timestamps | ||
| host-search-always-match-email | ||
| increase-script-timeout-to-5-hours | ||
| issue-38654-table-wrapping-mdm-card | ||
| issue-39266-update-ui-for-multiple-entra-tenant-ids | ||
| nats-bump | ||
| rds-iam-custom-ca-tls | ||
| rdsmysql-govcloud-certs | ||