Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 09:08:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor: remove unused passed arguments (#4747)

Browse source
This commit is contained in:
Laurin Quast 2024-05-13 15:55:06 +02:00 committed by GitHub
parent 779166927e
commit d7b49c2aea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/services/api/src/modules/schema/providers/schema-manager.ts
View file

@ -1067,8 +1067,6 @@ export class SchemaManager {
]);
const schemaVersion = await this.storage.getVersionBeforeVersionId({
organization: args.organization,
project: args.project,
target: args.target,
beforeVersionId: args.beforeVersionId,
beforeVersionCreatedAt: args.beforeVersionCreatedAt,
@ -1096,8 +1094,6 @@ export class SchemaManager {
beforeVersionCreatedAt: string;
}) {
const schemaVersion = await this.storage.getVersionBeforeVersionId({
organization: args.organization,
project: args.project,
target: args.target,
beforeVersionId: args.beforeVersionId,
beforeVersionCreatedAt: args.beforeVersionCreatedAt,

17
packages/services/api/src/modules/shared/providers/storage.ts
View file

@ -361,22 +361,21 @@ export interface Storage {
valid: boolean;
} | null>;
getLatestValidVersion(_: TargetSelector): Promise<SchemaVersion | never>;
getLatestValidVersion(_: { target: string }): Promise<SchemaVersion | never>;
getMaybeLatestValidVersion(_: TargetSelector): Promise<SchemaVersion | null | never>;
getMaybeLatestValidVersion(_: { target: string }): Promise<SchemaVersion | null | never>;
getLatestVersion(_: TargetSelector): Promise<SchemaVersion | never>;
getMaybeLatestVersion(_: TargetSelector): Promise<SchemaVersion | null>;
/** Find the version before a schema version */
getVersionBeforeVersionId(
_: TargetSelector & {
beforeVersionId: string;
beforeVersionCreatedAt: string;
onlyComposable: boolean;
},
): Promise<SchemaVersion | null>;
getVersionBeforeVersionId(_: {
target: string;
beforeVersionId: string;
beforeVersionCreatedAt: string;
onlyComposable: boolean;
}): Promise<SchemaVersion | null>;
/**
* Find a specific schema version via it's action id.