From d7b49c2aea02ddb23ccdc8d7091fa96bf0aa45a6 Mon Sep 17 00:00:00 2001
From: Laurin Quast <laurinquast@googlemail.com>
Date: Mon, 13 May 2024 15:55:06 +0200
Subject: [PATCH] refactor: remove unused passed arguments (#4747)

---
 .../modules/schema/providers/schema-manager.ts  |  4 ----
 .../api/src/modules/shared/providers/storage.ts | 17 ++++++++---------
 2 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/packages/services/api/src/modules/schema/providers/schema-manager.ts b/packages/services/api/src/modules/schema/providers/schema-manager.ts
index 00b98b859..0e243f989 100644
--- a/packages/services/api/src/modules/schema/providers/schema-manager.ts
+++ b/packages/services/api/src/modules/schema/providers/schema-manager.ts
@@ -1067,8 +1067,6 @@ export class SchemaManager {
     ]);
 
     const schemaVersion = await this.storage.getVersionBeforeVersionId({
-      organization: args.organization,
-      project: args.project,
       target: args.target,
       beforeVersionId: args.beforeVersionId,
       beforeVersionCreatedAt: args.beforeVersionCreatedAt,
@@ -1096,8 +1094,6 @@ export class SchemaManager {
     beforeVersionCreatedAt: string;
   }) {
     const schemaVersion = await this.storage.getVersionBeforeVersionId({
-      organization: args.organization,
-      project: args.project,
       target: args.target,
       beforeVersionId: args.beforeVersionId,
       beforeVersionCreatedAt: args.beforeVersionCreatedAt,
diff --git a/packages/services/api/src/modules/shared/providers/storage.ts b/packages/services/api/src/modules/shared/providers/storage.ts
index 37d4ee611..cac998fca 100644
--- a/packages/services/api/src/modules/shared/providers/storage.ts
+++ b/packages/services/api/src/modules/shared/providers/storage.ts
@@ -361,22 +361,21 @@ export interface Storage {
     valid: boolean;
   } | null>;
 
-  getLatestValidVersion(_: TargetSelector): Promise<SchemaVersion | never>;
+  getLatestValidVersion(_: { target: string }): Promise<SchemaVersion | never>;
 
-  getMaybeLatestValidVersion(_: TargetSelector): Promise<SchemaVersion | null | never>;
+  getMaybeLatestValidVersion(_: { target: string }): Promise<SchemaVersion | null | never>;
 
   getLatestVersion(_: TargetSelector): Promise<SchemaVersion | never>;
 
   getMaybeLatestVersion(_: TargetSelector): Promise<SchemaVersion | null>;
 
   /** Find the version before a schema version */
-  getVersionBeforeVersionId(
-    _: TargetSelector & {
-      beforeVersionId: string;
-      beforeVersionCreatedAt: string;
-      onlyComposable: boolean;
-    },
-  ): Promise<SchemaVersion | null>;
+  getVersionBeforeVersionId(_: {
+    target: string;
+    beforeVersionId: string;
+    beforeVersionCreatedAt: string;
+    onlyComposable: boolean;
+  }): Promise<SchemaVersion | null>;
 
   /**
    * Find a specific schema version via it's action id.