Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 00:58:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Avoid calling redis.del with empty array (#1167)

Browse source
This commit is contained in:
Dotan Simha 2023-01-29 09:52:33 +01:00 committed by GitHub
parent 4ed268c86a
commit 6d2f3d3e07
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/services/tokens/src/cache.ts
View file

@ -60,7 +60,9 @@ function useSafeRedis(redis: Redis, logger: FastifyLoggerInstance) {
}
if (redis.status === 'ready') {
await redis.del(...keys);
if (keys.length > 0) {
await redis.del(...keys);
}
} else {
logger.warn('Redis is not ready, skipping DEL');
}
@ -113,7 +115,9 @@ export function useCache(
async function invalidateTokens(hashedTokens: string[]) {
cacheInvalidations.inc(1);
await redis.del(hashedTokens.map(generateKey));
if (hashedTokens.length > 0) {
await redis.del(hashedTokens.map(generateKey));
}
}
// Thanks to the `atomic` function, every call to this function will only be executed once and Promise will be shared.