From 6d2f3d3e07bebc7d4ba6ce86447ba4d9ee21f9c2 Mon Sep 17 00:00:00 2001 From: Dotan Simha Date: Sun, 29 Jan 2023 09:52:33 +0100 Subject: [PATCH] Avoid calling redis.del with empty array (#1167) --- packages/services/tokens/src/cache.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/services/tokens/src/cache.ts b/packages/services/tokens/src/cache.ts index ad6a98c9e..fa3f55500 100644 --- a/packages/services/tokens/src/cache.ts +++ b/packages/services/tokens/src/cache.ts @@ -60,7 +60,9 @@ function useSafeRedis(redis: Redis, logger: FastifyLoggerInstance) { } if (redis.status === 'ready') { - await redis.del(...keys); + if (keys.length > 0) { + await redis.del(...keys); + } } else { logger.warn('Redis is not ready, skipping DEL'); } @@ -113,7 +115,9 @@ export function useCache( async function invalidateTokens(hashedTokens: string[]) { cacheInvalidations.inc(1); - await redis.del(hashedTokens.map(generateKey)); + if (hashedTokens.length > 0) { + await redis.del(hashedTokens.map(generateKey)); + } } // Thanks to the `atomic` function, every call to this function will only be executed once and Promise will be shared.