Elgato_dark/console
1
0
Fork 0
mirror of https://github.com/graphql-hive/console synced 2026-05-23 17:18:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: avoid n+1 query (#4085)

Browse source
This commit is contained in:
Laurin Quast 2024-02-26 13:40:21 +01:00 committed by GitHub
parent 600433dfde
commit 1ecdd4861c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/services/api/src/modules/schema/providers/schema-version-helper.ts
View file

@ -290,7 +290,7 @@ export class SchemaVersionHelper {
beforeVersionCreatedAt: schemaVersion.createdAt,
});
return !!composableVersion;
return !composableVersion;
}
async getServiceSdlForPreviousVersionService(schemaVersion: SchemaVersion, serviceName: string) {

22
packages/services/storage/src/index.ts
View file

@ -2635,16 +2635,18 @@ export async function createStorage(connection: string, maximumPoolSize: number)
conditionalBreakingChangeMetadata: input.conditionalBreakingChangeMetadata,
});
await Promise.all(
input.logIds.concat(log.id).map(async lid => {
await trx.query(sql`
INSERT INTO schema_version_to_log
(version_id, action_id)
VALUES
(${version.id}, ${lid})
`);
}),
);
await trx.query(sql`
INSERT INTO schema_version_to_log
(version_id, action_id)
SELECT * FROM
${sql.unnest(
input.logIds.concat(log.id).map(actionId =>
// Note: change.criticality.level is actually a computed value from meta
[version.id, actionId],
),
['uuid', 'uuid'],
)}
`);
await insertSchemaVersionChanges(trx, {
versionId: version.id,