diff --git a/packages/services/api/src/modules/schema/providers/schema-version-helper.ts b/packages/services/api/src/modules/schema/providers/schema-version-helper.ts index 656a7b15f..825bc57a4 100644 --- a/packages/services/api/src/modules/schema/providers/schema-version-helper.ts +++ b/packages/services/api/src/modules/schema/providers/schema-version-helper.ts @@ -290,7 +290,7 @@ export class SchemaVersionHelper { beforeVersionCreatedAt: schemaVersion.createdAt, }); - return !!composableVersion; + return !composableVersion; } async getServiceSdlForPreviousVersionService(schemaVersion: SchemaVersion, serviceName: string) { diff --git a/packages/services/storage/src/index.ts b/packages/services/storage/src/index.ts index 1d65518ed..3279b75ce 100644 --- a/packages/services/storage/src/index.ts +++ b/packages/services/storage/src/index.ts @@ -2635,16 +2635,18 @@ export async function createStorage(connection: string, maximumPoolSize: number) conditionalBreakingChangeMetadata: input.conditionalBreakingChangeMetadata, }); - await Promise.all( - input.logIds.concat(log.id).map(async lid => { - await trx.query(sql` - INSERT INTO schema_version_to_log - (version_id, action_id) - VALUES - (${version.id}, ${lid}) - `); - }), - ); + await trx.query(sql` + INSERT INTO schema_version_to_log + (version_id, action_id) + SELECT * FROM + ${sql.unnest( + input.logIds.concat(log.id).map(actionId => + // Note: change.criticality.level is actually a computed value from meta + [version.id, actionId], + ), + ['uuid', 'uuid'], + )} + `); await insertSchemaVersionChanges(trx, { versionId: version.id,