* feat(appset): ignoreDifferences (#9101)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* better error messages
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* do better
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* more tests, update docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* e2e test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* expect auto-added fields
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* correct label
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* better
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove line that was reverted
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Update docs/operator-manual/applicationset.yaml
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove line that mysteriously causes applicationset/utils unit tests to fail
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* login to fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* maybe this will work, who knows
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* burn it all down
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* works on my machine
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore(actions): space instead of hyphen in action name (#14776)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* new field for backwards-compatibility
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* align icons for maximum synergy
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* delete unused function
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* revert unnecessary changes
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Update docs/operator-manual/upgrading/2.7-2.8.md
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix(api): return 404 when the app is not found if a project is specified (#13393)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
simplify, respond 404 on project specified but doesn't match, always fetch app
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
handle project updates
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* handle new endpoint, fix bad merge
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix: trigger refresh on changed ignoreDifferences
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* make the tests mean things
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* feat: values can be either a string or a map
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Allow viewing and editing values
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* fix golang lint
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* fix codegen make build green
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Add special cases for handling nil/empty string. strip newline at end of generated yaml. fix unittests
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Add tests. Fix e2e marshalJSON
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* fix codegen. make codegen and make codegen-local give different results to me
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Update helm_test.go
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Fix UI - validate input
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* change implementation; introduce valuesObject instead of values
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* More generated files. Fix tests
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Fix eslint
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* chore: make codegen
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: use sigs.k8s.io/yaml
In the same vein as #13292, since `github.com/ghodss/yaml` is no longer
maintained.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: compact values
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: make manifests
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: add to helm user guide
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: remove any deprecation mentions
Remove any mentions that `Values` is deprecated, for now.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: make codegen
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* test: add assertion
verify that valuesobject overrides values by checking the number of
replicas.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* test: remove assertion
This wasn't meant to be in there, was a typo.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: minor nit fix
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
---------
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Elias Rieb <e.rieb@posteo.de>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Add support for missingkey=error in ApplicationSets
Signed-off-by: Radon Rosborough <rrosborough@plaid.com>
* options for cluster generator too
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Radon Rosborough <rrosborough@plaid.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Factor out value interpolation
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Pass on useGoTemplate directly
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Add values for git directories & files
Interpolate values in git files generator
Document git generator value interpolation
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Consolidate value interpolation tests
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Enable multiple testcases for SCM provider test
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Add values to SCM provider & document
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Add merge generator example
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Codegen - run to autogen docs & code
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Re-run codegen
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Re-do codegen
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Note about unsupported nested merge
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
---------
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Christoph Girstenbrei <christoph.girstenbrei@retarus.de>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Add support for templates target_branch and target_branch_slug and filter TargetBranchFilter for AppSet PullRequestGenerator
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
* Update PullRequestGenerator documentation
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
* Adjust field number for the new TargetBranchFilter
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
* Add generated api files, Fix e2e failing test
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
---------
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
Signed-off-by: Kevin Huber <kevin.huber@hotmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix: update managed namespace metadata
This commit fixes an issue where a namespace does not get updated
unless a sync is performed. Since the `managedNamespaceMetadata` is not
a part of the Application Git state, we need a way to force a sync once
the metadata has changed. In order to do that, we need to add state
to compare with.
Once a sync is performed, the `ManagedNamespaceMetadata` gets copied
to `SyncResult`, which will then be compared with on subsequent syncs.
If there's a mismatch between
`app.Spec.SyncPolicy.ManagedNamespaceMetadata` and
`app.Status.OperationState.SyncResult.ManagedNamespaceMetadata` we mark
the Application as `OutOfSync`.
Fixes#12661.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: nil check
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: allow empty apps to be updated
If an app is empty but still differs in terms of
`managedNamespaceMetadata`, it should still be kept up to date.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* test: add unit tests in appcontroller
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: rebase
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* refactor: extract method
Consolidate checks to `app.HasChangedManagedNamespaceMetadata()`
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: make codegen
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
---------
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* Add additonal field to set Extra Build Information while building argocd by vendors
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* Include spaces in extra build info
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* Address comments
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
---------
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* feat: Support configuring annotations that are preserved by the AppSet
Signed-off-by: Lawrence Carvalho <lacarvalho91@gmail.com>
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
* Docs
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
* Retrigger CI pipeline
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
---------
Signed-off-by: Lawrence Carvalho <lacarvalho91@gmail.com>
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
* feat: Add support for cloning Google Cloud Source repos (#7534)
* Google Cloud service account auth
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Fill missing struct field (GCP SA key) in cli cmd
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix(ui): Add proxy option when configuring Google Cloud Source repo
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Remove secret (GCP SA key) in Get server req
Signed-off-by: David Becher <becher.david@googlemail.com>
* refactor: Do not use context.WithTimeout for Google creds
As the context is used in the background to refresh credentials, it
should not be cancelled.
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Use proxy setting only in repo-service, not repocreds-service
Signed-off-by: David Becher <becher.david@googlemail.com>
* test: Create tests for GoogleCloudCreds
This commit refactors the implementation of GoogleCloudCreds in order to
make its methods testable.
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Linting issues
Signed-off-by: David Becher <becher.david@googlemail.com>
* chore: Fix typo in docs.
Signed-off-by: David Becher <becher.david@googlemail.com>
* chore: Adjust url-allow-list for lint-docs action
Signed-off-by: David Becher <becher.david@googlemail.com>
* chore: Incorporate suggested refactorings
Signed-off-by: David Becher <becher.david@googlemail.com>
* Delete url-allow-list
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* wrap errors
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* More UI goodies and codegen
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Update docs screenshots
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* move interface up next to other interfaces
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Reduce png size
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* update generated
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* fix whitespace from codegen
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: David Becher <becher.david@googlemail.com>
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Co-authored-by: David Becher <becher.david@googlemail.com>
* feat: parameterized CMPs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* values types for parameters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Add types for CMP announcement
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Reorg
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* finish type
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* First pass at working GetParametersAnnouncement
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Typos
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Make all fields optional
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Make sure response makes it to repo server
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Refactor for testing
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* lint
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* send build env to param announcement gen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* test parameter announcement
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* environ tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Rename workdir to app dir
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle empty command, start ui work (#11)
* Add types for CMP announcement
Signed-off-by: zachaller <zachaller@hotmail.com>
* Reorg
Signed-off-by: zachaller <zachaller@hotmail.com>
* finish type
Signed-off-by: zachaller <zachaller@hotmail.com>
* First pass at working GetParametersAnnouncement
Signed-off-by: zachaller <zachaller@hotmail.com>
* Typos
Signed-off-by: zachaller <zachaller@hotmail.com>
* Make all fields optional
Signed-off-by: zachaller <zachaller@hotmail.com>
* Make sure response makes it to repo server
Signed-off-by: zachaller <zachaller@hotmail.com>
* Refactor for testing
Signed-off-by: zachaller <zachaller@hotmail.com>
* values types for parameters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* lint
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* send build env to param announcement gen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* test parameter announcement
* tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* environ tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Rename workdir to app dir
Signed-off-by: zachaller <zachaller@hotmail.com>
* handle empty command, start ui work
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix order
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix map merging, make params read-only
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Co-authored-by: zachaller <zachaller@hotmail.com>
* Add helm PoC example plugin
Signed-off-by: zachaller <zachaller@hotmail.com>
* example as kustomize overlay
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Parameterized cmps docs (#12)
* use printf instead of echo
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* test for temp dir cleanup
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle empty params
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle empty values
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* consolidate types
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* remove duplicate info
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* add warning about param announcements vs param values
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* tests (#13)
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix types
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix test
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix codegen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix codegen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* revert test hack
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs correction
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix indentation
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix spacing
Signed-off-by: CI <michael@crenshaw.dev>
* move util function to util file and add test
Signed-off-by: CI <michael@crenshaw.dev>
* wrap error
Signed-off-by: CI <michael@crenshaw.dev>
* correct version number
Signed-off-by: CI <michael@crenshaw.dev>
* document necessity of collectionType param
Signed-off-by: CI <michael@crenshaw.dev>
* remove part of error message that's not useful (dir name is now randomized)
Signed-off-by: CI <michael@crenshaw.dev>
* fix things so that they are not broken
Signed-off-by: CI <michael@crenshaw.dev>
* don't close file before caller gets a chance to use it
Signed-off-by: CI <michael@crenshaw.dev>
* codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* comments
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* DON'T PANIC
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: CI <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: zachaller <zachaller@hotmail.com>
* namespace labels
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* create namespace should support annotations
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* handle also modification hook
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* regenerate entity on modify hook
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* manifests
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* feat: enable metadata to be set on namespaces
This builds upon the work that @pasha-codefresh did in #10288.
The main differences between this PR and the previous one is that we use
SSA to diff between different versions of the namespace, as well as
having a slightly different API in gitops-engine for setting the
namespace modifier.
We now also set the ownership of the namespace in ArgoCD.
Closes#4628Closes#6215Closes#7799
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: don't always track namespaces
For now, only allow namespaces managed with `managedNamespaceMetadata`
to have tracking set by Argo. Ideally we'd like new namespaces to also
be tracked by Argo, but there's currently an issue with a failing
integration test.
Also wrap error message if setting the app instance errors on the
namespace.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: always return true with `hasManagedMetadata`
If `hasManagedMetadata` is set, `true` should always be returned.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: add clarifying docs on resource tracking
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* style: pr tweaks
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: re-add label unsetting
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* Update gitops-engine to current master
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Co-authored-by: pashavictorovich <pavel@codefresh.io>
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
This commit adds a new flag, `permitOnlyProjectScopedClusters`, which
prevents any application from syncing to clusters which are not a part
of the same project. Fixes#10220.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* add notifications API
we allow to list triggers, templates and services
Signed-off-by: Pavel <aborilov@gmail.com>
* fix: add notification manifest to tests
Signed-off-by: Pavel <aborilov@gmail.com>
* fix: add sleep to fix integration tests
for some reason notification configmap has old data, trying to fix with
the sleep
Signed-off-by: Pavel <aborilov@gmail.com>
* add proposal
Signed-off-by: Pavel <aborilov@gmail.com>
* more info to proposal
Signed-off-by: Pavel <aborilov@gmail.com>
* use struct for notifications objects instead of just strings
to be able easily extend API in the future return list of
trigger/template/service as list of structs
Signed-off-by: Pavel <aborilov@gmail.com>
Signed-off-by: Pavel <aborilov@gmail.com>
* chore: infer managed resources health from redis instead of storing it in CRD
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* apply reviewer notes
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* fix: avoid k8s API call before authorization in k8s endpoint
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* check for bad project
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* lint
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* more logging
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle 404, return 500 instead of 400 for other errors
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* use user input
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* refactor validation
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fixes, tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix(ui): missing manifests and logs (#9231)
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* feat: make exec feature opt-in
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix codegen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* use create instead of get for exec to match k8s
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* add RBAC instructions for exec
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* delete old line
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* remove unnecessary caveat
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* chore: remove helm2
Reorder test/container/Dockerfile to mitigate issue of being unable to create
.gitconfig since the homedir is not present
chore: cleanup helm2 and tests related to it
Remove helm2 init. Fix unused import
Use helm 3 structure for CRDs
Remove helm2-dependency testdata
Address PR comments
Add back values-production and value.yaml on helm tests
Remove helm2 from openapi.
Signed-off-by: Shyukri Shyukriev <shyukri.shyukriev@mariadb.com>
modified: util/helm/cmd_test.go
* fix: generated openapi
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
* feat: add skipCrds flag for helm charts
* replace additionalTemplateArgs with includeCrds flag
* add testcase for skip crds
Signed-off-by: patst <patrick.steinig@googlemail.com>
* feat: add skipCrds flag for helm charts
* replace additionalTemplateArgs with includeCrds flag
* add testcase for skip crds
Signed-off-by: patst <patrick.steinig@googlemail.com>
* feat: add skipCrds flag for helm charts
* replace additionalTemplateArgs with includeCrds flag
* add testcase for skip crds
Signed-off-by: patst <patrick.steinig@googlemail.com>
* feat: add skipCrds flag for helm charts
* make sure include crds is not added for helm2
Signed-off-by: patst <patrick.steinig@googlemail.com>
so as to allow operators to prevent Argo CD from passing valueFiles
to helm template if they don't exist in the source under the specified path.
Signed-off-by: Oscar Craviotto <craviotto@avellaneda.com>
* feat: add first class support to access repositories using proxy
Currently, users need to set the proxy URLs as env variables in the repo server. This is not user-friendly and also error-prone. This PR adds support to maintain proxy URLs along with repository configs in the argocd-cm. Argo CD uses this proxy to access your repository. In case the custom proxy is absent, it defaults to reading the proxy from the env variables.
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* set both http & https proxy variables
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Currently, the usage of standard lua library is always disabled, making it difficult to implement complex health check scripts.
This feat allow admins to control the usage of standard library by setting "health.lua.useOpenLibs" (merged-keys convention)/"resource.customizations.useOpenLibs.<group_kind>"
(split-keys convention) field in argocd-cm ConfigMap.
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* fix: add helm dependecies with custom CA
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
* fixed go lint error
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
* ignore existing repos
Signed-off-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
* fix: Enable helm OCI to work for lots of different URLs without having to create a repo for each one
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: Enable helm OCI to work for lots of different URLs without having to create a repo for each one
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: lint
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: lint
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: fix test code
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: dependency add for https and oci
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: go.sum and install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: fix checking if repo exits
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: fix generated files
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: fix go.mod and go.sum
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: clean up code
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: rename RepoCreds to HelmRepoCreds
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: Added type for repoCreds.
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: checking in install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: checking in install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: checking in install.yaml
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: Makefile
Signed-off-by: May Zhang <may_zhang@intuit.com>
Co-authored-by: Shubham Agarwal <shubhamagarawal19@gmail.com>
* feat: support background propagation policy
Currently, Argo CD only supports foreground propagation policy ie. delete all the resources in the foreground and then delete the application in the end. This PR introduces a new flag `propagation-policy` to decide the type of policy when cascading is enabled. It also adds an annotation `propagation-policy.argocd.argoproj.io`, which is used by the application controller to decide the order of deletion.
Fixes: #5216
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* fix lint and doc errors
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* update logs to display the application name
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* address review comments
* remove application name from logs since it's already present
* update the propagation policy annotation key
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* Add radio buttons in the UI to select propagation policy
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* inject finalizers instead of annotations for specifying propagation policy
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* rebase branch on master
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* update the controller to set the policy only for application's resources
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* fix the label of policy radio button
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
* feat: get pod logs sequential
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: check in the md file
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: get pod logs
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix conflicts
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: added timeout for test
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: update doc
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: update test
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: add unit test
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: add unit test
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix merge conflict
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: add e2e test
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: clone query
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: rename tail-lines to tail
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix when to send last message status
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: retry on the client side
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: fix lint error
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: if --follow, keep retry
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: added two more flags for CLI
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: added two more flags for CLI
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: added two more flags for CLI
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: added two more flags for CLI
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: error return when there are more than 10 pods to render.
Signed-off-by: May Zhang <may_zhang@intuit.com>
* feat: if podname is present, use the same flow as if query by resource kind
Signed-off-by: May Zhang <may_zhang@intuit.com>
* fix: controller should load application related nodes from target cluster
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* fix: make sure node capasity and pod requests are in same unit, improve unit formatting
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* fix: application hosts should include info about resources requested by app neighbors
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* apply reviewer notes
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
* feat: Add autocomplete for repo Revisions
- Introduces api/v1/repositories/{repo}/refs which returns branches and tags
- Add new RevisionFormField component to Create and Edit Application pages
Signed-off-by: Tim Etchells <tetchell@redhat.com>
* Add "chown" to gpg/keys in "start-local" target that so that repo-server can access gpg keys.
* * Set -u uid:gid in the docker run commands so that test images are run under the current user.
* test Procfile processes will not need to perform "su" to default user (which has the current user's uid/gid)
* Remove chown in start-e2e-local
* clean up, remove "bash -c"
* Test containers are run as uid 0 which allows uid_entrypoint.sh to perform some user setup. uid_entrypoint.sh creates a non-root user (default) and enables passwordless sudo for that user. The container entry point command is run as the non-root user. "goreman start" does "sudo" to to the processes that need root permission including sshd, fcgiwrap, and nginix. The other processes are running as the non-root user.
* use /bin/bash
* change back to sh
* Docker image to create unpriveleged testuser and enable passwordless sudo for that user
* Use kustomize v3 to build ArgoCD manifests
* Update to test-tools-image v0.3.0
* Reorder patches so Kustomize v3 will properly find targets
* adding back these changes
* Use the generated files.
* changed the namespace
* changed kustomize version to 3.8.1 to be in sync with the one in tool-version.sh
* revert changes in makefile
* Re-run codegen
Co-authored-by: Zhang <may_zhang@intuit.com>
Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
This commit adds support for configurable Helm version either via
declarative syntax or via argocd cli.
New helm option 'Version' added to the ApplicationSourceHelm
struct which can be either 'v2' or 'v3'.
Argocd app create accepts '--helm-version' that also looks for the
same Helm versions as above.
* docs: add `namespace` field to cluster secret documentation
This feature for connecting with clusters where you only are (or can) watch a set of namespaces. Also useful when connecting argo with several clusters to avoid having the controller watching every single kind from every single api group from every single cluster.
https://github.com/argoproj/argo-cd/pull/2839
* fix: typo in the cluster namespaces description
