* add lastTransitionTime to health status
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* address first feedback
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* set transition time if health status is unknown
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* extend health improvement tests
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* add apoplication controller test
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* use require for NoError
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* more extensive tests for health state changes
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* Apply suggestions from code review
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Manuel Kieweg <2939765+mkieweg@users.noreply.github.com>
* Code review suggestions
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* remove obsolete assert
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
* Change LastTransitionTime field to pointer type
Due to implementation limitations, setting LastTransitionTime at the resource level is challenging.
Converting it to a pointer type allows it to be skipped at the resource level and prevents it from appearing
in .status.resources of the Application CR. Additionally, it doesn’t provide much value or have a known
use case right now.
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* Resolve rebase conflicts
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* Address review comment
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* Trigger CI
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
---------
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
Signed-off-by: Manuel Kieweg <2939765+mkieweg@users.noreply.github.com>
Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* Adding skipSchemaValidation flag
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
* Adding specific test for skip schema validation
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
* Fix merge conflict
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
* Fixing index.yaml to support helm 3.16
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
---------
Signed-off-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
Co-authored-by: Daniel Mosesson (soandos) <danielmosesson@gmail.com>
* fixed doc comments and added unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Added comments for the newly added unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Refactored method name to deriveServiceAccountToImpersonate
Signed-off-by: anandf <anjoseph@redhat.com>
* Using const name in return value
Signed-off-by: anandf <anjoseph@redhat.com>
* Added unit tests for argocd proj add-destination-service-accounts
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failing e2e tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Fix linting errors
Signed-off-by: anandf <anjoseph@redhat.com>
* Using require package instead of assert and fixed code generation
Signed-off-by: anandf <anjoseph@redhat.com>
* Removed parallel execution of tests for sync with impersonate
Signed-off-by: anandf <anjoseph@redhat.com>
* Added err checks for glob validations
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed e2e tests for sync impersonation
Signed-off-by: anandf <anjoseph@redhat.com>
* Using consistently based expects in E2E tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Added more unit tests and fixed go generate
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failed lint errors, unit and e2e test failures
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed goimports linter issue
Signed-off-by: anandf <anjoseph@redhat.com>
* Added code comments and added few missing unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
* Added missing unit test for GetDestinationServiceAccounts method
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed goimports formatting with local for project_test.go
Signed-off-by: anandf <anjoseph@redhat.com>
* Corrected typo in a field name additionalObjs
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failing unit tests
Signed-off-by: anandf <anjoseph@redhat.com>
---------
Signed-off-by: anandf <anjoseph@redhat.com>
* Implementation of app sync with impersonation support
Signed-off-by: anandf <anjoseph@redhat.com>
* negation test
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
* Update doc comments to remove server name as its not supported.
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Update glob pattern check for matching destinations.
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
* Corrected the code comments for namespace field and destination matching logic
Signed-off-by: anandf <anjoseph@redhat.com>
* Added missing generated files
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed golint errors caused due to to gofumpt validations
Signed-off-by: anandf <anjoseph@redhat.com>
* Fix golint errors with unit test code
Signed-off-by: anandf <anjoseph@redhat.com>
* Updated the go import ordering with local packages at the end
Signed-off-by: anandf <anjoseph@redhat.com>
* Addressed review comments
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed ES lint error caused due to missing class
Signed-off-by: anandf <anjoseph@redhat.com>
* Updated the documentation to address the review comments
Signed-off-by: anandf <anjoseph@redhat.com>
* Simplified the sync code and improved logs and error handling
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed E2E tests to fail when no sa is configured
Signed-off-by: anandf <anjoseph@redhat.com>
* Updated help message generated for CLI commands
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed failing tests due to default service account not used for sync operation
Signed-off-by: anandf <anjoseph@redhat.com>
* Fixed the error message when sync fails due to no matching sa
Signed-off-by: anandf <anjoseph@redhat.com>
* Removed repeating logs and added impersonation fields to logger
Signed-off-by: anandf <anjoseph@redhat.com>
* Made changes in the proposal to match the behaviour when no matching sa is found
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
---------
Signed-off-by: anandf <anjoseph@redhat.com>
Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
Signed-off-by: Anand Francis Joseph <anandfrancis.joseph@gmail.com>
Signed-off-by: Anand Francis Joseph <anjoseph@redhat.com>
Co-authored-by: Mangaal <angommeeteimangaal@gmail.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
* chore(deps): bump k8s libs from 0.29.6 to 0.30.2
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* latest commit
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* update known types
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump controller-runtime to a version that's compatible with go-client 0.30.x
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* update go-to-protobuf flag
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* handle new requirements for proto file locations
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump gitops-engine version
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix openapigen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove toolchain
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump gitops-engine version
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore: enable lint for deprecated symbols
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore: bump to k8s 1.31
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* don't be generic if you don't have to be
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* don't be generic if you don't have to be
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* new commit
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* use gitops-engine commit
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore(deps): bump k8s libs from 0.29.6 to 0.30.2
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* latest commit
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* update known types
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump controller-runtime to a version that's compatible with go-client 0.30.x
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* update go-to-protobuf flag
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* handle new requirements for proto file locations
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump gitops-engine version
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix openapigen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove toolchain
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* bump gitops-engine version
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* no need for replace now
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* feat: collect and log hydration commands
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix tests
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* don't actually log for now
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* add helm test, handle random values file path
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* simplify; only return commands on success; only return helm template command, not helm dependency
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* kustomize test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* only return commands on success, to match Helm
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix import order
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* simplify, since we're not collecting non-template Helm commands
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* lint
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fixes from comments
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* feat(helm): support `--kube-version`, `--api-versions`, and `--namespace` (#19325)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* handle kube and api versions per-source
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* lint
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix nil ref error
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix nil ref error due to not handling multi-source in verify path
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* change casing to be more consistent with helm
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Kustomize too
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* simplify verify path
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* add e2e tests for kustomize
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* reorder for consistency, and add more tests
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Update docs/operator-manual/application.yaml
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
* Fixes https://github.com/argoproj/argo-cd/issues/9607
for BitBucketServer by allowing to pass a CM holding trusted certificates. Refactors implementation for GitLab.
Signed-off-by: asjervanasten <asjer94@live.com>
* Fixes https://github.com/argoproj/argo-cd/issues/9607
for BitBucketServer by allowing to pass a CM holding trusted certificates. Refactors implementation for GitLab.
Signed-off-by: asjervanasten <asjer94@live.com>
* Implemented review feedback. Util class for retrieving Secret and CM, renamed caRef.
Signed-off-by: asjervanasten <asjer94@live.com>
---------
Signed-off-by: asjervanasten <asjer94@live.com>
A bug was reported, where an applicationset with an empty elements
array, when created with `argocd appset create <filename>.yaml` gets a
`...list.elements: Required value` error.
My hypothesis is that when calling the K8s API, golang JSON marshalling
mangles the empty `elements` array to `nil`, rather than creating an
empty array when submitting the `POST`.
Still need to figure out why the same setup seemingly works fine when
the same appset is in an app-of-apps.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* Added application name to badge
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
* Rever svg change
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
* Doc for disabling application name
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
* Flag to not display application name
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
* Added tests
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
* Make no app name the default
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
* Have enable app name as a query parameter
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
* Have enable app name as a query parameter
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
* argocd to original
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
* Update docs/user-guide/status-badge.md
Signed-off-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Dan Garfield <dan@codefresh.io>
---------
Signed-off-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
Signed-off-by: Dan Garfield <dan@codefresh.io>
Co-authored-by: sshenoy6 <sonamkaup_shenoy@intuit.com>
Co-authored-by: Dan Garfield <dan@codefresh.io>
useful for argocd-servers which are not running in AWS and want to add multiple EKS clusters using
separate keys instead of assuming roles
#16766
Signed-off-by: Isaac Gaskin <isaac.gaskin@circle.com>
Co-authored-by: Soumya Ghosh Dastidar <44349253+gdsoumya@users.noreply.github.com>
* feat: support components in kustomize
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* feat: support components in kustomize
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* feat: support components in kustomize
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* feat: support components in kustomize
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* fix: typo in kustomization word
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* fix: typo in kustomization word
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* fix: typo in kustomization word
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* fix: typo in kustomization word
Signed-off-by: pashakostohrys <pavel@codefresh.io>
---------
Signed-off-by: pashakostohrys <pavel@codefresh.io>
* chore(deps): upgrade k8s version and client-go
Signed-off-by: fengshunli <1171313930@qq.com>
* revert bad merge
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix: check for double definition
As found in #13965 (and as a follow-up to #13999), we also need to
define what happens if _both_ managedNamespaceMetadata _and_ an
Application manifest are both defined for the same namespace.
The idea here is that if that happens, we emit an
`ApplicationConditionRepeatedResourceWarning`, and set the sync status
to `Unknown`, since it's unclear what is supposed to happen.
The user will then have the option of removing one of the two
definitions.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: check for double definition
A simpler fix - don't add a managed namespace to the targetObjs list if
a namespace already exists in the application source.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* build: extra space in doc
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* build: extra space in doc, again
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: bump gitops-engine
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
---------
Signed-off-by: fengshunli <1171313930@qq.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: fengshunli <1171313930@qq.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* feat(appset): ignoreDifferences (#9101)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* better error messages
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* do better
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* more tests, update docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* e2e test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* expect auto-added fields
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* correct label
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* better
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove line that was reverted
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Update docs/operator-manual/applicationset.yaml
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* remove line that mysteriously causes applicationset/utils unit tests to fail
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* login to fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* maybe this will work, who knows
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* burn it all down
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* works on my machine
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* chore(actions): space instead of hyphen in action name (#14776)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* new field for backwards-compatibility
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* align icons for maximum synergy
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* delete unused function
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* revert unnecessary changes
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Update docs/operator-manual/upgrading/2.7-2.8.md
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix(api): return 404 when the app is not found if a project is specified (#13393)
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
simplify, respond 404 on project specified but doesn't match, always fetch app
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
handle project updates
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* handle new endpoint, fix bad merge
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* docs
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix: trigger refresh on changed ignoreDifferences
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* make the tests mean things
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Robin Lieb <robin.j.lieb@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* feat: values can be either a string or a map
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Allow viewing and editing values
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* fix golang lint
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* fix codegen make build green
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Add special cases for handling nil/empty string. strip newline at end of generated yaml. fix unittests
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Add tests. Fix e2e marshalJSON
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* fix codegen. make codegen and make codegen-local give different results to me
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Update helm_test.go
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Fix UI - validate input
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* change implementation; introduce valuesObject instead of values
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* More generated files. Fix tests
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Fix eslint
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* chore: make codegen
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: use sigs.k8s.io/yaml
In the same vein as #13292, since `github.com/ghodss/yaml` is no longer
maintained.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: compact values
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: make manifests
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: add to helm user guide
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: remove any deprecation mentions
Remove any mentions that `Values` is deprecated, for now.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: make codegen
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* test: add assertion
verify that valuesobject overrides values by checking the number of
replicas.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* test: remove assertion
This wasn't meant to be in there, was a typo.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: minor nit fix
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
---------
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Elias Rieb <e.rieb@posteo.de>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Add support for missingkey=error in ApplicationSets
Signed-off-by: Radon Rosborough <rrosborough@plaid.com>
* options for cluster generator too
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---------
Signed-off-by: Radon Rosborough <rrosborough@plaid.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Factor out value interpolation
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Pass on useGoTemplate directly
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Add values for git directories & files
Interpolate values in git files generator
Document git generator value interpolation
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Consolidate value interpolation tests
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Enable multiple testcases for SCM provider test
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Add values to SCM provider & document
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Add merge generator example
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Codegen - run to autogen docs & code
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Re-run codegen
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Re-do codegen
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
* Note about unsupported nested merge
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
---------
Signed-off-by: Christoph Girstenbrei <Christoph.Girstenbrei@gmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Christoph Girstenbrei <christoph.girstenbrei@retarus.de>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* Add support for templates target_branch and target_branch_slug and filter TargetBranchFilter for AppSet PullRequestGenerator
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
* Update PullRequestGenerator documentation
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
* Adjust field number for the new TargetBranchFilter
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
* Add generated api files, Fix e2e failing test
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
---------
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
Signed-off-by: Kevin Huber <kevin.huber@hotmail.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix: update managed namespace metadata
This commit fixes an issue where a namespace does not get updated
unless a sync is performed. Since the `managedNamespaceMetadata` is not
a part of the Application Git state, we need a way to force a sync once
the metadata has changed. In order to do that, we need to add state
to compare with.
Once a sync is performed, the `ManagedNamespaceMetadata` gets copied
to `SyncResult`, which will then be compared with on subsequent syncs.
If there's a mismatch between
`app.Spec.SyncPolicy.ManagedNamespaceMetadata` and
`app.Status.OperationState.SyncResult.ManagedNamespaceMetadata` we mark
the Application as `OutOfSync`.
Fixes#12661.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: nil check
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: allow empty apps to be updated
If an app is empty but still differs in terms of
`managedNamespaceMetadata`, it should still be kept up to date.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* test: add unit tests in appcontroller
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: rebase
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* refactor: extract method
Consolidate checks to `app.HasChangedManagedNamespaceMetadata()`
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* chore: make codegen
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
---------
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* Add additonal field to set Extra Build Information while building argocd by vendors
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* Include spaces in extra build info
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* Address comments
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
---------
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
* feat: Support configuring annotations that are preserved by the AppSet
Signed-off-by: Lawrence Carvalho <lacarvalho91@gmail.com>
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
* Docs
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
* Retrigger CI pipeline
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
---------
Signed-off-by: Lawrence Carvalho <lacarvalho91@gmail.com>
Signed-off-by: Lawrence Carvalho <lawrence.carvalho@sky.uk>
* feat: Add support for cloning Google Cloud Source repos (#7534)
* Google Cloud service account auth
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Fill missing struct field (GCP SA key) in cli cmd
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix(ui): Add proxy option when configuring Google Cloud Source repo
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Remove secret (GCP SA key) in Get server req
Signed-off-by: David Becher <becher.david@googlemail.com>
* refactor: Do not use context.WithTimeout for Google creds
As the context is used in the background to refresh credentials, it
should not be cancelled.
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Use proxy setting only in repo-service, not repocreds-service
Signed-off-by: David Becher <becher.david@googlemail.com>
* test: Create tests for GoogleCloudCreds
This commit refactors the implementation of GoogleCloudCreds in order to
make its methods testable.
Signed-off-by: David Becher <becher.david@googlemail.com>
* fix: Linting issues
Signed-off-by: David Becher <becher.david@googlemail.com>
* chore: Fix typo in docs.
Signed-off-by: David Becher <becher.david@googlemail.com>
* chore: Adjust url-allow-list for lint-docs action
Signed-off-by: David Becher <becher.david@googlemail.com>
* chore: Incorporate suggested refactorings
Signed-off-by: David Becher <becher.david@googlemail.com>
* Delete url-allow-list
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* wrap errors
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* More UI goodies and codegen
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Update docs screenshots
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* move interface up next to other interfaces
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* Reduce png size
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* update generated
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
* fix whitespace from codegen
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Signed-off-by: David Becher <becher.david@googlemail.com>
Signed-off-by: Alex Eftimie <alex.eftimie@getyourguide.com>
Co-authored-by: David Becher <becher.david@googlemail.com>
* feat: parameterized CMPs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* values types for parameters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Add types for CMP announcement
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Reorg
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* finish type
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* First pass at working GetParametersAnnouncement
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Typos
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Make all fields optional
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Make sure response makes it to repo server
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Refactor for testing
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* lint
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* send build env to param announcement gen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* test parameter announcement
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* environ tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Rename workdir to app dir
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle empty command, start ui work (#11)
* Add types for CMP announcement
Signed-off-by: zachaller <zachaller@hotmail.com>
* Reorg
Signed-off-by: zachaller <zachaller@hotmail.com>
* finish type
Signed-off-by: zachaller <zachaller@hotmail.com>
* First pass at working GetParametersAnnouncement
Signed-off-by: zachaller <zachaller@hotmail.com>
* Typos
Signed-off-by: zachaller <zachaller@hotmail.com>
* Make all fields optional
Signed-off-by: zachaller <zachaller@hotmail.com>
* Make sure response makes it to repo server
Signed-off-by: zachaller <zachaller@hotmail.com>
* Refactor for testing
Signed-off-by: zachaller <zachaller@hotmail.com>
* values types for parameters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* lint
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* send build env to param announcement gen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* test parameter announcement
* tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* environ tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Rename workdir to app dir
Signed-off-by: zachaller <zachaller@hotmail.com>
* handle empty command, start ui work
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix order
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix map merging, make params read-only
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Co-authored-by: zachaller <zachaller@hotmail.com>
* Add helm PoC example plugin
Signed-off-by: zachaller <zachaller@hotmail.com>
* example as kustomize overlay
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* Parameterized cmps docs (#12)
* use printf instead of echo
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* test for temp dir cleanup
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle empty params
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* handle empty values
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* consolidate types
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* remove duplicate info
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* add warning about param announcements vs param values
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* tests (#13)
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* tests
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix types
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix test
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix codegen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix codegen
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* revert test hack
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* docs correction
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix indentation
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
* fix spacing
Signed-off-by: CI <michael@crenshaw.dev>
* move util function to util file and add test
Signed-off-by: CI <michael@crenshaw.dev>
* wrap error
Signed-off-by: CI <michael@crenshaw.dev>
* correct version number
Signed-off-by: CI <michael@crenshaw.dev>
* document necessity of collectionType param
Signed-off-by: CI <michael@crenshaw.dev>
* remove part of error message that's not useful (dir name is now randomized)
Signed-off-by: CI <michael@crenshaw.dev>
* fix things so that they are not broken
Signed-off-by: CI <michael@crenshaw.dev>
* don't close file before caller gets a chance to use it
Signed-off-by: CI <michael@crenshaw.dev>
* codegen
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* comments
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* fix test
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
* DON'T PANIC
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: CI <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: zachaller <zachaller@hotmail.com>
* namespace labels
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* create namespace should support annotations
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* handle also modification hook
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* regenerate entity on modify hook
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* manifests
Signed-off-by: pashavictorovich <pavel@codefresh.io>
* feat: enable metadata to be set on namespaces
This builds upon the work that @pasha-codefresh did in #10288.
The main differences between this PR and the previous one is that we use
SSA to diff between different versions of the namespace, as well as
having a slightly different API in gitops-engine for setting the
namespace modifier.
We now also set the ownership of the namespace in ArgoCD.
Closes#4628Closes#6215Closes#7799
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: don't always track namespaces
For now, only allow namespaces managed with `managedNamespaceMetadata`
to have tracking set by Argo. Ideally we'd like new namespaces to also
be tracked by Argo, but there's currently an issue with a failing
integration test.
Also wrap error message if setting the app instance errors on the
namespace.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: always return true with `hasManagedMetadata`
If `hasManagedMetadata` is set, `true` should always be returned.
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* docs: add clarifying docs on resource tracking
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* style: pr tweaks
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* fix: re-add label unsetting
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
* Update gitops-engine to current master
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
Co-authored-by: pashavictorovich <pavel@codefresh.io>
Co-authored-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
