Commit graph

31776 commits

Author SHA1 Message Date
Paul Gschwendtner
b98416c00a fix(bazel): allow ng_package to work with rules_js dependencies (#59316)
Currently the module mapping aspect fails when it transitively discovers
a node module target managed by `rules_js`. That is because the targets
don't have a `deps` attribute as part of their rule definition.

PR Close #59316
2024-12-27 14:56:32 +00:00
Kristiyan Kostadinov
dbb8980d03 fix(platform-browser): avoid circular DI error in async renderer (#59271)
In https://github.com/angular/components/pull/30179 the CDK overlay started depending on the `Renderer2Factory`. Since the overlay is used in the `MatSnackbar` which is commonly used in error handlers, `Overlay` can end up being injected as a part of the app initialization. Because `AsyncAnimationRendererFactory` depends on the `ChangeDetectionScheduler`, it may cause a circular dependency.

These changes inject the `ChangeDetectionScheduler` lazily to avoid the error.

Note: this will also be resolved by #58984, but I decided to send it out, because:
1. #58984 seems to be stuck on some internal cleanup.
2. The `AsyncAnimationRendererFactory` doesn't need the `scheduler` eagerly anyway so the change is fairly safe.

Fixes #59255.

PR Close #59271
2024-12-21 08:35:59 -07:00
Jessica Janiuk
c73aee21f3 ci: consolidate pullapprove groups (#59080)
This change was originally proposed by @alxhub. We should all be comfortable reviewing and approving any and all code in the repo. This consolidation removes the barriers for that to happen.

PR Close #59080
2024-12-19 14:38:42 -07:00
Lang
df7af2108a docs: update example code formatting (#59242)
PR Close #59242
2024-12-19 09:00:17 -07:00
Matthieu Riegler
ae68df7d56 docs: fix dynamic template tutorial (#59234)
fixes #59228

PR Close #59234
2024-12-18 13:39:25 -08:00
Andrew Kushnir
22aacba5ca release: cut the v19.0.5 release 2024-12-18 10:57:21 -08:00
m-housni
e0362b2375 docs: fix typo in code example (#59235)
PR Close #59235
2024-12-18 09:37:23 -08:00
Sandeep Chaurasia
bd91f91504 Update defer.md (#59231)
There was an extra Z letter which I think not neccessary.
PR Close #59231
2024-12-18 09:36:21 -08:00
Alan Agius
fd968e80eb refactor(core): reduce generated code (#59220)
This commit updates the defer code promises to reduce a couple of bytes.

PR Close #59220
2024-12-17 14:53:49 -08:00
Avcharov
dd76f4e2e3 docs: Fix Code of Conduct Readme link (#59217)
PR Close #59217
2024-12-17 12:54:20 -08:00
Doug Parker
1b7b8ad33e release: bump Angular DevTools version to 1.0.19 (#59225)
PR Close #59225
2024-12-17 12:46:40 -08:00
Paul Gschwendtner
f1ab35cc36 refactor(compiler-cli): fix instanceof for error not working (#59219)
We recently introduced a custom error to allow us to catch certain types
of errors. Unfortunately it doesn't work as expected in G3 because the
Node execution seems to run with ES5.

PR Close #59219
2024-12-17 09:36:53 -08:00
Angular Robot
ba87e219e9 build: update github/codeql-action action to v3.27.9 (#59212)
See associated pull request for more information.

PR Close #59212
2024-12-17 09:31:19 -08:00
Jessica Janiuk
09ee5b5d5d docs: add anti-patterns and notes about 3rd party scripts (#59210)
Some users are confused by the requirements of hydration around DOM manipulation, and this adds some clarity around those requirements.

PR Close #59210
2024-12-17 09:29:32 -08:00
Paul
c2927ba94c docs(elements): Add limitations section (#58194)
PR Close #58194
2024-12-17 09:28:45 -08:00
Muhammad Awais
c829a1564e docs(animations): update position parameter to be a decimal (#57927)
PR Close #57927
2024-12-17 09:28:03 -08:00
Vlad Boisa
f0df010644 docs(docs-infra): replace newline with <br> (#59156)
Replace the "\n" new line operator with <br> for wrap the text.
PR Close #59156
2024-12-16 16:31:08 -08:00
Angular Robot
b476537ddd build: lock file maintenance (#59202)
See associated pull request for more information.

PR Close #59202
2024-12-16 15:22:39 -08:00
Lang
f582816147 docs: remove unused import from example (#59200)
PR Close #59200
2024-12-16 15:21:24 -08:00
Lang
62703adf13 docs: use arrays in the impure pipe example (#59196)
PR Close #59196
2024-12-16 15:19:47 -08:00
Matthieu Riegler
6807072feb docs(docs-infra): remove costly localeCompare (#59106)
This function wasn't necessary, the items where already sorted.

fixes #59069d

PR Close #59106
2024-12-16 15:18:39 -08:00
Josh Benner
b74e06e150 docs: Fix Dependency Injection Readme guide link (#59193)
PR Close #59193
2024-12-16 11:34:46 -08:00
Alan Agius
ba9bbd07bf refactor(core): add ENABLE_ROOT_COMPONENT_BOOTSTRAP token (#59205)
Introduced the `ENABLE_ROOT_COMPONENT_BOOTSTRAP` token to control the bootstrapping of components during application initialization. This token is utilized by the Angular CLI in the `@angular/ssr` package, particularly during server-side rendering (SSR) when extracting routes.

When set to `false`, this token prevents the root component from being bootstrapped during SSR's route extraction phase, which is crucial for efficiently extracting routes without triggering component initialization. This mechanism separates the concerns of route extraction and component bootstrapping during SSR rendering, optimizing performance.

If not provided or set to `true`, the default behavior of bootstrapping the root component(s) during initialization is maintained.

Context: https://github.com/angular/angular-cli/issues/29085

PR Close #59205
2024-12-16 11:32:46 -08:00
Jessica Janiuk
4d74f86139 refactor(core): add skipped defer blocks count to ngDevMode (#59188)
This adds the skipped defer blocks to the counts in ngDevMode and the logged hydration information.

PR Close #59188
2024-12-16 10:25:45 -08:00
Andrew Kushnir
3793218e77 fix(core): avoid triggering on timer and on idle on the server (#59177)
This commit updates defer block logic to avoid triggering `on idle` and `on timer` on the server for regular SSR mode (when incremental hydration is not enabled). Triggering the mentioned condition resulted in invoking `setTimeout` calls, which delayed serialization on the server during SSR (the process was waiting for the timeouts to clear).

PR Close #59177
2024-12-13 10:10:28 -08:00
Shayan Ghazali
515a1fb8fe docs: correct typo in description of runTask method (#59119)
PR Close #59119
2024-12-13 10:09:41 -08:00
hawkgs
c8b192696e docs(core): remove redundant reference-manifests handwritten entries (#59169)
The handwritten entries are now included as part of `//packages/core:core_docs_extraction` it seems. So, they are no longer needed. On the contrary, they are causing duplicated entries in the generated manifest which are then reflected in the A.dev API reference.

Fixes #59165

PR Close #59169
2024-12-12 17:29:22 -08:00
hawkgs
fa4419d2ae docs(docs-infra): make font styles consistent in the API code ToC (#59072)
Since code lines are wrapped in `<button>`-s, the native font styles overrides the parent's one which results in the font-family and font-size (esp. Safari) difference. This change fixes that.

PR Close #59072
2024-12-12 16:19:46 -08:00
Angular Robot
898e77eb23 build: update babel dependencies (#59127)
See associated pull request for more information.

PR Close #59127
2024-12-12 14:58:35 -08:00
Angular Robot
cc558269f9 build: update dependency https-proxy-agent to v7.0.6 (#59125)
See associated pull request for more information.

PR Close #59125
2024-12-12 14:57:15 -08:00
Jessica Janiuk
cfc96ed82c fix(core): Fix nested timer serialization (#59173)
There were type mismatches and or unintended any types that were preventing nested timers from accessing the delay value during hydration annotation processing.

PR Close #59173
2024-12-12 14:55:29 -08:00
Alan Agius
e21e885fc8 perf(docs-infra): improve app firebase configuration (#59170)
- Remove trailing slash redirect (e.g., /overview no longer redirects to /overview/).
- Update static file matching: Resolves an issue where hashed files were being cached for up to 1 hour.

PR Close #59170
2024-12-12 14:54:51 -08:00
Jessica Janiuk
456fe22ad4 refactor(core): replace regexp in incremental hydration (#59158)
This swaps the regular expression for a string split instead.

PR Close #59158
2024-12-12 14:53:59 -08:00
Jamie Rees
e3bb6a0bb3 refactor(common): update the NgOptimizedImage message to use @if instead of *ngIf (#59131)
This commit updates an error message to mention `@if` rather than the `*ngIf` directive.
PR Close #59131
2024-12-12 14:51:44 -08:00
Jessica Janiuk
c61ad65f64 refactor(core): incremental hydration TODO cleanup (#59032)
This adds a few helper functions and ensures we call complete fns when error state is rendered. It also eliminates serialized views from being copied.

PR Close #59032
2024-12-12 14:48:25 -08:00
kirjs
9085a8fbd8 fix(platform-server): Warn user when transfer state happens more than once (#58935)
This can happen if server providers are provided more than twice. We detect it on the state transfer phase by flagging app id as transferred in a set.

Resolves #58531

PR Close #58935
2024-12-12 14:47:29 -08:00
Enea Jahollari
d8aa201d0b refactor(docs-infra): improve API reference page loading time and drop blocking time (#58911)
By scheduling the focus of the input, we can drop the blocking time that is caused by the blocking task of rendering.

PR Close #58911
2024-12-12 14:45:47 -08:00
Alex Rickabaugh
ec91da095f release: cut the v19.0.4 release 2024-12-12 02:08:53 -08:00
Jessica Janiuk
c3cd2273e2 ci: Update caretaker config for merge queue (#59095)
This updates the caretaker query for merge queue
to remove status: success, since skipped workflows
are considered failed by Github and omitted from
the query results.

PR Close #59095
2024-12-10 13:48:07 -08:00
Jens Kuehlers
d6cccbae82 docs: add approximate v19.x and v20 release dates (#59130)
PR Close #59130
2024-12-10 13:46:17 -08:00
Angular Robot
6d3245ecd6 build: update github/codeql-action action to v3.27.7 (#59126)
See associated pull request for more information.

PR Close #59126
2024-12-10 13:45:35 -08:00
Alan Agius
326337ecba refactor: replace ɵPendingTasks with ɵPendingTasksInternal (#59138)
This commits remove usage of the old export.

PR Close #59138
2024-12-10 13:45:07 -08:00
Rafael Camara
8d7598f776 docs: improve docs on NgModule providers (#59111)
PR Close #59111
2024-12-10 13:44:10 -08:00
Angular Robot
9bf047562c build: lock file maintenance (#59110)
See associated pull request for more information.

PR Close #59110
2024-12-10 13:43:27 -08:00
Matthieu Riegler
241c0004e9 docs: fix mermaid DI diagram. (#59105)
We need to use `<br>` for linebreakes.

fixes #59104

PR Close #59105
2024-12-10 13:42:04 -08:00
Ahmad Shabeer K
5b841fde1d docs(docs-infra): removed confusing extra single quote (#59101)
PR Close #59101
2024-12-10 13:40:39 -08:00
Kristiyan Kostadinov
af3d6c7d19 refactor(docs-infra): fix build-time warnings (#59100)
Fixes a bunch of warnings around an upcoming Sass breaking change https://sass-lang.com/documentation/breaking-changes/mixed-decls/. Also fixes one unused standalone import.

PR Close #59100
2024-12-10 13:40:11 -08:00
Angular Robot
ff03fc8ac0 build: update actions/cache digest to 1bd1e32 (#59077)
See associated pull request for more information.

PR Close #59077
2024-12-06 14:38:28 -08:00
arielbackenroth
34ded10fa6 fix(core): Fix a bug where snapshotted functions are being run twice if they return a nullish/falsey value. (#59073)
Snapshots can return nullish values; don't run the snapshotted function if the snapshotted function returns a nullish/falsey value.

PR Close #59073
2024-12-05 16:16:49 -08:00
Kristiyan Kostadinov
7e61217170 fix(compiler-cli): consider pre-release versions when detecting feature support (#59061)
Fixes that the logic which checks whether a feature is supported didn't account for pre-releases.

Fixes https://github.com/angular/vscode-ng-language-service/issues/2123.

PR Close #59061
2024-12-05 16:15:12 -08:00