Daniel Puckowski
aef166f763
fix(compiler): fix CSS animation rule scope ( #56800 )
...
It is valid CSS to list keyframe names in an animation declaration only
separating the names with a comma and no whitespace. This is typical of
production builds. Updated a couple of regexes and added a couple of
tests to account for this scenario.
Fixes #53038
PR Close #56800
2024-07-09 09:44:56 +02:00
Kristiyan Kostadinov
02f5e73a8d
docs: add documentation page for let declarations ( #56886 )
...
Adds a docs page for the new `@let` syntax in Angular 18.1.
PR Close #56886
2024-07-09 09:38:23 +02:00
Matthieu Riegler
20f5e1291e
docs: add a FAQ on how to find the LCP image ( #56779 )
...
PR Close #56779
2024-07-09 09:37:20 +02:00
Andrew Kushnir
8adc6b9425
test(core): simplify @defer-based test to make CI more stable ( #56904 )
...
This commit updates one of the `@defer`-based test to use the `on immediate` trigger to make a test mor
e stable without the need to add mocks for the `on idle` (default) condition.
PR Close #56904
2024-07-09 09:36:12 +02:00
vladboisa
35fa9b0f77
docs(docs-infra): add missing context with link ( #56896 )
...
Added missing link documenting ng global features.
Fixes #56488
PR Close #56896
2024-07-08 18:04:00 +02:00
Paul Gschwendtner
56ec97d2e1
refactor(compiler-cli): do not truncate/reduce types in API docs ( #56572 )
...
Fixes that e.g. signal input APIs docs were removing `undefined` from
the shorthand `input<T>()` documentation.
PR Close #56572
2024-07-08 16:26:40 +02:00
Matthieu Riegler
ba325c59c0
docs: remove private symbol from docs ( #56851 )
...
fixes #56850
PR Close #56851
2024-07-08 09:54:14 +02:00
Charles Lyding
447a36ef95
refactor(localize): reduce deep imports in ng add schematic ( #56839 )
...
The `@angular/schematic` package has a `utility` export path which can be
used to access common utility rules and helpers. The previous deep imports
into the `@angular/schematic` package have been switched to the actual
export path where possible. This lowers the potential for breakage from
internal package changes.
PR Close #56839
2024-07-08 09:51:53 +02:00
Sasidharan SD
8326e62313
docs: fix previous configuration link ( #56880 )
...
PR Close #56880
2024-07-08 09:48:02 +02:00
cexbrayat
9b35726e42
fix(common): typo in warning for NgOptimizedDirective ( #56817 )
...
The warning message for the `PLACEHOLDER_DIMENSION_LIMIT_EXCEEDED` check has a repetition of `of`.
PR Close #56817
2024-07-05 13:03:56 +02:00
Kristiyan Kostadinov
cdebf751e4
fix(compiler-cli): used before declared diagnostic not firing for control flow blocks ( #56843 )
...
When we process `@if` and `@for` blocks, we create a scope around their expressions in order to encapsulate the aliases to them. The problem is that this doesn't represent the actual structure since the expression is part of the outer scope. This surfaces by not raising the "used before declared" diagnostic for `@let` declarations.
These changes resolve the issue by processing the expression as a part of the parent scope.
Fixes #56842 .
PR Close #56843
2024-07-05 13:02:58 +02:00
Kristiyan Kostadinov
66e582551e
fix(compiler-cli): avoid duplicate diagnostics for let declarations read before definition ( #56843 )
...
Fixes that in some cases `@let` declarations that are read before they're defined were producing multiple diagnostics.
PR Close #56843
2024-07-05 13:02:58 +02:00
Dan Nisenson
1efe907881
docs: fix broken link ( #56848 )
...
fix link @ /guide/forms/reactive-forms#reactive-forms-api-summary
prev: /api/forms
current: /api#forms
PR Close #56848
2024-07-05 12:27:35 +02:00
Corbin Crutchley
1074134d4b
docs: add window title to reference pages ( #56840 )
...
PR Close #56840
2024-07-04 14:29:29 +02:00
Alan Agius
ecc56447b9
perf(http): execute fetch outside of Angular zone ( #56820 )
...
In this update, the fetch backend now executes fetch operations outside of the Angular zone. This adjustment primarily aims to decrease Continuous Delivery (CD) cycles on Node.js. The decision was influenced by Undici, the Node.js fetch implementation, which relies on `setTimeouts` to manage response timeouts.
PR Close #56820
2024-07-04 12:10:35 +02:00
Michael van der Luit
85da4b3b2a
docs: update app-shell docs to reflect v17 ( #56836 )
...
Fixes the build commands as previously mentioned here: https://github.com/angular/angular/pull/52294
PR Close #56836
2024-07-04 11:32:14 +02:00
Harish Krishnan
3fa21cbbc5
docs: Update image-optimization.md ( #56819 )
...
Fix the mistyped attribute rel
PR Close #56819
2024-07-04 09:56:18 +02:00
Matthieu Riegler
1ee64a5c45
refactor(common): Fire priority check on stable. ( #56776 )
...
To support routing on app init, the directive will now fire the priority check when the apps become stable.
fixes #56757
PR Close #56776
2024-07-03 14:40:48 +00:00
Andrew Kushnir
3235d6d6dd
fix(core): establish proper defer injector hierarchy for components attached to ApplicationRef ( #56763 )
...
This commit updates the logic that create an injector for defer blocks (when it's needed) to account for a situation when a component is instantiated without a connection to the current component tree. This can happen if a component is created using its factory function or via `createComponent()` call.
Resolves #56372 .
PR Close #56763
2024-07-03 14:08:44 +00:00
Krishna Sahu
6ad2fe6ab0
docs: add toSignal import inside the demo example ( #56804 )
...
PR Close #56804
2024-07-03 14:07:51 +00:00
komura-c
0e0fb7bb61
docs: fix missing image and baseUrl in tutorials/first-app ( #56766 )
...
PR Close #56766
2024-07-02 20:21:41 +00:00
Andrew Kushnir
8a0a00e212
docs: add Event Replay section to the Hydration guide ( #56770 )
...
PR Close #56770
2024-07-02 20:19:53 +00:00
Matthieu Riegler
092bfe95cc
fix(core): support injection of object with null constructor. ( #56553 )
...
This is debug only code, it shouldn't have any consequences on prod build.
fixes #56552
PR Close #56553
2024-07-02 17:33:32 +00:00
Andrew Scott
c4384bf269
fix(router): routes should not get stale providers ( #56798 )
...
This fixes a bug with RouterOutlet and its context where it would reuse
providers from a previously activated route.
fixes #56774
PR Close #56798
2024-07-02 17:10:52 +00:00
Angular Robot
52852abb56
build: update github/codeql-action action to v3.25.11 ( #56803 )
...
See associated pull request for more information.
PR Close #56803
2024-07-02 13:04:27 -04:00
Ben Hong
0f612dcaf8
docs: update playground app to use hello world for easier onboarding ( #56813 )
...
PR Close #56813
2024-07-02 12:57:31 -04:00
Ben Elliott
9acccb11ff
docs: Update interceptors.md to replace public class with export class in DI section ( #56807 )
...
PR Close #56807
2024-07-02 16:44:12 +00:00
Ben Hong
e914767efb
docs: add documentation aroun build error for docs ( #56814 )
...
PR Close #56814
2024-07-02 16:43:07 +00:00
Angular Robot
58be8e6bf8
build: update all non-major dependencies ( #56801 )
...
See associated pull request for more information.
PR Close #56801
2024-07-02 15:26:28 +00:00
Pawel Kozlowski
9cc4dbeadd
refactor(common): remove remaining code for NgSwitch equality patch ( #56806 )
...
This change is the final cleanup after removing NgSwitch's equality patch
that was used in G3 to allow == matching for a certain period of time. This
code is no longer needed as both the external ecosystem and G3 are using
=== equality for matching NgSwitch cases.
PR Close #56806
2024-07-02 14:16:24 +00:00
Jessica Janiuk
7f5d70a74a
release: cut the v18.1.0-rc.0 release
2024-07-01 14:01:57 -07:00
Thomas Nguyen
3d1bc5a51e
refactor(core): Add an ngOnDestroy to GlobalEventDelegation. ( #56762 )
...
It seems that this makes test libs that contain > 1 test file pass.
PR Close #56762
2024-07-01 20:33:17 +00:00
Enea Jahollari
fd6cd0422d
feat(compiler): Add extended diagnostic to warn when there are uncalled functions in event bindings ( #56295 )
...
The diagnostic will catch issues like:
```html
<button (click)="increment"></button>
<button (click)="increment; decrement"></button>
<button (click)="true ? increment : decrement"></button>
<button (click)="nested.nested1.nested2.increment"></button>
```
PR Close #56295
2024-07-01 20:31:19 +00:00
Andrew Kushnir
a0fbd0e5e1
docs: update 18.1.0 release date ( #56789 )
...
PR Close #56789
2024-07-01 19:37:33 +00:00
Joey Perrott
b4cc8d4a8e
ci: upload build artifacts on each pr run ( #56787 )
...
Upload the snapshot build artifacts to each pr run to use for testing.
PR Close #56787
2024-07-01 18:48:57 +00:00
Matthieu Riegler
f407e3ce6f
refactor(common): allow string urls in NgOptimizedImage input ( #54901 )
...
With this commit it is now possible to pass an url as placeholder for the image directive.
PR Close #54901
2024-07-01 18:13:24 +00:00
Kristiyan Kostadinov
341a116d61
fix(compiler): allow more characters in let declaration name ( #56764 )
...
Fixes that `@let` didn't allow $ in its name, even though JS identifiers allow it.
PR Close #56764
2024-07-01 18:12:53 +00:00
Thomas Nguyen
551027e04e
refactor(core): Set the jsaction cache directly instead of using jsaction attribute. ( #56747 )
...
This should make things somewhat faster, since setAttribute can be slower than addEventListener. Jsaction attribute is still needed for SSR though.
PR Close #56747
2024-07-01 17:31:24 +00:00
Alex Rickabaugh
46b0292261
refactor(core): export additional methods from primitives/signals ( #56759 )
...
Export `producerIncrementEpoch` which was missing before, as well as a new
`runPostSignalSetFn` helper. These changes make it easier to write `signal`-
like utilities which don't use the `createSignal` abstraction.
PR Close #56759
2024-07-01 14:39:44 +00:00
Kristiyan Kostadinov
2a1291e942
fix(compiler): give precedence to local let declarations over parent ones ( #56752 )
...
Currently the logic that maps a name to a variable looks at the variables in their definition order. This means that `@let` declarations from parent views will always come before local ones, because the local ones are declared inline whereas the parent ones are hoisted to the top of the function.
These changes resolve the issue by giving precedence to the local variables.
Fixes #56737 .
PR Close #56752
2024-07-01 14:03:57 +00:00
Kristiyan Kostadinov
4d18c5bfd5
fix(compiler-cli): flag all conflicts between let declarations and local symbols ( #56752 )
...
Expands the check around conflicting `@let` declarations to also cover template variables and local references.
PR Close #56752
2024-07-01 14:03:57 +00:00
Kristiyan Kostadinov
5996502921
fix(compiler-cli): type check let declarations nested inside nodes ( #56752 )
...
Fixes that we were only capturing `@let` declarations at the top level of the scope, not any of the nested children.
PR Close #56752
2024-07-01 14:03:57 +00:00
Harish Krishnan
aad3c2da6e
docs: Update structural-directives.md ( #56753 )
...
PR Close #56753
2024-07-01 14:03:24 +00:00
Harish Krishnan
4017f72e8c
docs: Update rxjs-interop.md ( #56771 )
...
Fix grammatical error
PR Close #56771
2024-07-01 14:02:46 +00:00
Kristiyan Kostadinov
5dc6deca85
build: update docs infra package ( #56758 )
...
Updates to the latest docs infra code to fix an issue with generating the `hiddenFiles` field.
PR Close #56758
2024-07-01 13:43:10 +00:00
Jessica Janiuk
ecd5e6b754
ci: update pullapprove primitives list ( #56761 )
...
This removes one user from the shared primitives group to fix pullapprove requests.
PR Close #56761
2024-06-28 21:07:59 +00:00
cexbrayat
f25653e231
fix(common): typo in NgOptimizedImage warning ( #56756 )
...
A space is missing in the warning message for `TOO_MANY_PRIORITY_ATTRIBUTES`.
PR Close #56756
2024-06-28 18:38:25 +00:00
Kristiyan Kostadinov
ceaaa9815b
build: update to latest docs tooling to resolve missing answers ( #56746 )
...
Updates to the latest version of `@angular/docs` which should include a fix for the missing answers in the tutorials.
PR Close #56746
2024-06-27 21:17:38 +00:00
Andrew Scott
ed2665a74d
docs: fix indentation on control flow documentation page ( #56748 )
...
This fixes the indentation on the examples in the control flow docs
fixes #56745
PR Close #56748
2024-06-27 19:55:48 +00:00
Tom Wilkinson
040d86137e
refactor(core): Remove dom.ts and use native Element.prototype.contains. ( #56591 )
...
Delete the entire dom.ts file, it is no longer needed.
PR Close #56591
2024-06-27 18:28:19 +00:00