Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(devtools): remove date utility. (#53997)

Browse source 
We can use the `toIsoString()` function instead !

PR Close #53997
This commit is contained in:
Matthieu Riegler 2024-01-19 21:01:59 +01:00 committed by Pawel Kozlowski
parent 3e35f7415e
commit ff5575ad0b
5 changed files with 2 additions and 66 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/BUILD.bazel
View file

@ -35,7 +35,6 @@ ng_module(
] + _STYLE_LABELS,
deps = [
"//devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/timeline",
"//devtools/projects/ng-devtools/src/lib/vendor/chromium",
"//devtools/projects/protocol",
"//packages/common",
"//packages/core",

5
devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/file-api-service.ts
View file

@ -9,8 +9,6 @@
import {Injectable} from '@angular/core';
import {Subject} from 'rxjs';
import {toISO8601Compact} from '../../vendor/chromium/date-utilities';
@Injectable({
providedIn: 'root',
})
@ -32,7 +30,8 @@ export class FileApiService {
saveObjectAsJSON(object: object): void {
const downloadLink = document.createElement('a');
downloadLink.download = `NgDevTools-Profile-${toISO8601Compact(new Date())}.json`;
const isoString = new Date().toISOString().slice(0, -5); // remove milliseconds
downloadLink.download = `NgDevTools-Profile-${isoString}.json`;
downloadLink.href = URL.createObjectURL(
new Blob([JSON.stringify(object)], {type: 'application/json'}),
);

8
devtools/projects/ng-devtools/src/lib/vendor/chromium/BUILD.bazel vendored
View file

@ -1,8 +0,0 @@
load("//devtools/tools:typescript.bzl", "ts_library")
package(default_visibility = ["//:__subpackages__"])
ts_library(
name = "chromium",
srcs = ["date-utilities.ts"],
)

27
devtools/projects/ng-devtools/src/lib/vendor/chromium/LICENSE vendored
View file

@ -1,27 +0,0 @@
// Copyright 2014 The Chromium Authors. All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

27
devtools/projects/ng-devtools/src/lib/vendor/chromium/date-utilities.ts vendored
View file

@ -1,27 +0,0 @@
// Copyright (c) 2020 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
/*
* @param date to convert to a compact ISO8601 format
* @return date in a compact ISO8601 format
*/
export const toISO8601Compact = (date: Date): string => {
/*
* @param x an integer to append a leading 0 to if less than 9
* @return x with a leading 0 appended if less than 9
*/
function leadZero(x: number): string {
return (x > 9 ? '' : '0') + x;
}
return (
date.getFullYear() +
leadZero(date.getMonth() + 1) +
leadZero(date.getDate()) +
'T' +
leadZero(date.getHours()) +
leadZero(date.getMinutes()) +
leadZero(date.getSeconds())
);
};