From ff5575ad0b2e2be8974c5576b2c64bb16c53c8aa Mon Sep 17 00:00:00 2001 From: Matthieu Riegler Date: Fri, 19 Jan 2024 21:01:59 +0100 Subject: [PATCH] refactor(devtools): remove date utility. (#53997) We can use the `toIsoString()` function instead ! PR Close #53997 --- .../lib/devtools-tabs/profiler/BUILD.bazel | 1 - .../profiler/file-api-service.ts | 5 ++-- .../src/lib/vendor/chromium/BUILD.bazel | 8 ------ .../src/lib/vendor/chromium/LICENSE | 27 ------------------- .../src/lib/vendor/chromium/date-utilities.ts | 27 ------------------- 5 files changed, 2 insertions(+), 66 deletions(-) delete mode 100644 devtools/projects/ng-devtools/src/lib/vendor/chromium/BUILD.bazel delete mode 100644 devtools/projects/ng-devtools/src/lib/vendor/chromium/LICENSE delete mode 100644 devtools/projects/ng-devtools/src/lib/vendor/chromium/date-utilities.ts diff --git a/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/BUILD.bazel b/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/BUILD.bazel index 43fcf11dd79..631ea974074 100644 --- a/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/BUILD.bazel +++ b/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/BUILD.bazel @@ -35,7 +35,6 @@ ng_module( ] + _STYLE_LABELS, deps = [ "//devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/timeline", - "//devtools/projects/ng-devtools/src/lib/vendor/chromium", "//devtools/projects/protocol", "//packages/common", "//packages/core", diff --git a/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/file-api-service.ts b/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/file-api-service.ts index ada27aaeb6e..f3845fe30f0 100644 --- a/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/file-api-service.ts +++ b/devtools/projects/ng-devtools/src/lib/devtools-tabs/profiler/file-api-service.ts @@ -9,8 +9,6 @@ import {Injectable} from '@angular/core'; import {Subject} from 'rxjs'; -import {toISO8601Compact} from '../../vendor/chromium/date-utilities'; - @Injectable({ providedIn: 'root', }) @@ -32,7 +30,8 @@ export class FileApiService { saveObjectAsJSON(object: object): void { const downloadLink = document.createElement('a'); - downloadLink.download = `NgDevTools-Profile-${toISO8601Compact(new Date())}.json`; + const isoString = new Date().toISOString().slice(0, -5); // remove milliseconds + downloadLink.download = `NgDevTools-Profile-${isoString}.json`; downloadLink.href = URL.createObjectURL( new Blob([JSON.stringify(object)], {type: 'application/json'}), ); diff --git a/devtools/projects/ng-devtools/src/lib/vendor/chromium/BUILD.bazel b/devtools/projects/ng-devtools/src/lib/vendor/chromium/BUILD.bazel deleted file mode 100644 index 51eeef9c73e..00000000000 --- a/devtools/projects/ng-devtools/src/lib/vendor/chromium/BUILD.bazel +++ /dev/null @@ -1,8 +0,0 @@ -load("//devtools/tools:typescript.bzl", "ts_library") - -package(default_visibility = ["//:__subpackages__"]) - -ts_library( - name = "chromium", - srcs = ["date-utilities.ts"], -) diff --git a/devtools/projects/ng-devtools/src/lib/vendor/chromium/LICENSE b/devtools/projects/ng-devtools/src/lib/vendor/chromium/LICENSE deleted file mode 100644 index 972bb2edb09..00000000000 --- a/devtools/projects/ng-devtools/src/lib/vendor/chromium/LICENSE +++ /dev/null @@ -1,27 +0,0 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. -// -// Redistribution and use in source and binary forms, with or without -// modification, are permitted provided that the following conditions are -// met: -// -// * Redistributions of source code must retain the above copyright -// notice, this list of conditions and the following disclaimer. -// * Redistributions in binary form must reproduce the above -// copyright notice, this list of conditions and the following disclaimer -// in the documentation and/or other materials provided with the -// distribution. -// * Neither the name of Google Inc. nor the names of its -// contributors may be used to endorse or promote products derived from -// this software without specific prior written permission. -// -// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT -// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. diff --git a/devtools/projects/ng-devtools/src/lib/vendor/chromium/date-utilities.ts b/devtools/projects/ng-devtools/src/lib/vendor/chromium/date-utilities.ts deleted file mode 100644 index e6dfb2b0c27..00000000000 --- a/devtools/projects/ng-devtools/src/lib/vendor/chromium/date-utilities.ts +++ /dev/null @@ -1,27 +0,0 @@ -// Copyright (c) 2020 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -/* - * @param date to convert to a compact ISO8601 format - * @return date in a compact ISO8601 format - */ -export const toISO8601Compact = (date: Date): string => { - /* - * @param x an integer to append a leading 0 to if less than 9 - * @return x with a leading 0 appended if less than 9 - */ - function leadZero(x: number): string { - return (x > 9 ? '' : '0') + x; - } - - return ( - date.getFullYear() + - leadZero(date.getMonth() + 1) + - leadZero(date.getDate()) + - 'T' + - leadZero(date.getHours()) + - leadZero(date.getMinutes()) + - leadZero(date.getSeconds()) - ); -};