Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

docs(docs-infra): quote title attributes in links (#63578)

Browse source 
Prevent broken HTML when link titles contain spaces by properly quoting the title attribute

PR Close #63578
This commit is contained in:
Shuaib Hasan Akib 2025-09-04 01:51:29 +06:00 committed by Andrew Scott
parent f18980c18d
commit f2ec6fbfa7
3 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
adev/shared-docs/pipeline/shared/marked/test/link/link.md
View file

@ -1,3 +1,4 @@
[Angular Site](https://angular.dev)
[same page](#test)
[same site](../other/page)
[same site](../other/page)
[npm packages](https://docs.npmjs.com/getting-started/what-is-npm "What is npm?")

6
adev/shared-docs/pipeline/shared/marked/test/link/link.spec.mts
View file

@ -31,4 +31,10 @@ describe('markdown to html', () => {
it('should render internal links that are relative paths', () => {
expect(parsedMarkdown).toContain('<a href="../other/page">same site</a>');
});
it('should render links with title attributes properly quoted', () => {
expect(parsedMarkdown).toContain(
'<a href="https://docs.npmjs.com/getting-started/what-is-npm" title="What is npm?" target="_blank">npm packages</a>',
);
});
});

2
adev/shared-docs/pipeline/shared/marked/transformations/link.mts
View file

@ -24,6 +24,6 @@ export function linkRender(this: Renderer, {href, title, tokens}: Tokens.Link) {
return this.parser.parseInline(tokens);
}
const titleAttribute = title ? ` title=${title}` : '';
const titleAttribute = title ? ` title="${title}"` : '';
return `<a href="${href}"${titleAttribute}${anchorTarget(href)}>${this.parser.parseInline(tokens)}</a>`;
}