Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(docs-infra): remove redundant overrides in FakeWebContainer (#60581)

Browse source 
This is required to fix
```
adev/shared-docs/testing/testing-helper.ts💯12 - error TS2416: Property 'on' in type 'FakeWebContainer' is not assignable to the same property in base type 'WebContainer'.
  Type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; }' is not assignable to type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "xdg-open", listener: OpenListener): Unsubscribe; (ev...'.
    Types of parameters 'event' and 'event' are incompatible.
      Type '"xdg-open"' is not assignable to type '"port"'.

100   override on(event: 'server-ready', listener: ServerReadyListener): Unsubscribe;
               ~~
```

See: https://github.com/angular/angular/actions/runs/14098789522/job/39491059550?pr=60526

PR Close #60581
This commit is contained in:
Alan Agius 2025-03-27 09:03:31 +00:00 committed by Jessica Janiuk
parent b938f0ce94
commit d4e73f0fd8
1 changed files with 9 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
adev/shared-docs/testing/testing-helper.ts
View file

@ -85,33 +85,29 @@ export class FakeWebContainer extends WebContainer {
if (fakeOptions?.spawn) this.fakeSpawn = fakeOptions.spawn;
}
override spawn(
override async spawn(
command: unknown,
args?: unknown,
options?: unknown,
): Promise<FakeWebContainerProcess> {
if (this.fakeSpawn) return Promise.resolve(this.fakeSpawn);
if (this.fakeSpawn) return this.fakeSpawn;
const fakeProcess = new FakeWebContainerProcess();
return Promise.resolve(fakeProcess);
return new FakeWebContainerProcess();
}
override on(event: 'port', listener: PortListener): Unsubscribe;
override on(event: 'server-ready', listener: ServerReadyListener): Unsubscribe;
override on(event: 'error', listener: ErrorListener): Unsubscribe;
override on(event: 'preview-message', listener: PreviewMessageListener): Unsubscribe;
override on(event: unknown, listener: unknown): Unsubscribe {
return () => {};
}
override mount(
override async mount(
tree: FileSystemTree,
options?: {mountPoint?: string | undefined} | undefined,
): Promise<void> {
return Promise.resolve();
}
): Promise<void> {}
override get path() {
return '/fake-path';
}
override get workdir() {
return '/fake-workdir';
}