From d4e73f0fd825eec3684d53dde0c2e817ef028675 Mon Sep 17 00:00:00 2001
From: Alan Agius <17563226+alan-agius4@users.noreply.github.com>
Date: Thu, 27 Mar 2025 09:03:31 +0000
Subject: [PATCH] refactor(docs-infra): remove redundant overrides in
 `FakeWebContainer` (#60581)

This is required to fix
```
adev/shared-docs/testing/testing-helper.ts:100:12 - error TS2416: Property 'on' in type 'FakeWebContainer' is not assignable to the same property in base type 'WebContainer'.
  Type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; }' is not assignable to type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "xdg-open", listener: OpenListener): Unsubscribe; (ev...'.
    Types of parameters 'event' and 'event' are incompatible.
      Type '"xdg-open"' is not assignable to type '"port"'.

100   override on(event: 'server-ready', listener: ServerReadyListener): Unsubscribe;
               ~~
```

See: https://github.com/angular/angular/actions/runs/14098789522/job/39491059550?pr=60526

PR Close #60581
---
 adev/shared-docs/testing/testing-helper.ts | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)

diff --git a/adev/shared-docs/testing/testing-helper.ts b/adev/shared-docs/testing/testing-helper.ts
index 9e57552b069..eef8824f7fa 100644
--- a/adev/shared-docs/testing/testing-helper.ts
+++ b/adev/shared-docs/testing/testing-helper.ts
@@ -85,33 +85,29 @@ export class FakeWebContainer extends WebContainer {
     if (fakeOptions?.spawn) this.fakeSpawn = fakeOptions.spawn;
   }
 
-  override spawn(
+  override async spawn(
     command: unknown,
     args?: unknown,
     options?: unknown,
   ): Promise<FakeWebContainerProcess> {
-    if (this.fakeSpawn) return Promise.resolve(this.fakeSpawn);
+    if (this.fakeSpawn) return this.fakeSpawn;
 
-    const fakeProcess = new FakeWebContainerProcess();
-
-    return Promise.resolve(fakeProcess);
+    return new FakeWebContainerProcess();
   }
-  override on(event: 'port', listener: PortListener): Unsubscribe;
-  override on(event: 'server-ready', listener: ServerReadyListener): Unsubscribe;
-  override on(event: 'error', listener: ErrorListener): Unsubscribe;
-  override on(event: 'preview-message', listener: PreviewMessageListener): Unsubscribe;
+
   override on(event: unknown, listener: unknown): Unsubscribe {
     return () => {};
   }
-  override mount(
+
+  override async mount(
     tree: FileSystemTree,
     options?: {mountPoint?: string | undefined} | undefined,
-  ): Promise<void> {
-    return Promise.resolve();
-  }
+  ): Promise<void> {}
+
   override get path() {
     return '/fake-path';
   }
+
   override get workdir() {
     return '/fake-workdir';
   }