build(devtools): fix issue where esbuild configs were not being set properly in DevTools (#48762)

Previously, a createConfig helper function was created to consolidate common esbuild configurations for DevTools. This function is asynchronous, but when it was used to set the configuration in various esbuild config files, it was used as if it was synchronous.

This commit fixes this issue by wrapping the output of the function in await, so that it propagates the configurations to esbuild correctly.

PR Close #48762

devtools/tools/esbuild/esbuild-esm-prod.config.mjs

@@ -9,6 +9,6 @@
 import createConfig from './esbuild-base.config.mjs';
 
 export default {
-  ...createConfig({enableLinker: true, optimize: true}),
+  ...(await createConfig({enableLinker: true, optimize: true})),
   format: 'esm',
 };

devtools/tools/esbuild/esbuild-esm.config.mjs

@@ -9,6 +9,6 @@
 import createConfig from './esbuild-base.config.mjs';
 
 export default {
-  ...createConfig({enableLinker: true, optimize: false}),
+  ...(await createConfig({enableLinker: true, optimize: false})),
   format: 'esm',
 };

devtools/tools/esbuild/esbuild-iife.config.mjs

@@ -9,6 +9,6 @@
 import createConfig from './esbuild-base.config.mjs';
 
 export default {
-  ...createConfig({enableLinker: false, optimize: false}),
+  ...(await createConfig({enableLinker: false, optimize: false})),
   format: 'iife',
 };

devtools/tools/esbuild/esbuild-spec.config.mjs

@@ -9,7 +9,7 @@
 import createConfig from './esbuild-base.config.mjs';
 
 export default {
-  ...createConfig({enableLinker: true, optimize: false}),
+  ...(await createConfig({enableLinker: true, optimize: false})),
   // Use the `iife` format for the test entry-point as tests should run immediately.
   // For browser tests which are wrapped in an AMD header and footer, this works as well.
   format: 'iife',