From 3a688cb5ec65ade06f394dfcbb49376dcc3d8d29 Mon Sep 17 00:00:00 2001 From: AleksanderBodurri Date: Wed, 18 Jan 2023 03:50:33 -0500 Subject: [PATCH] build(devtools): fix issue where esbuild configs were not being set properly in DevTools (#48762) Previously, a createConfig helper function was created to consolidate common esbuild configurations for DevTools. This function is asynchronous, but when it was used to set the configuration in various esbuild config files, it was used as if it was synchronous. This commit fixes this issue by wrapping the output of the function in await, so that it propagates the configurations to esbuild correctly. PR Close #48762 --- devtools/tools/esbuild/esbuild-esm-prod.config.mjs | 2 +- devtools/tools/esbuild/esbuild-esm.config.mjs | 2 +- devtools/tools/esbuild/esbuild-iife.config.mjs | 2 +- devtools/tools/esbuild/esbuild-spec.config.mjs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/tools/esbuild/esbuild-esm-prod.config.mjs b/devtools/tools/esbuild/esbuild-esm-prod.config.mjs index b156801b4f4..c9eae50d56d 100644 --- a/devtools/tools/esbuild/esbuild-esm-prod.config.mjs +++ b/devtools/tools/esbuild/esbuild-esm-prod.config.mjs @@ -9,6 +9,6 @@ import createConfig from './esbuild-base.config.mjs'; export default { - ...createConfig({enableLinker: true, optimize: true}), + ...(await createConfig({enableLinker: true, optimize: true})), format: 'esm', }; diff --git a/devtools/tools/esbuild/esbuild-esm.config.mjs b/devtools/tools/esbuild/esbuild-esm.config.mjs index a8f0ea7f3e8..cc7fb74240b 100644 --- a/devtools/tools/esbuild/esbuild-esm.config.mjs +++ b/devtools/tools/esbuild/esbuild-esm.config.mjs @@ -9,6 +9,6 @@ import createConfig from './esbuild-base.config.mjs'; export default { - ...createConfig({enableLinker: true, optimize: false}), + ...(await createConfig({enableLinker: true, optimize: false})), format: 'esm', }; diff --git a/devtools/tools/esbuild/esbuild-iife.config.mjs b/devtools/tools/esbuild/esbuild-iife.config.mjs index db01b20c5d6..cf3672de8ce 100644 --- a/devtools/tools/esbuild/esbuild-iife.config.mjs +++ b/devtools/tools/esbuild/esbuild-iife.config.mjs @@ -9,6 +9,6 @@ import createConfig from './esbuild-base.config.mjs'; export default { - ...createConfig({enableLinker: false, optimize: false}), + ...(await createConfig({enableLinker: false, optimize: false})), format: 'iife', }; diff --git a/devtools/tools/esbuild/esbuild-spec.config.mjs b/devtools/tools/esbuild/esbuild-spec.config.mjs index e5a728ee005..ba31b3cc07e 100644 --- a/devtools/tools/esbuild/esbuild-spec.config.mjs +++ b/devtools/tools/esbuild/esbuild-spec.config.mjs @@ -9,7 +9,7 @@ import createConfig from './esbuild-base.config.mjs'; export default { - ...createConfig({enableLinker: true, optimize: false}), + ...(await createConfig({enableLinker: true, optimize: false})), // Use the `iife` format for the test entry-point as tests should run immediately. // For browser tests which are wrapped in an AMD header and footer, this works as well. format: 'iife',