Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-05-24 09:28:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor: remove unused code

Browse source
This commit is contained in:
Johnson Cherian 2024-03-12 12:15:59 +05:30
parent 05fb9e74b0
commit a7b3fd34b7
2 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
server/src/helpers/utils.helper.ts
View file

@ -236,13 +236,6 @@ export function isTooljetVersionWithNormalizedAppDefinitionSchem(version) {
return semver.satisfies(semver.coerce(version), '>= 2.24.0');
}
/**
* Checks if a given Tooljet version is compatible with the grid compatibility fix.
*/
export function shouldApplyGridCompatibilityFix(version) {
return semver.satisfies(semver.coerce(version), '>= 2.24.0 < 2.27.8');
}
export function isVersionGreaterThanOrEqual(version1: string, version2: string) {
if (!version1) return false;

4
server/src/services/app_import_export.service.ts
View file

@ -17,7 +17,6 @@ import {
catchDbException,
extractMajorVersion,
isTooljetVersionWithNormalizedAppDefinitionSchem,
shouldApplyGridCompatibilityFix,
isVersionGreaterThanOrEqual,
resolveGridPositionForComponent,
} from 'src/helpers/utils.helper';
@ -238,8 +237,7 @@ export class AppImportExportService {
? true
: isTooljetVersionWithNormalizedAppDefinitionSchem(importedAppTooljetVersion);
const shouldUpdateForGridCompatibility: boolean =
!cloning && shouldApplyGridCompatibilityFix(importedAppTooljetVersion);
const shouldUpdateForGridCompatibility = !cloning;
const importedApp = await this.createImportedAppForUser(this.entityManager, schemaUnifiedAppParams, user);