From a7b3fd34b798004c3993624a404ea240bade9f9e Mon Sep 17 00:00:00 2001 From: Johnson Cherian Date: Tue, 12 Mar 2024 12:15:59 +0530 Subject: [PATCH] refactor: remove unused code --- server/src/helpers/utils.helper.ts | 7 ------- server/src/services/app_import_export.service.ts | 4 +--- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/server/src/helpers/utils.helper.ts b/server/src/helpers/utils.helper.ts index 659282ed9b..50e5b436bd 100644 --- a/server/src/helpers/utils.helper.ts +++ b/server/src/helpers/utils.helper.ts @@ -236,13 +236,6 @@ export function isTooljetVersionWithNormalizedAppDefinitionSchem(version) { return semver.satisfies(semver.coerce(version), '>= 2.24.0'); } -/** - * Checks if a given Tooljet version is compatible with the grid compatibility fix. - */ -export function shouldApplyGridCompatibilityFix(version) { - return semver.satisfies(semver.coerce(version), '>= 2.24.0 < 2.27.8'); -} - export function isVersionGreaterThanOrEqual(version1: string, version2: string) { if (!version1) return false; diff --git a/server/src/services/app_import_export.service.ts b/server/src/services/app_import_export.service.ts index a3df544922..3922e5f42d 100644 --- a/server/src/services/app_import_export.service.ts +++ b/server/src/services/app_import_export.service.ts @@ -17,7 +17,6 @@ import { catchDbException, extractMajorVersion, isTooljetVersionWithNormalizedAppDefinitionSchem, - shouldApplyGridCompatibilityFix, isVersionGreaterThanOrEqual, resolveGridPositionForComponent, } from 'src/helpers/utils.helper'; @@ -238,8 +237,7 @@ export class AppImportExportService { ? true : isTooljetVersionWithNormalizedAppDefinitionSchem(importedAppTooljetVersion); - const shouldUpdateForGridCompatibility: boolean = - !cloning && shouldApplyGridCompatibilityFix(importedAppTooljetVersion); + const shouldUpdateForGridCompatibility = !cloning; const importedApp = await this.createImportedAppForUser(this.entityManager, schemaUnifiedAppParams, user);