mirror of
https://github.com/open-metadata/OpenMetadata
synced 2026-05-24 09:39:11 +00:00
* chore(ingestion): drop pylint, expand ruff to Stage 2c
Replace pylint with a coherent ruff-only stack (Stage 2c of the modernize
roadmap). Pylint is dropped from dev deps and CI workflows; ruff selected
ruleset expanded to ~22 families covering style, bug catchers, hygiene,
and the pylint port (PLE/PLC/PLW/PLR with the noisy "too-many-X"
complexity caps + magic-value disabled).
What's selected (with rationale in pyproject.toml):
E, W, F, I, N — style + correctness baseline + naming
UP — pyupgrade (py>=3.10 modernizations)
B, C4, C90, RET, SIM, TRY — bug catchers
PIE, ICN, T20, TC, TID, PTH, PERF — hygiene
PLE, PLC, PLW, PLR — pylint port (PLR complexity caps ignored)
RUF — ruff-native (incl. RUF100 unused-noqa)
What's removed:
- .pylintrc (root) — duplicate of the ingestion pylint config
- [tool.pylint.*] block in ingestion/pyproject.toml (~140 lines)
- ingestion/plugins/{print_checker,import_checker}.py + tests + README
(replaced by built-in T20 + TID251 banned-api respectively)
- pylint dep from ingestion/setup.py and openmetadata-airflow-apis/pyproject.toml
- `make lint` Makefile target + the pylint invocation in py_format_check
- dead pylint TODO comment + ignored test entry in noxfile.py
Cwd-stable config: ruff is invoked both from the repo root (pre-commit,
CI) and from ingestion/ (`make py_format_check`). The `src`,
`extend-exclude`, and per-file-ignores entries are listed twice — once
relative to ingestion/ and once with the `ingestion/` prefix — so
first-party isort detection and exclusions match in both invocations.
Grandfathering: ran `ruff check --add-noqa` once + format-stable
iteration. ~12,130 noqa directives across ~1,400 files. Cleanup is
deferred to follow-up PRs that drop noqas one rule at a time.
Documentation sweep: replaced `make lint` references in CLAUDE.md,
AGENTS.md, DEVELOPER.md, copilot-instructions, and 6 SKILL files with
the apply+verify shape `make py_format && make py_format_check`.
`make py_format` is NOT a strict superset of pylint — it only applies
auto-fixable violations; `make py_format_check` catches the rest.
Basedpyright baseline regenerated: ruff format reflowed multi-line
signatures in ~70 files, shifting type-error column positions. The
basedpyright baseline matches by (file path, error code, range), so
column shifts caused 19 entries to mis-align. Net diff is small
(154 lines in/out of the 13MB baseline.json) — purely positional.
Verified locally:
- make py_format_check → All checks passed
- nox --no-venv -s static-checks → 0 errors, 0 warnings, 0 notes
* chore(ingestion): finish ruff swap — nox lint session + skill docs
Three remaining stale-tooling references after Stage 2c:
- `ingestion/noxfile.py` `lint` session was still calling `black --check`,
`isort --check-only`, `pycln --diff`. Those tools aren't installed
anywhere (we dropped them from dev deps). Replace with the ruff
equivalents that mirror `make py_format_check`.
- `skills/standards/code_style.md`: stack listed as `black + isort +
pycln`; line length claimed 88 (black default). Both wrong: stack is
ruff, line length is 120.
- `skills/connector-building/SKILL.md`: `make py_format` comment said
`# black + isort + pycln`. Same swap.
* chore(ingestion): keep main's baseline + globally ignore TRY400
Per gitar-bot's review on PR #27774:
1. Main's PR #27728 promoted ~60 `logger.warning()` → `logger.error()`
inside `except` blocks. Those changes landed on main with their own
baseline updates. Our PR doesn't promote anything — the merge from
origin/main brought those `error` calls along with their baseline
entries.
The bot interpreted the `# noqa: TRY400` we added next to those lines
as us silencing the rule case-by-case. Cleaner: globally ignore
TRY400 in pyproject.toml, with a comment explaining why the codebase's
`logger.error(...)` + separate `logger.debug(traceback.format_exc())`
pattern is intentional. Strip ~430 per-line `# noqa: TRY400` markers
from source.
2. Document that `S101` in `per-file-ignores` is a forward-looking
entry — flake8-bandit (`S`) is not yet selected, so the rule is
no-op today; the entry stays so when `S` lands later, tests don't
immediately error.
Reverts the platform pin and Linux Docker–generated baseline. Keep
main's baseline intact and let CI surface the exact column-shifted
entries; the team will decide whether to fix in-place (revert format
on affected files) or add per-line `# pyright: ignore` markers.
* chore(ingestion): regen baseline for new connector type debt
Main's baseline was stale relative to recently-added connectors
(McpConnection, CustomDriveConnection) that lack common attributes
like `hostPort`, `database`, `catalog` etc. — all sites that access
those attributes via the union-typed `serviceConnection.root.config`
fire `reportAttributeAccessIssue` errors that aren't baselined.
71 errors + 58 warnings absorbed. Local macOS regen; pushing to see
CI's drift count. Per the basedpyright-baseline-and-ci PR experience,
macOS↔Linux column drift on this size of regen has historically been
1-7 residuals.
155 lines
6.1 KiB
Python
155 lines
6.1 KiB
Python
# Copyright 2022 Collate
|
|
# Licensed under the Collate Community License, Version 1.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
# https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/LICENSE
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""
|
|
Test database connectors with CLI
|
|
"""
|
|
|
|
import os
|
|
import re
|
|
import subprocess
|
|
from abc import ABC, abstractmethod
|
|
from ast import literal_eval
|
|
from copy import deepcopy
|
|
from pathlib import Path
|
|
from typing import Any, Optional
|
|
|
|
import yaml
|
|
|
|
from metadata.config.common import load_config_file
|
|
from metadata.generated.schema.entity.teams.user import AuthenticationMechanism, User
|
|
from metadata.ingestion.api.status import Status
|
|
from metadata.ingestion.ometa.ometa_api import OpenMetadata
|
|
from metadata.utils.constants import UTF_8
|
|
from metadata.workflow.metadata import MetadataWorkflow
|
|
|
|
from .config_builders.builders import builder_factory # noqa: TID252
|
|
from .e2e_types import E2EType # noqa: TID252
|
|
|
|
PATH_TO_RESOURCES = os.path.dirname(Path(os.path.realpath(__file__)).parent) # noqa: PTH120
|
|
|
|
REGEX_AUX = {"log": r"\s+\[[^]]+]\s+[A-Z]+\s+[^}]+}\s+-\s+"}
|
|
|
|
|
|
class CliBase(ABC):
|
|
"""
|
|
CLI Base class
|
|
"""
|
|
|
|
openmetadata: OpenMetadata
|
|
test_file_path: str
|
|
config_file_path: str
|
|
ingestion_bot_jwt_token: Optional[str] = None # noqa: UP045
|
|
|
|
def run_command(self, command: str = "ingest", test_file_path=None) -> str:
|
|
file_path = test_file_path if test_file_path is not None else self.test_file_path
|
|
args = [
|
|
"metadata",
|
|
command,
|
|
"-c",
|
|
file_path,
|
|
]
|
|
env = os.environ.copy()
|
|
env["PYTHONWARNINGS"] = "ignore::FutureWarning"
|
|
process_status = subprocess.Popen(args, stderr=subprocess.PIPE, env=env)
|
|
_, stderr = process_status.communicate()
|
|
if process_status.returncode != 0:
|
|
print(stderr.decode("utf-8")) # noqa: T201
|
|
raise subprocess.CalledProcessError(
|
|
returncode=process_status.returncode,
|
|
cmd=args,
|
|
output=stderr.decode("utf-8"),
|
|
)
|
|
return stderr.decode("utf-8")
|
|
|
|
def retrieve_lineage(self, entity_fqn: str) -> dict:
|
|
return self.openmetadata.client.get(f"/lineage/table/name/{entity_fqn}?upstreamDepth=3&downstreamDepth=3")
|
|
|
|
@classmethod
|
|
def set_ingestion_bot_jwt_token(cls) -> None:
|
|
ingestion_bot: User = cls.openmetadata.get_by_name(User, "ingestion-bot")
|
|
ingestion_bot_auth: AuthenticationMechanism = cls.openmetadata.get_by_id(
|
|
AuthenticationMechanism, ingestion_bot.id
|
|
)
|
|
cls.ingestion_bot_jwt_token = ingestion_bot_auth.config.JWTToken.get_secret_value()
|
|
|
|
def patch_server_security_config(self, config: dict[str, Any]) -> dict[str, Any]:
|
|
if self.ingestion_bot_jwt_token is None:
|
|
return config
|
|
|
|
server_config = deepcopy(config)
|
|
server_config["workflowConfig"]["openMetadataServerConfig"]["securityConfig"] = {
|
|
"jwtToken": self.ingestion_bot_jwt_token,
|
|
}
|
|
return server_config
|
|
|
|
def build_config_file(self, test_type: E2EType = E2EType.INGEST, extra_args: dict = None) -> None: # noqa: RUF013
|
|
config_yaml = load_config_file(Path(self.config_file_path))
|
|
config_yaml = self.build_yaml(config_yaml, test_type, extra_args)
|
|
config_yaml = self.patch_server_security_config(config_yaml)
|
|
with open(self.test_file_path, "w", encoding=UTF_8) as test_file: # noqa: PTH123
|
|
yaml.dump(config_yaml, test_file)
|
|
|
|
def retrieve_statuses(self, result):
|
|
source_status: Status = self.extract_source_status(result)
|
|
sink_status: Status = self.extract_sink_status(result)
|
|
return sink_status, source_status
|
|
|
|
@staticmethod
|
|
def get_workflow(connector: str, test_type: str) -> MetadataWorkflow:
|
|
config_file = Path(PATH_TO_RESOURCES + f"/{test_type}/{connector}/{connector}.yaml")
|
|
config_dict = load_config_file(config_file)
|
|
return MetadataWorkflow.create(config_dict)
|
|
|
|
@staticmethod
|
|
def extract_source_status(output) -> Status:
|
|
output_clean = output.replace("\n", " ")
|
|
output_clean = re.sub(" +", " ", output_clean)
|
|
output_clean_ansi = re.compile(r"\x1b[^m]*m")
|
|
output_clean = output_clean_ansi.sub(" ", output_clean)
|
|
regex = r"[\w] Status:%(log)s(.*?)%(log)s.* Status: .*" % REGEX_AUX # noqa: UP031
|
|
output_clean_regex = re.findall(regex, output_clean.strip())
|
|
try:
|
|
return Status.model_validate(literal_eval(output_clean_regex[0].strip()))
|
|
except Exception as exc:
|
|
raise RuntimeError(f"Error extracting source status: {exc}. Check the output {output}") # noqa: B904
|
|
|
|
@staticmethod
|
|
def extract_sink_status(output) -> Status:
|
|
output_clean = output.replace("\n", " ")
|
|
output_clean = re.sub(" +", " ", output_clean)
|
|
output_clean_ansi = re.compile(r"\x1b[^m]*m")
|
|
output_clean = output_clean_ansi.sub("", output_clean)
|
|
regex = r".*OpenMetadata Status:%(log)s(.*?)%(log)sExecution.*Summary.*" % REGEX_AUX # noqa: UP031
|
|
output_clean_regex = re.findall(regex, output_clean.strip())[0].strip()
|
|
try:
|
|
return Status.model_validate(literal_eval(output_clean_regex))
|
|
except Exception as exc:
|
|
raise RuntimeError(f"Error extracting sink status: {exc}. Check the output {output}") # noqa: B904
|
|
|
|
@staticmethod
|
|
def build_yaml(config_yaml: dict, test_type: E2EType, extra_args: dict):
|
|
"""
|
|
Build yaml as per E2EType
|
|
"""
|
|
|
|
builder = builder_factory(
|
|
test_type.value,
|
|
config_yaml,
|
|
extra_args,
|
|
)
|
|
|
|
return builder.build()
|
|
|
|
@staticmethod
|
|
@abstractmethod
|
|
def get_test_type():
|
|
pass
|