* chore(ingestion): drop pylint, expand ruff to Stage 2c
Replace pylint with a coherent ruff-only stack (Stage 2c of the modernize
roadmap). Pylint is dropped from dev deps and CI workflows; ruff selected
ruleset expanded to ~22 families covering style, bug catchers, hygiene,
and the pylint port (PLE/PLC/PLW/PLR with the noisy "too-many-X"
complexity caps + magic-value disabled).
What's selected (with rationale in pyproject.toml):
E, W, F, I, N — style + correctness baseline + naming
UP — pyupgrade (py>=3.10 modernizations)
B, C4, C90, RET, SIM, TRY — bug catchers
PIE, ICN, T20, TC, TID, PTH, PERF — hygiene
PLE, PLC, PLW, PLR — pylint port (PLR complexity caps ignored)
RUF — ruff-native (incl. RUF100 unused-noqa)
What's removed:
- .pylintrc (root) — duplicate of the ingestion pylint config
- [tool.pylint.*] block in ingestion/pyproject.toml (~140 lines)
- ingestion/plugins/{print_checker,import_checker}.py + tests + README
(replaced by built-in T20 + TID251 banned-api respectively)
- pylint dep from ingestion/setup.py and openmetadata-airflow-apis/pyproject.toml
- `make lint` Makefile target + the pylint invocation in py_format_check
- dead pylint TODO comment + ignored test entry in noxfile.py
Cwd-stable config: ruff is invoked both from the repo root (pre-commit,
CI) and from ingestion/ (`make py_format_check`). The `src`,
`extend-exclude`, and per-file-ignores entries are listed twice — once
relative to ingestion/ and once with the `ingestion/` prefix — so
first-party isort detection and exclusions match in both invocations.
Grandfathering: ran `ruff check --add-noqa` once + format-stable
iteration. ~12,130 noqa directives across ~1,400 files. Cleanup is
deferred to follow-up PRs that drop noqas one rule at a time.
Documentation sweep: replaced `make lint` references in CLAUDE.md,
AGENTS.md, DEVELOPER.md, copilot-instructions, and 6 SKILL files with
the apply+verify shape `make py_format && make py_format_check`.
`make py_format` is NOT a strict superset of pylint — it only applies
auto-fixable violations; `make py_format_check` catches the rest.
Basedpyright baseline regenerated: ruff format reflowed multi-line
signatures in ~70 files, shifting type-error column positions. The
basedpyright baseline matches by (file path, error code, range), so
column shifts caused 19 entries to mis-align. Net diff is small
(154 lines in/out of the 13MB baseline.json) — purely positional.
Verified locally:
- make py_format_check → All checks passed
- nox --no-venv -s static-checks → 0 errors, 0 warnings, 0 notes
* chore(ingestion): finish ruff swap — nox lint session + skill docs
Three remaining stale-tooling references after Stage 2c:
- `ingestion/noxfile.py` `lint` session was still calling `black --check`,
`isort --check-only`, `pycln --diff`. Those tools aren't installed
anywhere (we dropped them from dev deps). Replace with the ruff
equivalents that mirror `make py_format_check`.
- `skills/standards/code_style.md`: stack listed as `black + isort +
pycln`; line length claimed 88 (black default). Both wrong: stack is
ruff, line length is 120.
- `skills/connector-building/SKILL.md`: `make py_format` comment said
`# black + isort + pycln`. Same swap.
* chore(ingestion): keep main's baseline + globally ignore TRY400
Per gitar-bot's review on PR #27774:
1. Main's PR #27728 promoted ~60 `logger.warning()` → `logger.error()`
inside `except` blocks. Those changes landed on main with their own
baseline updates. Our PR doesn't promote anything — the merge from
origin/main brought those `error` calls along with their baseline
entries.
The bot interpreted the `# noqa: TRY400` we added next to those lines
as us silencing the rule case-by-case. Cleaner: globally ignore
TRY400 in pyproject.toml, with a comment explaining why the codebase's
`logger.error(...)` + separate `logger.debug(traceback.format_exc())`
pattern is intentional. Strip ~430 per-line `# noqa: TRY400` markers
from source.
2. Document that `S101` in `per-file-ignores` is a forward-looking
entry — flake8-bandit (`S`) is not yet selected, so the rule is
no-op today; the entry stays so when `S` lands later, tests don't
immediately error.
Reverts the platform pin and Linux Docker–generated baseline. Keep
main's baseline intact and let CI surface the exact column-shifted
entries; the team will decide whether to fix in-place (revert format
on affected files) or add per-line `# pyright: ignore` markers.
* chore(ingestion): regen baseline for new connector type debt
Main's baseline was stale relative to recently-added connectors
(McpConnection, CustomDriveConnection) that lack common attributes
like `hostPort`, `database`, `catalog` etc. — all sites that access
those attributes via the union-typed `serviceConnection.root.config`
fire `reportAttributeAccessIssue` errors that aren't baselined.
71 errors + 58 warnings absorbed. Local macOS regen; pushing to see
CI's drift count. Per the basedpyright-baseline-and-ci PR experience,
macOS↔Linux column drift on this size of regen has historically been
1-7 residuals.
|
||
|---|---|---|
| .. | ||
| base | ||
| common | ||
| dashboard | ||
| database | ||
| dbt/redshift | ||
| __init__.py | ||
| common_e2e_sqa_mixins.py | ||
| README.md | ||
| test_cli_athena.py | ||
| test_cli_bigquery.py | ||
| test_cli_bigquery_multiple_project.py | ||
| test_cli_datalake_s3.py | ||
| test_cli_dbt_redshift.py | ||
| test_cli_exasol.py | ||
| test_cli_hive.py | ||
| test_cli_metabase.py | ||
| test_cli_mssql.py | ||
| test_cli_mysql.py | ||
| test_cli_oracle.py | ||
| test_cli_postgres.py | ||
| test_cli_powerbi.py | ||
| test_cli_quicksight.py | ||
| test_cli_redash.py | ||
| test_cli_redshift.py | ||
| test_cli_snowflake.py | ||
| test_cli_tableau.py | ||
| test_cli_vertica.py | ||
E2E CLI tests
How to add a connector
-
Add an ingestion YAML file with the service and the credentials of it. Use when possible a Dockerized environment, otherwise, remember to use environment variables for sensitive information in case of external resources. On each test, the YAML file will be modified by the
build_yamlmethod which will create a copy of the file and prepare it for the tests. This way, we avoid adding (and maintaining) an extra YAML for each test. -
The
{connector}name must be added in the list of connectors in the GH Action:.github/workflows/py-cli-e2e-tests.yml
jobs:
py-cli-e2e-tests:
runs-on: ubuntu-latest
strategy:
matrix:
py-version: ['3.12']
e2e-test: ['mysql', '{connector}']
Database connectors
Currently, it runs CLI tests for any database connector.
./base/test_cli_dbhas 8 test definitions for database connectors. It is an abstract class../common/test_cli_dbis another abstract class for those connectors whose sources implement theCommonDbSourceServiceclass.- It partially implements some methods from
test_cli_db_base. test_cli_{connector}is the specific connector test. More tests apart the ones implemented by the./base/test_cli_dbcan be run inside this class.
How to add a database connector
-
Use
test_cli_mysql.pyas example. Your connector E2E CLI test must follow the name convention:test_cli_{connector}.pyand the test class must extend fromCliCommonDB.TestSuiteif the connector's source implement theCommonDbSourceServiceclass, otherwise, fromCliDBBase.TestSuite. -
If it is a database connector whose source implement the
CommonDbSourceServiceclass, these methods must be overwritten:
# the connector name
def get_connector_name() -> str:
return "{connector}"
# create using the SQLAlchemy engine a table, a view associated to it and add some rows to the table
def create_table_and_view(self) -> None:
pass
# delete the view and table created using the SQLAlchemy engine
def delete_table_and_view(self) -> None:
pass
# expected tables to be ingested
def expected_tables() -> int:
pass
# numbers of rows added to the created table
def inserted_rows_count(self) -> int:
pass
# created table FQN
def fqn_created_table() -> str:
pass
# list of schemas patterns to be included in the schema filters
def get_includes_schemas() -> List[str]:
pass
# list of table patterns to be included in the table filters
def get_includes_tables() -> List[str]:
pass
# list of table patterns to be excluded in the table filters
def get_excludes_tables() -> List[str]:
pass
# expected number of schemas to be filtered with the use of includes (get_includes_schemas)
def expected_filtered_schema_includes() -> int:
pass
# expected number of schemas to be filtered with the use of excludes (get_includes_schemas)
def expected_filtered_schema_excludes() -> int:
pass
# expected number of tables to be filtered with the use of includes (get_includes_tables)
def expected_filtered_table_includes() -> int:
pass
# expected number of tables to be filtered with the use of excludes (get_includes_tables)
def expected_filtered_table_excludes() -> int:
pass
# expected number of filter entities with the use of a mix of filters (get_includes_schemas, get_includes_tables, get_excludes_tables)
def expected_filtered_mix() -> int:
pass
Dashboard connectors
Currently, it runs CLI tests for any database connector.
./base/test_cli_dashboardhas 3 test definitions for database connectors. It is an abstract class../common/test_cli_dashboardis another class that partially implements some methods fromtest_cli_dashboard_base.test_cli_{connector}is the specific connector test. More tests apart the ones implemented by the./base/test_cli_dashboardcan be run inside this class.
How to add a dashboard connector
-
Use
test_cli_tableau.pyas example. Your connector E2E CLI test must follow the name convention:test_cli_{connector}.pyand the test class must extend fromCliCommonDashboard.TestSuite. -
These methods must be overwritten:
# in case we want to do something before running the tests
def prepare() -> None:
pass
# the connector name
def get_connector_name() -> str:
return "{connector}"
# the dashboard to include in filters
def get_includes_dashboards() -> List[str]:
pass
# the dashboard to exclude in filters
def get_excludes_dashboards() -> List[str]:
pass
# the charts to include in filters
def get_includes_charts() -> List[str]:
pass
# the charts to exclude in filters
def get_excludes_charts() -> List[str]:
pass
# the data models to include in filters
def get_includes_datamodels() -> List[str]:
pass
# the data models to exclude in filters
def get_excludes_datamodels() -> List[str]:
pass
# expected number of entities to be ingested
def expected_entities() -> int:
pass
# expected number of lineage to be ingested
def expected_lineage() -> int:
pass
# expected number of tags to be ingested
def expected_tags() -> int:
pass
# expected number of entities to be filtered when testing include tags and data models options
def expected_not_included_entities() -> int:
pass
# expected number of entities to be filtered in the sink step when testing include tags and data models options
def expected_not_included_sink_entities() -> int:
pass
# expected number of entities to be filtered out when testing mix of filters
def expected_filtered_mix() -> int:
pass
# expected number of entities to be filtered out in the sink step when testing mix of filters
def expected_filtered_sink_mix() -> int:
pass