mirror of
https://github.com/Instagram/IGListKit
synced 2026-05-06 06:58:26 +00:00
Summary:
This method generated using the remodel generation script does not match with the header file.
The method declared in .h file is:
- (BOOL)isEqualToDiffableObject:(nullable id<IGListDiffable>)object;
But implementation generated in .m file is:
- (BOOL)isEqualToDiffableObject:(nullable id)object
{
return [self isEqual:object];
}
This fix is to generate the implementation as:
- (BOOL)isEqualToDiffableObject:(nullable id<IGListDiffable>)object
{
return [self isEqual:object];
}
Reviewed By: natestedman
Differential Revision: D27146804
fbshipit-source-id: f7d0d598e97e0ef47948b973ff38d9a319cd4b0d
156 lines
4.7 KiB
Gherkin
156 lines
4.7 KiB
Gherkin
# Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
|
|
|
|
Feature: Outputting Value Objects implementing IGListDiffable
|
|
|
|
@announce
|
|
Scenario: Generating a value object, which correctly implements IGListDiffable using the specified diffIdentifier
|
|
Given a file named "project/values/IGListDiffableTest.value" with:
|
|
"""
|
|
IGListDiffableTest includes(IGListDiffable) {
|
|
CGRect someRect
|
|
%diffIdentifier NSString *stringOne
|
|
}
|
|
"""
|
|
When I run `../../bin/generate project`
|
|
Then the file "project/values/IGListDiffableTest.h" should contain:
|
|
"""
|
|
|
|
#import <Foundation/Foundation.h>
|
|
#import <CoreGraphics/CGGeometry.h>
|
|
#import <IGListKit/IGListDiffable.h>
|
|
|
|
@interface IGListDiffableTest : NSObject <IGListDiffable, NSCopying>
|
|
|
|
@property (nonatomic, readonly) CGRect someRect;
|
|
@property (nonatomic, readonly, copy) NSString *stringOne;
|
|
|
|
+ (instancetype)new NS_UNAVAILABLE;
|
|
|
|
- (instancetype)init NS_UNAVAILABLE;
|
|
|
|
- (instancetype)initWithSomeRect:(CGRect)someRect stringOne:(NSString *)stringOne NS_DESIGNATED_INITIALIZER;
|
|
|
|
@end
|
|
|
|
"""
|
|
And the file "project/values/IGListDiffableTest.m" should contain:
|
|
"""
|
|
- (id<NSObject>)diffIdentifier
|
|
{
|
|
return _stringOne;
|
|
}
|
|
"""
|
|
And the file "project/values/IGListDiffableTest.m" should contain:
|
|
"""
|
|
- (BOOL)isEqualToDiffableObject:(nullable id<IGListDiffable>)object
|
|
{
|
|
return [self isEqual:object];
|
|
}
|
|
"""
|
|
|
|
Scenario: Generating a value object, which correctly implements IGListDiffable using a CGRect property
|
|
Given a file named "project/values/IGListDiffableTest2.value" with:
|
|
"""
|
|
IGListDiffableTest2 includes(IGListDiffable) {
|
|
%diffIdentifier CGRect someRect
|
|
}
|
|
"""
|
|
When I run `../../bin/generate project`
|
|
Then the file "project/values/IGListDiffableTest2.h" should contain:
|
|
"""
|
|
|
|
#import <Foundation/Foundation.h>
|
|
#import <CoreGraphics/CGGeometry.h>
|
|
#import <IGListKit/IGListDiffable.h>
|
|
|
|
@interface IGListDiffableTest2 : NSObject <IGListDiffable, NSCopying>
|
|
|
|
@property (nonatomic, readonly) CGRect someRect;
|
|
|
|
+ (instancetype)new NS_UNAVAILABLE;
|
|
|
|
- (instancetype)init NS_UNAVAILABLE;
|
|
|
|
- (instancetype)initWithSomeRect:(CGRect)someRect NS_DESIGNATED_INITIALIZER;
|
|
|
|
@end
|
|
"""
|
|
And the file "project/values/IGListDiffableTest2.m" should contain:
|
|
"""
|
|
- (id<NSObject>)diffIdentifier
|
|
{
|
|
return [NSValue valueWithCGRect:_someRect];
|
|
}
|
|
"""
|
|
And the file "project/values/IGListDiffableTest2.m" should contain:
|
|
"""
|
|
- (BOOL)isEqualToDiffableObject:(nullable id<IGListDiffable>)object
|
|
{
|
|
return [self isEqual:object];
|
|
}
|
|
"""
|
|
|
|
Scenario: Generating a value object, which correctly implements IGListDiffable using an NSInteger property
|
|
Given a file named "project/values/IGListDiffableTest3.value" with:
|
|
"""
|
|
IGListDiffableTest3 includes(IGListDiffable) {
|
|
%diffIdentifier NSInteger count
|
|
}
|
|
"""
|
|
When I run `../../bin/generate project`
|
|
Then the file "project/values/IGListDiffableTest3.m" should contain:
|
|
"""
|
|
- (id<NSObject>)diffIdentifier
|
|
{
|
|
return @(_count);
|
|
}
|
|
"""
|
|
And the file "project/values/IGListDiffableTest3.m" should contain:
|
|
"""
|
|
- (BOOL)isEqualToDiffableObject:(nullable id<IGListDiffable>)object
|
|
{
|
|
return [self isEqual:object];
|
|
}
|
|
"""
|
|
|
|
Scenario: Generating a value object, which correctly implements IGListDiffable defaulting to self as diffIdentifier
|
|
Given a file named "project/values/IGListDiffableTest4.value" with:
|
|
"""
|
|
IGListDiffableTest4 includes(IGListDiffable) {
|
|
CGRect someRect
|
|
}
|
|
"""
|
|
When I run `../../bin/generate project`
|
|
Then the file "project/values/IGListDiffableTest4.h" should contain:
|
|
"""
|
|
#import <Foundation/Foundation.h>
|
|
#import <CoreGraphics/CGGeometry.h>
|
|
#import <IGListKit/IGListDiffable.h>
|
|
|
|
@interface IGListDiffableTest4 : NSObject <IGListDiffable, NSCopying>
|
|
|
|
@property (nonatomic, readonly) CGRect someRect;
|
|
|
|
+ (instancetype)new NS_UNAVAILABLE;
|
|
|
|
- (instancetype)init NS_UNAVAILABLE;
|
|
|
|
- (instancetype)initWithSomeRect:(CGRect)someRect NS_DESIGNATED_INITIALIZER;
|
|
|
|
@end
|
|
|
|
"""
|
|
And the file "project/values/IGListDiffableTest4.m" should contain:
|
|
"""
|
|
- (id<NSObject>)diffIdentifier
|
|
{
|
|
return self;
|
|
}
|
|
"""
|
|
And the file "project/values/IGListDiffableTest4.m" should contain:
|
|
"""
|
|
- (BOOL)isEqualToDiffableObject:(nullable id<IGListDiffable>)object
|
|
{
|
|
return [self isEqual:object];
|
|
}
|
|
"""
|