Summary:
This method generated using the remodel generation script does not match with the header file.
The method declared in .h file is:
- (BOOL)isEqualToDiffableObject:(nullable id<IGListDiffable>)object;
But implementation generated in .m file is:
- (BOOL)isEqualToDiffableObject:(nullable id)object
{
return [self isEqual:object];
}
This fix is to generate the implementation as:
- (BOOL)isEqualToDiffableObject:(nullable id<IGListDiffable>)object
{
return [self isEqual:object];
}
Reviewed By: natestedman
Differential Revision: D27146804
fbshipit-source-id: f7d0d598e97e0ef47948b973ff38d9a319cd4b0d
Summary:
Remodel changed quite a bit, this updates the plugin to work correctly with the latest state.
It also includes other recent Remodel changes like e.g. autoformatting of the codebase.
Resolves#1353
Reviewed By: natestedman
Differential Revision: D16794236
fbshipit-source-id: f543d0e3e5656f540accd5e359bbaf0acc8071fc
Summary: Let's use simple NSNumber wrapping to make diffable objects for most primitive types. This should be faster than building strings.
Reviewed By: calimarkus
Differential Revision: D10416548
fbshipit-source-id: af5b0a5afc6cd2c45c7e0bf2aa872864c12cbd98
Summary: This ensures we stay compatible with the current open source state of remodel.
Reviewed By: ColinCampbell
Differential Revision: D7082447
fbshipit-source-id: 3fa23b903760d36029141b5adc441ae57ea5caab
Summary:
Adds the source for a remodel plugin to autogenerate models conforming to `IGListDIffable`.
- [x] All tests pass. Demo project builds and runs. (source untouched, purely additive)
- [x] I added remodel plugin tests + and a new guide explaining the installation + usage
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/1083
Reviewed By: rnystrom
Differential Revision: D6937925
Pulled By: calimarkus
fbshipit-source-id: 54228cddf387cf20ceceec1732e439ab6fd4b984
