Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-24 09:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
IGListKit/Source/Internal
History
Kyle Hickinson a2e0005357 Replace reusable identifier methods with a C function (#40) 
Summary:
Replaced the two methods for generating a reusable identifier with an inline C function (as per #40) which has 3 parameters: `viewClass` (unchanged), `nibName` (for when #1 is added), and `kind`. The string is generated following the same pattern as before.

A few things:
- The current test only tests one of the options. May want to add more tests for each.
- Not sure if you guys prefer `NS_INLINE` vs `static inline`.
- Not sure if we want to add assertions for empty strings for nibName/kind parameters.

- [x] All tests pass. Demo project builds and runs.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/49

Differential Revision: D4005549

Pulled By: jessesquires

fbshipit-source-id: e1683ebe8882d1a8de934c8166f67d3508cffba9
2016-10-11 17:59:08 -07:00
..
IGListAdapterInternal.h Replace reusable identifier methods with a C function (#40) 2016-10-11 17:59:08 -07:00
IGListAdapterProxy.h Initial commit 2016-10-11 10:12:17 -04:00
IGListAdapterProxy.m Initial commit 2016-10-11 10:12:17 -04:00
IGListAdapterUpdaterInternal.h Initial commit 2016-10-11 10:12:17 -04:00
IGListDisplayHandler.h Initial commit 2016-10-11 10:12:17 -04:00
IGListDisplayHandler.m Initial commit 2016-10-11 10:12:17 -04:00
IGListIndexPathResultInternal.h Initial commit 2016-10-11 10:12:17 -04:00
IGListIndexSetResultInternal.h Initial commit 2016-10-11 10:12:17 -04:00
IGListMoveIndexInternal.h Initial commit 2016-10-11 10:12:17 -04:00
IGListMoveIndexPathInternal.h Initial commit 2016-10-11 10:12:17 -04:00
IGListSectionControllerInternal.h Initial commit 2016-10-11 10:12:17 -04:00
IGListSectionMap.h Initial commit 2016-10-11 10:12:17 -04:00
IGListSectionMap.m Initial commit 2016-10-11 10:12:17 -04:00
IGListStackedSectionControllerInternal.h Initial commit 2016-10-11 10:12:17 -04:00
IGListWorkingRangeHandler.h Initial commit 2016-10-11 10:12:17 -04:00
IGListWorkingRangeHandler.mm Initial commit 2016-10-11 10:12:17 -04:00
NSIndexSet+PrettyDescription.h Initial commit 2016-10-11 10:12:17 -04:00
NSIndexSet+PrettyDescription.m Initial commit 2016-10-11 10:12:17 -04:00
UICollectionView+IGListBatchUpdateData.h Initial commit 2016-10-11 10:12:17 -04:00
UICollectionView+IGListBatchUpdateData.m Initial commit 2016-10-11 10:12:17 -04:00