Elgato_dark/IGListKit
1
0
Fork 0
mirror of https://github.com/Instagram/IGListKit synced 2026-05-24 09:48:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
IGListKit/Source
History
Kyle Hickinson a2e0005357 Replace reusable identifier methods with a C function (#40) 
Summary:
Replaced the two methods for generating a reusable identifier with an inline C function (as per #40) which has 3 parameters: `viewClass` (unchanged), `nibName` (for when #1 is added), and `kind`. The string is generated following the same pattern as before.

A few things:
- The current test only tests one of the options. May want to add more tests for each.
- Not sure if you guys prefer `NS_INLINE` vs `static inline`.
- Not sure if we want to add assertions for empty strings for nibName/kind parameters.

- [x] All tests pass. Demo project builds and runs.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/49

Differential Revision: D4005549

Pulled By: jessesquires

fbshipit-source-id: e1683ebe8882d1a8de934c8166f67d3508cffba9
2016-10-11 17:59:08 -07:00
..
Internal Replace reusable identifier methods with a C function (#40) 2016-10-11 17:59:08 -07:00
IGListAdapter.h Initial commit 2016-10-11 10:12:17 -04:00
IGListAdapter.m Replace reusable identifier methods with a C function (#40) 2016-10-11 17:59:08 -07:00
IGListAdapterDataSource.h Initial commit 2016-10-11 10:12:17 -04:00
IGListAdapterDelegate.h Initial commit 2016-10-11 10:12:17 -04:00
IGListAdapterUpdater.h Initial commit 2016-10-11 10:12:17 -04:00
IGListAdapterUpdater.m Initial commit 2016-10-11 10:12:17 -04:00
IGListAdapterUpdaterDelegate.h Initial commit 2016-10-11 10:12:17 -04:00
IGListAssert.h Initial commit 2016-10-11 10:12:17 -04:00
IGListBatchUpdateData.h Initial commit 2016-10-11 10:12:17 -04:00
IGListBatchUpdateData.mm Initial commit 2016-10-11 10:12:17 -04:00
IGListCollectionContext.h Initial commit 2016-10-11 10:12:17 -04:00
IGListCollectionView.h Initial commit 2016-10-11 10:12:17 -04:00
IGListCollectionView.m Initial commit 2016-10-11 10:12:17 -04:00
IGListDiff.h Initial commit 2016-10-11 10:12:17 -04:00
IGListDiff.mm Initial commit 2016-10-11 10:12:17 -04:00
IGListDiffable.h Initial commit 2016-10-11 10:12:17 -04:00
IGListDisplayDelegate.h Initial commit 2016-10-11 10:12:17 -04:00
IGListExperiments.h Initial commit 2016-10-11 10:12:17 -04:00
IGListIndexPathResult.h Initial commit 2016-10-11 10:12:17 -04:00
IGListIndexPathResult.m Initial commit 2016-10-11 10:12:17 -04:00
IGListIndexSetResult.h Initial commit 2016-10-11 10:12:17 -04:00
IGListIndexSetResult.m Initial commit 2016-10-11 10:12:17 -04:00
IGListKit.h Initial commit 2016-10-11 10:12:17 -04:00
IGListMacros.h Initial commit 2016-10-11 10:12:17 -04:00
IGListMoveIndex.h Initial commit 2016-10-11 10:12:17 -04:00
IGListMoveIndex.m Initial commit 2016-10-11 10:12:17 -04:00
IGListMoveIndexPath.h Initial commit 2016-10-11 10:12:17 -04:00
IGListMoveIndexPath.m Initial commit 2016-10-11 10:12:17 -04:00
IGListReloadDataUpdater.h Initial commit 2016-10-11 10:12:17 -04:00
IGListReloadDataUpdater.m Initial commit 2016-10-11 10:12:17 -04:00
IGListScrollDelegate.h Initial commit 2016-10-11 10:12:17 -04:00
IGListSectionController.h Initial commit 2016-10-11 10:12:17 -04:00
IGListSectionController.m Initial commit 2016-10-11 10:12:17 -04:00
IGListSectionType.h Initial commit 2016-10-11 10:12:17 -04:00
IGListSingleSectionController.h Initial commit 2016-10-11 10:12:17 -04:00
IGListSingleSectionController.m Initial commit 2016-10-11 10:12:17 -04:00
IGListStackedSectionController.h Initial commit 2016-10-11 10:12:17 -04:00
IGListStackedSectionController.m Initial commit 2016-10-11 10:12:17 -04:00
IGListSupplementaryViewSource.h Initial commit 2016-10-11 10:12:17 -04:00
IGListUpdatingDelegate.h Initial commit 2016-10-11 10:12:17 -04:00
IGListWorkingRangeDelegate.h Initial commit 2016-10-11 10:12:17 -04:00
Info.plist Initial commit 2016-10-11 10:12:17 -04:00
NSObject+IGListDiffable.h Initial commit 2016-10-11 10:12:17 -04:00
NSObject+IGListDiffable.m Initial commit 2016-10-11 10:12:17 -04:00