Archon/.github/pull_request_template.md
Rasmus Widing a684345524
feat(skills): overhaul archon-dev skill, add issue cookbook, improve templates
* feat(skills): overhaul archon-dev skill with PRP-inspired improvements

Rewrote all 9 cookbooks (split research into research + investigate) with
battle-tested patterns from PRP workflows. Key improvements:

- research: pure codebase cartography with query classification and follow-up
- investigate: new cookbook for strategic research + feasibility assessment
- prd: 3-round interactive interview with MoSCoW, JTBD, implementation phases
- plan: PRD phase auto-detection, UX diagrams, confidence score, prior-knowledge test
- implement: env detection, base branch auto-detect, git state decision tree
- review: PR checkout, state handling, plan deviation awareness, GitHub posting
- debug: hypothesis-driven methodology, quick/deep modes, 3-test validation
- commit: natural language file targeting while keeping safety checks
- pr: template detection, existing PR check, draft support, base branch auto-detect

Updated SKILL.md description with project-anchored triggers and concrete
examples per cookbook to improve routing accuracy.

* fix(skills): add missing routing keywords for investigate cookbook

Add "can we" and "best approach" to investigate keywords — both are
common phrasings for feasibility questions that weren't being matched.

* fix(skills): broaden PR template search in pr cookbook

Scan .github folder and subfolders more thoroughly before concluding
no PR template exists.

* feat: overhaul PR template with comprehensive engineering sections

Replace minimal 5-section template with structured template covering
UX journey, architecture diagrams, security impact, blast radius,
rollback plan, and validation evidence. Adapted for the Archon
monorepo with project-specific scopes and validation commands.

* feat: improve bug report and feature request issue templates

Add structured sections for user flow diagrams, scope identification,
impact assessment, security considerations, and definition of done.
Adapted for the Archon monorepo with project-specific packages and
platform options.

* feat(skills): add issue cookbook for GitHub bug/feature reporting

New cookbook that classifies bug vs feature, finds the repo's issue
template, validates with a subagent, and submits via gh CLI. Updated
SKILL.md routing table and workflow chain diagram.
2026-03-10 08:38:11 +01:00

129 lines
3.1 KiB
Markdown

## Summary
Describe this PR in 2-5 bullets:
- Problem:
- Why it matters:
- What changed:
- What did **not** change (scope boundary):
## UX Journey
### Before
```
(Draw the user-facing flow BEFORE this PR. Show each step the user takes.)
Example:
User Archon AI Client
──── ────── ─────────
sends message ──────▶ resolves session
loads context
streams to AI ──────────▶ processes prompt
receives chunks ◀──────── streams response
sees reply ◀───────── sends to platform
```
### After
```
(Draw the user-facing flow AFTER this PR. Highlight what changed with [brackets] or asterisks.)
```
## Architecture Diagram
### Before
```
(Map ALL modules touched or connected to this change. Draw lines between them.)
```
### After
```
(Same diagram with changes highlighted. Mark new modules with [+], removed with [-],
modified with [~]. Mark new connections with ===, removed with --x--.)
```
**Connection inventory** (list every module-to-module edge, mark changes):
| From | To | Status | Notes |
|------|----|--------|-------|
| | | unchanged / **new** / **removed** / **modified** | |
## Label Snapshot
- Risk: `risk: low|medium|high`
- Size: `size: XS|S|M|L|XL`
- Scope: `core|workflows|isolation|git|adapters|server|web|cli|paths|config|docs|dependencies|ci|tests|skills`
- Module: `<scope>:<component>` (e.g. `workflows:executor`, `adapters:slack`, `core:orchestrator`)
## Change Metadata
- Change type: `bug|feature|refactor|docs|security|chore`
- Primary scope: `core|workflows|isolation|git|adapters|server|web|cli|paths|multi`
## Linked Issue
- Closes #
- Related #
- Depends on # (if stacked)
- Supersedes # (if replacing older PR)
## Validation Evidence (required)
Commands and result summary:
```bash
bun run type-check
bun run lint
bun run format:check
bun run test
# Or all at once:
bun run validate
```
- Evidence provided (test/log/trace/screenshot):
- If any command is intentionally skipped, explain why:
## Security Impact (required)
- New permissions/capabilities? (`Yes/No`)
- New external network calls? (`Yes/No`)
- Secrets/tokens handling changed? (`Yes/No`)
- File system access scope changed? (`Yes/No`)
- If any `Yes`, describe risk and mitigation:
## Compatibility / Migration
- Backward compatible? (`Yes/No`)
- Config/env changes? (`Yes/No`)
- Database migration needed? (`Yes/No`)
- If yes, exact upgrade steps:
## Human Verification (required)
What was personally validated beyond CI:
- Verified scenarios:
- Edge cases checked:
- What was not verified:
## Side Effects / Blast Radius (required)
- Affected subsystems/workflows:
- Potential unintended effects:
- Guardrails/monitoring for early detection:
## Rollback Plan (required)
- Fast rollback command/path:
- Feature flags or config toggles (if any):
- Observable failure symptoms:
## Risks and Mitigations
List real risks in this PR (or write `None`).
- Risk:
- Mitigation: