mirror of
https://github.com/apache/zeppelin
synced 2026-05-24 09:38:26 +00:00
### What is this PR for? This PR fixes wrong written NotebookID to NoteID. ### What type of PR is it? [Improvement] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1549 ### Questions: * Does the licenses files need update? No. * Is there breaking changes for older versions? No. * Does this needs documentation? No Author: hyonzin <[email protected]> Author: 정현진 <[email protected]> Author: Mina Lee <[email protected]> Closes #1518 from hyonzin/ZEPPELIN-1549 and squashes the following commits:2c5d461[hyonzin] fix pullNoteID to pullNoteIdf843abd[hyonzin] Fix missed line22aecb3[hyonzin] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1549ac03666[정현진] Merge pull request #1 from minahlee/ZEPPELIN-15498b3fffd[Mina Lee] Change notebook to note and fix indentation000605f[hyonzin] Change clonedNotebookId to clonedNoteId496695c[hyonzin] Change noteID to noteId1e87463[hyonzin] Remove tab indent5647d37[hyonzin] Rebase and solve conflicts09bacd8[hyonzin] Fix more lines unchanged070bc2d[hyonzin] fix more in ZeppelinRestApiTest.java24822a3[hyonzin] Fix more code not changed (notebookIndex to noteSearchService)4b4e1e8[hyonzin] Fix detail (function's name) & Change some placeholder429203d[hyonzin] Fix details & convention to camel5fa270d[hyonzin] pull upstream master & fix some details294bea5[hyonzin] Fix some wrong written term: Notebook -> Notecc0d315[hyonzin] Change NotebookID variable name to NoteID
35 lines
1 KiB
JavaScript
35 lines
1 KiB
JavaScript
/*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
'use strict';
|
|
(function() {
|
|
|
|
angular.module('zeppelinWebApp').service('arrayOrderingSrv', arrayOrderingSrv);
|
|
|
|
function arrayOrderingSrv() {
|
|
var arrayOrderingSrv = this;
|
|
|
|
this.noteListOrdering = function(note) {
|
|
return arrayOrderingSrv.getNoteName(note);
|
|
};
|
|
|
|
this.getNoteName = function(note) {
|
|
if (note.name === undefined || note.name.trim() === '') {
|
|
return 'Note ' + note.id;
|
|
} else {
|
|
return note.name;
|
|
}
|
|
};
|
|
}
|
|
|
|
})();
|