### What is this PR for?
This PR fixes wrong written NotebookID to NoteID.
### What type of PR is it?
[Improvement]
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1549
### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No
Author: hyonzin <[email protected]>
Author: 정현진 <[email protected]>
Author: Mina Lee <[email protected]>
Closes#1518 from hyonzin/ZEPPELIN-1549 and squashes the following commits:
2c5d461 [hyonzin] fix pullNoteID to pullNoteId
f843abd [hyonzin] Fix missed line
22aecb3 [hyonzin] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-1549
ac03666 [정현진] Merge pull request #1 from minahlee/ZEPPELIN-1549
8b3fffd [Mina Lee] Change notebook to note and fix indentation
000605f [hyonzin] Change clonedNotebookId to clonedNoteId
496695c [hyonzin] Change noteID to noteId
1e87463 [hyonzin] Remove tab indent
5647d37 [hyonzin] Rebase and solve conflicts
09bacd8 [hyonzin] Fix more lines unchanged
070bc2d [hyonzin] fix more in ZeppelinRestApiTest.java
24822a3 [hyonzin] Fix more code not changed (notebookIndex to noteSearchService)
4b4e1e8 [hyonzin] Fix detail (function's name) & Change some placeholder
429203d [hyonzin] Fix details & convention to camel
5fa270d [hyonzin] pull upstream master & fix some details
294bea5 [hyonzin] Fix some wrong written term: Notebook -> Note
cc0d315 [hyonzin] Change NotebookID variable name to NoteID
### What is this PR for?
This PR uses websocket to get and save interpreter bindings instead of rest api
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1254
### How should this be tested?
Go to interpreter binding settings on notebook page and enable/disable interpreter or reorder and save. Simultaneously verify the network calls on browser's console.
### Screenshots (if appropriate)
n/a
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
Author: Renjith Kamath <[email protected]>
Closes#1247 from r-kamath/ZEPPELIN-1254 and squashes the following commits:
6ac1748 [Renjith Kamath] ZEPPELIN-1254 revert indentation
55d95ec [Renjith Kamath] ZEPPELIN-1254 review fix
ab0bced [Renjith Kamath] ZEPPELIN-1254 boradcast after updating the interpreter bindings
299bb51 [Renjith Kamath] ZEPPELIN-1254 review fix
97bfd7d [Renjith Kamath] ZEPPELIN-1254 Make get and save Interpreter bindings calls via websocket
### What is this PR for?
The Notebook Title Input would not disappear after being edited.
This is a problem made by its plugin elastic-input.
We originally used ng-if instead of ng-show so it doesn't break the Page Print, however that change made the scope value to toggle unusable.
So we added a trustworthy small controller on top of the component.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1276
### How should this be tested?
* Click on the Notebook title
* Try to do: Enter or Esc or Click somewhere else
* The Input border should not be there anymore
* Do the same for the Paragraph
* If you do Print Page there shouldn't any titles duplicated at the top
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Damien CORNEAU <[email protected]>
Closes#1273 from corneadoug/ZEPPELIN-1276 and squashes the following commits:
7d32090 [Damien CORNEAU] Remove a test that check the showEditor in NotebookCtrl
24df51f [Damien CORNEAU] Fix eslint errors
d590d82 [Damien CORNEAU] apply same input changes to the paragraph
b862081 [Damien CORNEAU] Fix Notebook input issue
### What is this PR for?
This PR addresses ability to view the history of note revisions from the `version control` menu
### What type of PR is it?
Improvement
### Todos
* [x] - backend changes
* [x] - tests
* [x] - propagation to frontend
* [x] - rendering list
### What is the Jira issue?
[Zeppelin - 1152](https://issues.apache.org/jira/browse/ZEPPELIN-1152)
### How should this be tested?
1. Select Git notebook storage layer as primary (e.g. in `conf/zeppelin-env.sh` add
```
export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
2. Select any note in Zeppelin and `commit` it in `version control` menu
3. The list with new commit should be shown in the same menu
### Screenshots (if appropriate)
<img width="782" alt="screen shot 2016-07-21 at 11 35 21 am" src="https://cloud.githubusercontent.com/assets/1642088/17009639/c8bcbd58-4f37-11e6-92cd-88147b7419e6.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Khalid Huseynov <[email protected]>
Author: Khalid Huseynov <[email protected]>
Author: Damien CORNEAU <[email protected]>
Closes#1160 from khalidhuseynov/front/list-revision-history and squashes the following commits:
924a6c5 [Khalid Huseynov] address @corneadoug comments
614ed61 [Khalid Huseynov] date: smaller font and spacing
f676b74 [Khalid Huseynov] Merge branch 'master' into front/list-revision-history
bd068fd [Khalid Huseynov] add css class with smaller font for revision date
0445b42 [Khalid Huseynov] move date to right, add time
4607c03 [Khalid Huseynov] fix css
e6bafde [Khalid Huseynov] change time format
2090d60 [Khalid Huseynov] mock listRevisionHistory
1d20aeb [Khalid Huseynov] fix jshint checkstyle
ee7b94f [Damien CORNEAU] Reverse revisions order to have the latest first
9523b48 [Damien CORNEAU] Add dropdown of revisions
660139b [Damien CORNEAU] fix the jscs error
bcf6cf1 [Khalid Huseynov] return list on successful commit
18d430a [Khalid Huseynov] add initial listing
b4c69df [Khalid Huseynov] add test: revision history, multiple notes
d8f4282 [Khalid Huseynov] add new note resource for tests with multiple notes
a7e8fd8 [Khalid Huseynov] initial impl
### What is this PR for?
This PR replace JsHint with Eslint, the original configuration was ported from jsHint using [Polyjuice](https://www.npmjs.com/package/polyjuice), then the settings were tuned to match exactly.
For this PR, the goal is not to add new rules, but only to replace the system with the same rules.
### What type of PR is it?
Improvement
### Todos
* [x] - Remove .jshintrc
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1089
### How should this be tested?
You can simply build the code.
You can try to add an unused variable in the js code to see an error.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Damien CORNEAU <[email protected]>
Closes#1204 from corneadoug/ZEPPELIN-1089 and squashes the following commits:
6cf1e2a [Damien CORNEAU] fix $ is missing error
e71389d [Damien CORNEAU] remove jshint remnants
e1b389f [Damien CORNEAU] remove .jsintrc
0364ad4 [Damien CORNEAU] Fix eslint for tests
7b1da05 [Damien CORNEAU] Replace JsHint by Eslint
### What is this PR for?
Reopening the PR https://github.com/apache/zeppelin/pull/229 for jscs in zeppelin-web, using following in .jscsrc
```
{
"preset": "google",
"maximumLineLength": {
"value": 120,
"allExcept": [ "comments", "regex"]
}
}
```
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-235](https://issues.apache.org/jira/browse/ZEPPELIN-235)
### How should this be tested?
Try changing the indentation in any javascript file, and see an error being shown in the terminal on compile/build
### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a
Author: Prabhjyot Singh <[email protected]>
Closes#1139 from prabhjyotsingh/ZEPPELIN-235 and squashes the following commits:
9cc3cde [Prabhjyot Singh] resove merge errors
a274efa [Prabhjyot Singh] Merge remote-tracking branch 'origin/master' into ZEPPELIN-235
c16d2c7 [Prabhjyot Singh] addressing @corneadoug feedback
bffd134 [Prabhjyot Singh] revert 4 space changes for notebook.controller.js
02de55d [Prabhjyot Singh] jscs in zeppelin-web
Harmonize the tests titles, and improve a couple of tests
Author: Damien Corneau <[email protected]>
Closes#289 from corneadoug/improve/webTestWording and squashes the following commits:
c116fac [Damien Corneau] Rename and improve existing zeppelin-web tests
Author: Renjith Kamath <[email protected]>
Closes#250 from r-kamath/ZEPPELIN-228 and squashes the following commits:
6735aac [Renjith Kamath] Merge branch 'master' into ZEPPELIN-228
743a13d [Renjith Kamath] ZEPPELIN-228 add tests for paragraph controller and update notebook tests
a750a30 [Renjith Kamath] ZEPPELIN-228 add more tests for getCronOptionNameFromValue
48bfb95 [Renjith Kamath] ZEPPELIN-228 add unit tests for controllers
Fix jshint warning/error break zeppelin-web build.
Author: Lee moon soo <[email protected]>
Closes#202 from Leemoonsoo/fix_jshint and squashes the following commits:
7065ec5 [Lee moon soo] Fix jshint error/warning
All the test in zeppelin web was failed. Contain older version code
Here is the fixed.
- [x] Fixing Karma config
- [x] Handle js file paths in Karma config in atomically
- [x] Fixing config properties
- [x] Updating test spec for current code base version
Author: madhuka <[email protected]>
Closes#179 from Madhuka/milestone06-test-new and squashes the following commits:
b270395 [madhuka] fixing grunt test
