Commit graph

5 commits

Author SHA1 Message Date
1ambda
5595bfb9d0 [ZEPPELIN-1695] Enforce pom.xml style while removing useless, unapplied conf
### What is this PR for?

**First of all, this PR doesn't affect on runtime application behaivor and existing build processes. Just adding validation and styling**

The main goal of this PR is to keep consistency among multiple pom.xml files

- added xml-maven-plugin to enforce valid maven conf and xml code style (included in maven verify phase)
- while removing 2 invalid `combine.children` conf (they are invalid, useless. see commit messages)
- apply 2 space indent according to [maven style guide](https://maven.apache.org/developers/conventions/code.html)

For reviewers,

most code modification is due to 4064057 (re-indent commit), **so skipping the commit will be helpful to review this**.

### What type of PR is it?
[Improvement]

### Todos

* [x] - Add maven xml plugin
* [x] - Reindent according to maven style guide

### What is the Jira issue?

[ZEPPELIN-1695](https://issues.apache.org/jira/browse/ZEPPELIN-1695)

### How should this be tested?

CI will do that. Also you can type `mvn xml:validate` usually it takes 10+- seconds.

```
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [  2.444 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [  0.048 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [  0.029 s]
[INFO] Zeppelin: Display system apis ...................... SUCCESS [  0.025 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [  0.038 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [  0.040 s]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [  0.022 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [  0.013 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [  0.019 s]
[INFO] Zeppelin: Livy interpreter ......................... SUCCESS [  0.018 s]
[INFO] Zeppelin: HBase interpreter ........................ SUCCESS [  0.014 s]
[INFO] Zeppelin: Apache Pig Interpreter ................... SUCCESS [  0.016 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [  0.012 s]
[INFO] Zeppelin: JDBC interpreter ......................... SUCCESS [  0.012 s]
[INFO] Zeppelin: File System Interpreters ................. SUCCESS [  0.025 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [  0.048 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [  0.013 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [  0.010 s]
[INFO] Zeppelin: Python interpreter ....................... SUCCESS [  0.011 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [  0.015 s]
[INFO] Zeppelin: Apache Cassandra interpreter ............. SUCCESS [  0.036 s]
[INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [  0.014 s]
[INFO] Zeppelin: BigQuery interpreter ..................... SUCCESS [  0.012 s]
[INFO] Zeppelin: Alluxio interpreter ...................... SUCCESS [  0.011 s]
[INFO] Zeppelin: Scio ..................................... SUCCESS [  0.026 s]
[INFO] Zeppelin: web Application .......................... SUCCESS [  1.193 s]
[INFO] Zeppelin: Server ................................... SUCCESS [  0.015 s]
[INFO] Zeppelin: Packaging distribution ................... SUCCESS [  0.022 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.678 s
[INFO] Finished at: 2016-11-22T00:24:32+09:00
[INFO] Final Memory: 27M/703M
[INFO] ------------------------------------------------------------------------
```

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO

Author: 1ambda <1amb4a@gmail.com>

Closes #1662 from 1ambda/feat/check-pom-file-is-well-formed and squashes the following commits:

2d8d7d2 [1ambda] fix: Remove useless combine.children=append
f858a16 [1ambda] fix: Use _tools/maven-4.0.0.xsd
1142b46 [1ambda] fix: Remove useless encoding options
03579e7 [1ambda] fix: Remove useless combine.chdilren
4418cad [1ambda] feat: Add xml-maven-plugin to validate pom.xml
2016-11-24 18:31:41 +09:00
Lee moon soo
f0301cdfa4 ZEPPELIN-44 Interpreter for Apache Flink
#### Interpreter for [Apache Flink](http://flink.apache.org/).

Flink people helped a lot to write the interpreter. Thanks so much! Some codes are copied from Flink's development branch. Once Flink releases 0.9, copied code and snapshot repository configuration will be removed.

#### Build

if there're no options, by default it is building against flink 0.9.0-milestone-1.
With combination of Zeppelin, it is good idea to use 0.9-SNAPSHOT, because of it support .collect() that helps really a lot to get results data and display it on Zeppelin.

So, you might want to build in this way,

```
mvn package -Dflink.version=0.9-SNAPSHOT -DskipTests
```

#### Screenshot

![image](https://cloud.githubusercontent.com/assets/1540981/7674014/32c0ee68-fd59-11e4-9ee6-5ec0bbf6a8f2.png)

Author: Lee moon soo <moon@apache.org>

Closes #75 from Leemoonsoo/flink and squashes the following commits:

f08bd25 [Lee moon soo] Update pom.xml after https://github.com/apache/incubator-zeppelin/pull/88
460cf46 [Lee moon soo] jarr up -> jar up
501efb3 [Lee moon soo] Add scalastyle
e69e5ba [Lee moon soo] Add license
7be1f90 [Lee moon soo] Add apache snapshot repo
ebbd0da [Lee moon soo] Fix unittest and update comment
27fc306 [Lee moon soo] Cleaning up
f2a66df [Lee moon soo] Initial implementation of interpreter for Apache Flink
2015-06-09 11:14:42 -07:00
Lee moon soo
669d408dc9 Rename package/groupId to org.apache and apply rat plugin.
This PR handles https://issues.apache.org/jira/browse/ZEPPELIN-12.

* groupId at pom.xml file is changed from com.nflabs.zeppelin to org.apache.zeppelin
* package name is changed from com.nflabs.zeppelin to org.apache.zeppelin
* apache-rat plugin is applied (license header is added to every file) and NOTICE is updated (https://www.apache.org/legal/src-headers.html)
* removed sphinx doc. because of doc was out dated (it was for 0.3.0)

Please, review the changes. Especially, check NOTICE file if there're something i missed.

Author: Lee moon soo <moon@apache.org>

Closes #13 from Leemoonsoo/rat and squashes the following commits:

892695f [Lee moon soo] hive interpreter module com.nflabs -> org.apache. Add license to the hive/pom.xml
c9a07c9 [Lee moon soo] Use correct package name
06a802a [Lee moon soo] One file is missed while renaming it
9902997 [Lee moon soo] Add missing import
643530a [Lee moon soo] Exclude .log from rat
fb15d0b [Lee moon soo] Exclude dependency-reduced-pom.xml from rat plugin
5faf7b1 [Lee moon soo] Apply rat plugin and com.nflabs -> org.apache
5edc77b [Lee moon soo] Update license of ScreenCaptureHtmlUnitDriver.java
1bfef1f [Lee moon soo] Update notice file
d7172fe [Lee moon soo] Add source file license header
92eb87f [Lee moon soo] Remove old sphinx doc
be06c43 [Lee moon soo] Remove unused erb
1ffca75 [Lee moon soo] Remove unused file
2015-04-06 13:05:04 +09:00
Lee moon soo
d2e8de7953 Check code indentation.
Turn on failOnViolation
2014-11-26 11:15:36 +09:00
anthony corbacho
e346aeb4f3 Add checkstyle for google convention and site template 2014-11-20 14:54:44 +09:00